Re: [PATCH] image-fuzzer: Use OSerror.strerror instead of tuple subscript

[Stefan Hajnoczi]

On Mon, Oct 21, 2019 at 06:41:17PM -0300, Eduardo Habkost wrote:
> OSError can't be used like a tuple on Python 3, so change the
> code to use `e.sterror` instead of `e[1]`.
> 
> Reported-by: John Snow 
> Signed-off-by: Eduardo Habkost 
> ---
>  tests/image-fuzzer/runner.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan


signature.asc
Description: PGP signature

Re: [PATCH] image-fuzzer: Use OSerror.strerror instead of tuple subscript

[John Snow]

On 10/21/19 5:41 PM, Eduardo Habkost wrote:
> OSError can't be used like a tuple on Python 3, so change the
> code to use `e.sterror` instead of `e[1]`.
> 
> Reported-by: John Snow 
> Signed-off-by: Eduardo Habkost 

Reviewed-by: John Snow 

> ---
>  tests/image-fuzzer/runner.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/image-fuzzer/runner.py b/tests/image-fuzzer/runner.py
> index 95d84f38f3..1eb2138f94 100755
> --- a/tests/image-fuzzer/runner.py
> +++ b/tests/image-fuzzer/runner.py
> @@ -159,7 +159,7 @@ class TestEnv(object):
>  os.makedirs(self.current_dir)
>  except OSError as e:
>  print("Error: The working directory '%s' cannot be used. Reason: 
> %s"\
> -% (self.work_dir, e[1]), file=sys.stderr)
> +% (self.work_dir, e.strerror), file=sys.stderr)
>  raise TestException
>  self.log = open(os.path.join(self.current_dir, "test.log"), "w")
>  self.parent_log = open(run_log, "a")
> @@ -246,7 +246,7 @@ class TestEnv(object):
>  except OSError as e:
>  multilog("%sError: Start of '%s' failed. Reason: %s\n\n"
>   % (test_summary, os.path.basename(current_cmd[0]),
> -e[1]),
> +e.strerror),
>   sys.stderr, self.log, self.parent_log)
>  raise TestException
>  
> 

-- 
—js

[PATCH] image-fuzzer: Use OSerror.strerror instead of tuple subscript

[Eduardo Habkost]

OSError can't be used like a tuple on Python 3, so change the
code to use `e.sterror` instead of `e[1]`.

Reported-by: John Snow 
Signed-off-by: Eduardo Habkost 
---
 tests/image-fuzzer/runner.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/image-fuzzer/runner.py b/tests/image-fuzzer/runner.py
index 95d84f38f3..1eb2138f94 100755
--- a/tests/image-fuzzer/runner.py
+++ b/tests/image-fuzzer/runner.py
@@ -159,7 +159,7 @@ class TestEnv(object):
 os.makedirs(self.current_dir)
 except OSError as e:
 print("Error: The working directory '%s' cannot be used. Reason: 
%s"\
-% (self.work_dir, e[1]), file=sys.stderr)
+% (self.work_dir, e.strerror), file=sys.stderr)
 raise TestException
 self.log = open(os.path.join(self.current_dir, "test.log"), "w")
 self.parent_log = open(run_log, "a")
@@ -246,7 +246,7 @@ class TestEnv(object):
 except OSError as e:
 multilog("%sError: Start of '%s' failed. Reason: %s\n\n"
  % (test_summary, os.path.basename(current_cmd[0]),
-e[1]),
+e.strerror),
  sys.stderr, self.log, self.parent_log)
 raise TestException
 
-- 
2.21.0