Re: [PATCH 0/2] block: commit/stream: Allow users to request only format driver names in backing file format

2023-11-29 Thread Vladimir Sementsov-Ogievskiy

On 24.11.23 17:52, Peter Krempa wrote:

Please see patches for rationale.

Libvirt patches using this new flag will be posted soon-ish (after
cleanup).

Peter Krempa (2):
   block: commit: Allow users to request only format driver names in
 backing file format
   block: stream: Allow users to request only format driver names in
 backing file format

  block.c| 37 +-
  block/commit.c |  6 -
  block/monitor/block-hmp-cmds.c |  2 +-
  block/stream.c | 10 ++-
  blockdev.c | 13 +
  include/block/block-global-state.h |  3 ++-
  include/block/block_int-common.h   |  4 ++-
  include/block/block_int-global-state.h |  6 +
  qapi/block-core.json   | 22 +--
  tests/unit/test-bdrv-drain.c   |  3 ++-
  10 files changed, 91 insertions(+), 15 deletions(-)



Now seems good to me. Still:

1. Will need to update "since: 8.2" to 9, right?

2. Probably, use some shorter name... But I don't have good suggestion. 
Wouldn't that become a longest name in QAPI?)

--
Best regards,
Vladimir




[PATCH 0/2] block: commit/stream: Allow users to request only format driver names in backing file format

2023-11-24 Thread Peter Krempa
Please see patches for rationale.

Libvirt patches using this new flag will be posted soon-ish (after
cleanup).

Peter Krempa (2):
  block: commit: Allow users to request only format driver names in
backing file format
  block: stream: Allow users to request only format driver names in
backing file format

 block.c| 37 +-
 block/commit.c |  6 -
 block/monitor/block-hmp-cmds.c |  2 +-
 block/stream.c | 10 ++-
 blockdev.c | 13 +
 include/block/block-global-state.h |  3 ++-
 include/block/block_int-common.h   |  4 ++-
 include/block/block_int-global-state.h |  6 +
 qapi/block-core.json   | 22 +--
 tests/unit/test-bdrv-drain.c   |  3 ++-
 10 files changed, 91 insertions(+), 15 deletions(-)

-- 
2.43.0