Re: [PATCH v2 02/21] iotests/qcow2.py: Split feature fields into bits

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote:
> Print the feature fields as a set of bits so that filtering is easier.
> 
> Signed-off-by: Max Reitz 
> ---
>  tests/qemu-iotests/031.out  | 36 +--
>  tests/qemu-iotests/036.out  | 18 +-
>  tests/qemu-iotests/039.out  | 22 ++--
>  tests/qemu-iotests/060.out  | 20 +--
>  tests/qemu-iotests/061.out  | 72 ++---
>  tests/qemu-iotests/137.out  |  2 +-
>  tests/qemu-iotests/qcow2.py | 18 +++---
>  7 files changed, 99 insertions(+), 89 deletions(-)
> 
> diff --git a/tests/qemu-iotests/031.out b/tests/qemu-iotests/031.out
> index 68a74d03b9..d535e407bc 100644
> --- a/tests/qemu-iotests/031.out
> +++ b/tests/qemu-iotests/031.out
> @@ -18,9 +18,9 @@ refcount_table_offset 0x1
>  refcount_table_clusters   1
>  nb_snapshots  0
>  snapshot_offset   0x0
> -incompatible_features 0x0
> -compatible_features   0x0
> -autoclear_features0x0
> +incompatible_features []
> +compatible_features   []
> +autoclear_features[]
>  refcount_order4
>  header_length 72
>  
> @@ -46,9 +46,9 @@ refcount_table_offset 0x1
>  refcount_table_clusters   1
>  nb_snapshots  0
>  snapshot_offset   0x0
> -incompatible_features 0x0
> -compatible_features   0x0
> -autoclear_features0x0
> +incompatible_features []
> +compatible_features   []
> +autoclear_features[]
>  refcount_order4
>  header_length 72
>  
> @@ -74,9 +74,9 @@ refcount_table_offset 0x1
>  refcount_table_clusters   1
>  nb_snapshots  0
>  snapshot_offset   0x0
> -incompatible_features 0x0
> -compatible_features   0x0
> -autoclear_features0x0
> +incompatible_features []
> +compatible_features   []
> +autoclear_features[]
>  refcount_order4
>  header_length 72
>  
> @@ -109,9 +109,9 @@ refcount_table_offset 0x1
>  refcount_table_clusters   1
>  nb_snapshots  0
>  snapshot_offset   0x0
> -incompatible_features 0x0
> -compatible_features   0x0
> -autoclear_features0x0
> +incompatible_features []
> +compatible_features   []
> +autoclear_features[]
>  refcount_order4
>  header_length 104
>  
> @@ -142,9 +142,9 @@ refcount_table_offset 0x1
>  refcount_table_clusters   1
>  nb_snapshots  0
>  snapshot_offset   0x0
> -incompatible_features 0x0
> -compatible_features   0x0
> -autoclear_features0x0
> +incompatible_features []
> +compatible_features   []
> +autoclear_features[]
>  refcount_order4
>  header_length 104
>  
> @@ -175,9 +175,9 @@ refcount_table_offset 0x1
>  refcount_table_clusters   1
>  nb_snapshots  0
>  snapshot_offset   0x0
> -incompatible_features 0x0
> -compatible_features   0x0
> -autoclear_features0x0
> +incompatible_features []
> +compatible_features   []
> +autoclear_features[]
>  refcount_order4
>  header_length 104
>  
> diff --git a/tests/qemu-iotests/036.out b/tests/qemu-iotests/036.out
> index e489b44386..15229a9604 100644
> --- a/tests/qemu-iotests/036.out
> +++ b/tests/qemu-iotests/036.out
> @@ -16,9 +16,9 @@ refcount_table_offset 0x1
>  refcount_table_clusters   1
>  nb_snapshots  0
>  snapshot_offset   0x0
> -incompatible_features 0x8000
> -compatible_features   0x0
> -autoclear_features0x0
> +incompatible_features [63]
> +compatible_features   []
> +autoclear_features[]
>  refcount_order4
>  header_length 104
>  
> @@ -50,9 +50,9 @@ refcount_table_offset 0x1
>  refcount_table_clusters   1
>  nb_snapshots  0
>  snapshot_offset   0x0
> -incompatible_features 0x0
> -compatible_features   0x0
> -autoclear_features0x8000
> +incompatible_features []
> +compatible_features   []
> +autoclear_features[63]
>  refcount_order4
>  header_length 104
>  
> @@ -78,9 +78,9 @@ refcount_table_offset 0x1
>  refcount_table_clusters   1
>  nb_snapshots  0
>  snapshot_offset   0x0
> -incompatible_features 0x0
> -compatible_features   0x0
> -autoclear_features0x0
> +incompatible_features []
> +compatible_features   []
> +autoclear_features[]
>  refcount_order4
>  header_length 104
>  
> diff --git a/tests/qemu-iotests/039.out b/tests/qemu-iotests/039.out
> index 2e356d51b6..bdafa3ace3 100644
> --- a/tests/qemu-iotests/039.out
> +++ b/tests/qemu-iotests/039.out
> @@ -4,7 +4,7 @@ QA output created by 039
>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
>  wrote 512/512 bytes at offset 

[PATCH v2 02/21] iotests/qcow2.py: Split feature fields into bits

2019-10-15 Thread Max Reitz
Print the feature fields as a set of bits so that filtering is easier.

Signed-off-by: Max Reitz 
---
 tests/qemu-iotests/031.out  | 36 +--
 tests/qemu-iotests/036.out  | 18 +-
 tests/qemu-iotests/039.out  | 22 ++--
 tests/qemu-iotests/060.out  | 20 +--
 tests/qemu-iotests/061.out  | 72 ++---
 tests/qemu-iotests/137.out  |  2 +-
 tests/qemu-iotests/qcow2.py | 18 +++---
 7 files changed, 99 insertions(+), 89 deletions(-)

diff --git a/tests/qemu-iotests/031.out b/tests/qemu-iotests/031.out
index 68a74d03b9..d535e407bc 100644
--- a/tests/qemu-iotests/031.out
+++ b/tests/qemu-iotests/031.out
@@ -18,9 +18,9 @@ refcount_table_offset 0x1
 refcount_table_clusters   1
 nb_snapshots  0
 snapshot_offset   0x0
-incompatible_features 0x0
-compatible_features   0x0
-autoclear_features0x0
+incompatible_features []
+compatible_features   []
+autoclear_features[]
 refcount_order4
 header_length 72
 
@@ -46,9 +46,9 @@ refcount_table_offset 0x1
 refcount_table_clusters   1
 nb_snapshots  0
 snapshot_offset   0x0
-incompatible_features 0x0
-compatible_features   0x0
-autoclear_features0x0
+incompatible_features []
+compatible_features   []
+autoclear_features[]
 refcount_order4
 header_length 72
 
@@ -74,9 +74,9 @@ refcount_table_offset 0x1
 refcount_table_clusters   1
 nb_snapshots  0
 snapshot_offset   0x0
-incompatible_features 0x0
-compatible_features   0x0
-autoclear_features0x0
+incompatible_features []
+compatible_features   []
+autoclear_features[]
 refcount_order4
 header_length 72
 
@@ -109,9 +109,9 @@ refcount_table_offset 0x1
 refcount_table_clusters   1
 nb_snapshots  0
 snapshot_offset   0x0
-incompatible_features 0x0
-compatible_features   0x0
-autoclear_features0x0
+incompatible_features []
+compatible_features   []
+autoclear_features[]
 refcount_order4
 header_length 104
 
@@ -142,9 +142,9 @@ refcount_table_offset 0x1
 refcount_table_clusters   1
 nb_snapshots  0
 snapshot_offset   0x0
-incompatible_features 0x0
-compatible_features   0x0
-autoclear_features0x0
+incompatible_features []
+compatible_features   []
+autoclear_features[]
 refcount_order4
 header_length 104
 
@@ -175,9 +175,9 @@ refcount_table_offset 0x1
 refcount_table_clusters   1
 nb_snapshots  0
 snapshot_offset   0x0
-incompatible_features 0x0
-compatible_features   0x0
-autoclear_features0x0
+incompatible_features []
+compatible_features   []
+autoclear_features[]
 refcount_order4
 header_length 104
 
diff --git a/tests/qemu-iotests/036.out b/tests/qemu-iotests/036.out
index e489b44386..15229a9604 100644
--- a/tests/qemu-iotests/036.out
+++ b/tests/qemu-iotests/036.out
@@ -16,9 +16,9 @@ refcount_table_offset 0x1
 refcount_table_clusters   1
 nb_snapshots  0
 snapshot_offset   0x0
-incompatible_features 0x8000
-compatible_features   0x0
-autoclear_features0x0
+incompatible_features [63]
+compatible_features   []
+autoclear_features[]
 refcount_order4
 header_length 104
 
@@ -50,9 +50,9 @@ refcount_table_offset 0x1
 refcount_table_clusters   1
 nb_snapshots  0
 snapshot_offset   0x0
-incompatible_features 0x0
-compatible_features   0x0
-autoclear_features0x8000
+incompatible_features []
+compatible_features   []
+autoclear_features[63]
 refcount_order4
 header_length 104
 
@@ -78,9 +78,9 @@ refcount_table_offset 0x1
 refcount_table_clusters   1
 nb_snapshots  0
 snapshot_offset   0x0
-incompatible_features 0x0
-compatible_features   0x0
-autoclear_features0x0
+incompatible_features []
+compatible_features   []
+autoclear_features[]
 refcount_order4
 header_length 104
 
diff --git a/tests/qemu-iotests/039.out b/tests/qemu-iotests/039.out
index 2e356d51b6..bdafa3ace3 100644
--- a/tests/qemu-iotests/039.out
+++ b/tests/qemu-iotests/039.out
@@ -4,7 +4,7 @@ QA output created by 039
 Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
 wrote 512/512 bytes at offset 0
 512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-incompatible_features 0x0
+incompatible_features []
 No errors were found on the image.
 
 == Creating a dirty image file ==
@@ -12,7 +12,7 @@ Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
 wrote 512/512 bytes at offset 0
 512 bytes, X ops; XX:XX:XX.X (XXX