Re: [PATCH v5 0/2] block/blkio: support fd passing for virtio-blk-vhost-vdpa driver
On Tue, May 30, 2023 at 09:19:39AM +0200, Stefano Garzarella wrote: > v5: > - moved `features` to the object level to simplify libvirt code [Jonathon] > - wrapped a line too long in the documentation [Markus] > - added Stefan R-b tags > > v4: > https://lore.kernel.org/qemu-devel/20230526150304.158206-1-sgarz...@redhat.com/ > - added patch 02 to allow libvirt to discover we support fdset [Markus] > - modified the commit description of patch 01 > > v3: > https://lore.kernel.org/qemu-devel/20230511091527.46620-1-sgarz...@redhat.com/ > - use qemu_open() on `path` to simplify libvirt code [Jonathon] > - remove patch 01 since we are not using monitor_fd_param() anymore > > v2: > https://lore.kernel.org/qemu-devel/20230504092843.62493-1-sgarz...@redhat.com/ > - added patch 01 to use monitor_fd_param() in the blkio module > - use monitor_fd_param() to parse the fd like vhost devices [Stefan] > > v1: > https://lore.kernel.org/qemu-devel/20230502145050.224615-1-sgarz...@redhat.com/ > > The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the new > 'fd' property. Let's expose this to the user, so the management layer > can pass the file descriptor of an already opened vhost-vdpa character > device. This is useful especially when the device can only be accessed > with certain privileges. > > Stefano Garzarella (2): > block/blkio: use qemu_open() to support fd passing for virtio-blk > qapi: add '@fdset' feature for BlockdevOptionsVirtioBlkVhostVdpa > > meson.build | 4 > qapi/block-core.json | 6 + > block/blkio.c| 53 > 3 files changed, 54 insertions(+), 9 deletions(-) > > -- > 2.40.1 > Thanks, applied to my block tree: https://gitlab.com/stefanha/qemu/commits/block Stefan signature.asc Description: PGP signature
Re: [PATCH v5 0/2] block/blkio: support fd passing for virtio-blk-vhost-vdpa driver
On 5/30/23 2:19 AM, Stefano Garzarella wrote: v5: - moved `features` to the object level to simplify libvirt code [Jonathon] - wrapped a line too long in the documentation [Markus] - added Stefan R-b tags v4: https://lore.kernel.org/qemu-devel/20230526150304.158206-1-sgarz...@redhat.com/ - added patch 02 to allow libvirt to discover we support fdset [Markus] - modified the commit description of patch 01 v3: https://lore.kernel.org/qemu-devel/20230511091527.46620-1-sgarz...@redhat.com/ - use qemu_open() on `path` to simplify libvirt code [Jonathon] - remove patch 01 since we are not using monitor_fd_param() anymore v2: https://lore.kernel.org/qemu-devel/20230504092843.62493-1-sgarz...@redhat.com/ - added patch 01 to use monitor_fd_param() in the blkio module - use monitor_fd_param() to parse the fd like vhost devices [Stefan] v1: https://lore.kernel.org/qemu-devel/20230502145050.224615-1-sgarz...@redhat.com/ The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the new 'fd' property. Let's expose this to the user, so the management layer can pass the file descriptor of an already opened vhost-vdpa character device. This is useful especially when the device can only be accessed with certain privileges. Stefano Garzarella (2): block/blkio: use qemu_open() to support fd passing for virtio-blk qapi: add '@fdset' feature for BlockdevOptionsVirtioBlkVhostVdpa meson.build | 4 qapi/block-core.json | 6 + block/blkio.c| 53 3 files changed, 54 insertions(+), 9 deletions(-) Looks good from my perspective as a libvirt developer. Thanks, Jonathon
[PATCH v5 0/2] block/blkio: support fd passing for virtio-blk-vhost-vdpa driver
v5: - moved `features` to the object level to simplify libvirt code [Jonathon] - wrapped a line too long in the documentation [Markus] - added Stefan R-b tags v4: https://lore.kernel.org/qemu-devel/20230526150304.158206-1-sgarz...@redhat.com/ - added patch 02 to allow libvirt to discover we support fdset [Markus] - modified the commit description of patch 01 v3: https://lore.kernel.org/qemu-devel/20230511091527.46620-1-sgarz...@redhat.com/ - use qemu_open() on `path` to simplify libvirt code [Jonathon] - remove patch 01 since we are not using monitor_fd_param() anymore v2: https://lore.kernel.org/qemu-devel/20230504092843.62493-1-sgarz...@redhat.com/ - added patch 01 to use monitor_fd_param() in the blkio module - use monitor_fd_param() to parse the fd like vhost devices [Stefan] v1: https://lore.kernel.org/qemu-devel/20230502145050.224615-1-sgarz...@redhat.com/ The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the new 'fd' property. Let's expose this to the user, so the management layer can pass the file descriptor of an already opened vhost-vdpa character device. This is useful especially when the device can only be accessed with certain privileges. Stefano Garzarella (2): block/blkio: use qemu_open() to support fd passing for virtio-blk qapi: add '@fdset' feature for BlockdevOptionsVirtioBlkVhostVdpa meson.build | 4 qapi/block-core.json | 6 + block/blkio.c| 53 3 files changed, 54 insertions(+), 9 deletions(-) -- 2.40.1
