Re: [PULL 00/39] Migration 20231024 patches
On Fri, 27 Oct 2023 at 00:25, Juan Quintela wrote: > > Stefan Hajnoczi wrote: > > On Tue, 24 Oct 2023 at 23:45, Juan Quintela wrote: > >> > >> The following changes since commit > >> a95260486aa7e78d7c7194eba65cf03311ad94ad: > >> > >> Merge tag 'pull-tcg-20231023' of https://gitlab.com/rth7680/qemu into > >> staging (2023-10-23 14:45:46 -0700) > >> > >> are available in the Git repository at: > >> > >> https://gitlab.com/juan.quintela/qemu.git > >> tags/migration-20231024-pull-request > >> > >> for you to fetch changes up to 088f7f03da3f5b3487091302b795c22b1bfe56fb: > >> > >> migration: Deprecate old compression method (2023-10-24 13:48:24 +0200) > >> > >> > >> Migration Pull request (20231024) > >> > >> Hi > >> > >> In this PULL: > >> - vmstate registration fixes (thomas, juan) > >> - start merging vmstate_section_needed changes (marc) > >> - migration depreactions (juan) > >> - migration documentation for backwards compatibility (juan) > >> > >> Please apply. > > > > Hi Juan, > > I'm seeing CI failures: > > https://gitlab.com/qemu-project/qemu/-/pipelines/1048630760 > > start with s390x: > > Errors: > > 32/840 qemu:qtest+qtest-s390x / qtest-s390x/qom-test > ERROR 50.27s killed by signal 6 SIGABRT > 104/840 qemu:qtest+qtest-s390x / qtest-s390x/test-hmp > ERROR 51.55s killed by signal 6 SIGABRT > 189/840 qemu:qtest+qtest-s390x / qtest-s390x/boot-serial-test > ERROR 54.07s killed by signal 6 SIGABRT > 192/840 qemu:qtest+qtest-s390x / qtest-s390x/qos-test > ERROR 51.29s killed by signal 6 SIGABRT > 519/840 qemu:qtest+qtest-s390x / qtest-s390x/test-filter-mirror > ERROR 50.36s killed by signal 6 SIGABRT > 520/840 qemu:qtest+qtest-s390x / qtest-s390x/test-netfilter > ERROR 51.03s killed by signal 6 SIGABRT > 522/840 qemu:qtest+qtest-s390x / qtest-s390x/device-plug-test > ERROR 50.99s killed by signal 6 SIGABRT > 523/840 qemu:qtest+qtest-s390x / qtest-s390x/test-filter-redirector > ERROR 54.14s killed by signal 6 SIGABRT > 524/840 qemu:qtest+qtest-s390x / qtest-s390x/drive_del-test > ERROR 53.40s killed by signal 6 SIGABRT > 525/840 qemu:qtest+qtest-s390x / qtest-s390x/virtio-ccw-test > ERROR 54.67s killed by signal 6 SIGABRT > 526/840 qemu:qtest+qtest-s390x / qtest-s390x/device-introspect-test > ERROR 51.15s killed by signal 6 SIGABRT > 527/840 qemu:qtest+qtest-s390x / qtest-s390x/cpu-plug-test > ERROR 51.21s killed by signal 6 SIGABRT > 535/840 qemu:qtest+qtest-s390x / qtest-s390x/qmp-test > ERROR 51.18s killed by signal 6 SIGABRT > 534/840 qemu:qtest+qtest-s390x / qtest-s390x/machine-none-test > ERROR 51.21s killed by signal 6 SIGABRT > 533/840 qemu:qtest+qtest-s390x / qtest-s390x/qmp-cmd-test > ERROR 51.22s killed by signal 6 SIGABRT > 549/840 qemu:qtest+qtest-s390x / qtest-s390x/readconfig-test > ERROR 51.20s killed by signal 6 SIGABRT > 644/840 qemu:block / io-qcow2-001 > ERROR 0.32s exit status 1 > 645/840 qemu:block / io-qcow2-002 > ERROR 0.32s exit status 1 > 646/840 qemu:block / io-qcow2-003 > ERROR 0.34s exit status 1 > 647/840 qemu:block / io-qcow2-004 > ERROR 0.31s exit status 1 > 648/840 qemu:block / io-qcow2-005 > ERROR 0.43s exit status 1 > 649/840 qemu:block / io-qcow2-007 > ERROR 0.34s exit status 1 > 650/840 qemu:block / io-qcow2-008 > ERROR 0.63s exit status 1 > 651/840 qemu:block / io-qcow2-009 > ERROR 0.32s exit status 1 > 652/840 qemu:block / io-qcow2-010 > ERROR 0.30s exit status 1 > 654/840 qemu:block / io-qcow2-011 > ERROR 0.31s exit status 1 > 655/840 qemu:block / io-qcow2-012 > ERROR 0.36s exit status 1 > 657/840 qemu:block / io-qcow2-013 > ERROR 0.51s exit status 1 > 658/840 qemu:block / io-qcow2-017 > ERROR
Re: [PULL 00/39] Migration 20231024 patches
Stefan Hajnoczi wrote: > On Tue, 24 Oct 2023 at 23:45, Juan Quintela wrote: >> >> The following changes since commit a95260486aa7e78d7c7194eba65cf03311ad94ad: >> >> Merge tag 'pull-tcg-20231023' of https://gitlab.com/rth7680/qemu into >> staging (2023-10-23 14:45:46 -0700) >> >> are available in the Git repository at: >> >> https://gitlab.com/juan.quintela/qemu.git >> tags/migration-20231024-pull-request >> >> for you to fetch changes up to 088f7f03da3f5b3487091302b795c22b1bfe56fb: >> >> migration: Deprecate old compression method (2023-10-24 13:48:24 +0200) >> >> >> Migration Pull request (20231024) >> >> Hi >> >> In this PULL: >> - vmstate registration fixes (thomas, juan) >> - start merging vmstate_section_needed changes (marc) >> - migration depreactions (juan) >> - migration documentation for backwards compatibility (juan) >> >> Please apply. > > Hi Juan, > I'm seeing CI failures: > https://gitlab.com/qemu-project/qemu/-/pipelines/1048630760 start with s390x: Errors: 32/840 qemu:qtest+qtest-s390x / qtest-s390x/qom-test ERROR 50.27s killed by signal 6 SIGABRT 104/840 qemu:qtest+qtest-s390x / qtest-s390x/test-hmp ERROR 51.55s killed by signal 6 SIGABRT 189/840 qemu:qtest+qtest-s390x / qtest-s390x/boot-serial-test ERROR 54.07s killed by signal 6 SIGABRT 192/840 qemu:qtest+qtest-s390x / qtest-s390x/qos-test ERROR 51.29s killed by signal 6 SIGABRT 519/840 qemu:qtest+qtest-s390x / qtest-s390x/test-filter-mirror ERROR 50.36s killed by signal 6 SIGABRT 520/840 qemu:qtest+qtest-s390x / qtest-s390x/test-netfilter ERROR 51.03s killed by signal 6 SIGABRT 522/840 qemu:qtest+qtest-s390x / qtest-s390x/device-plug-test ERROR 50.99s killed by signal 6 SIGABRT 523/840 qemu:qtest+qtest-s390x / qtest-s390x/test-filter-redirector ERROR 54.14s killed by signal 6 SIGABRT 524/840 qemu:qtest+qtest-s390x / qtest-s390x/drive_del-test ERROR 53.40s killed by signal 6 SIGABRT 525/840 qemu:qtest+qtest-s390x / qtest-s390x/virtio-ccw-test ERROR 54.67s killed by signal 6 SIGABRT 526/840 qemu:qtest+qtest-s390x / qtest-s390x/device-introspect-test ERROR 51.15s killed by signal 6 SIGABRT 527/840 qemu:qtest+qtest-s390x / qtest-s390x/cpu-plug-test ERROR 51.21s killed by signal 6 SIGABRT 535/840 qemu:qtest+qtest-s390x / qtest-s390x/qmp-test ERROR 51.18s killed by signal 6 SIGABRT 534/840 qemu:qtest+qtest-s390x / qtest-s390x/machine-none-test ERROR 51.21s killed by signal 6 SIGABRT 533/840 qemu:qtest+qtest-s390x / qtest-s390x/qmp-cmd-test ERROR 51.22s killed by signal 6 SIGABRT 549/840 qemu:qtest+qtest-s390x / qtest-s390x/readconfig-test ERROR 51.20s killed by signal 6 SIGABRT 644/840 qemu:block / io-qcow2-001 ERROR 0.32s exit status 1 645/840 qemu:block / io-qcow2-002 ERROR 0.32s exit status 1 646/840 qemu:block / io-qcow2-003 ERROR 0.34s exit status 1 647/840 qemu:block / io-qcow2-004 ERROR 0.31s exit status 1 648/840 qemu:block / io-qcow2-005 ERROR 0.43s exit status 1 649/840 qemu:block / io-qcow2-007 ERROR 0.34s exit status 1 650/840 qemu:block / io-qcow2-008 ERROR 0.63s exit status 1 651/840 qemu:block / io-qcow2-009 ERROR 0.32s exit status 1 652/840 qemu:block / io-qcow2-010 ERROR 0.30s exit status 1 654/840 qemu:block / io-qcow2-011 ERROR 0.31s exit status 1 655/840 qemu:block / io-qcow2-012 ERROR 0.36s exit status 1 657/840 qemu:block / io-qcow2-013 ERROR 0.51s exit status 1 658/840 qemu:block / io-qcow2-017 ERROR 0.37s exit status 1 659/840 qemu:block / io-qcow2-018 ERROR 0.31s exit status 1 660/840 qemu:block / io-qcow2-019 ERROR
Re: [PULL 00/39] Migration 20231024 patches
On Tue, 24 Oct 2023 at 23:45, Juan Quintela wrote: > > The following changes since commit a95260486aa7e78d7c7194eba65cf03311ad94ad: > > Merge tag 'pull-tcg-20231023' of https://gitlab.com/rth7680/qemu into > staging (2023-10-23 14:45:46 -0700) > > are available in the Git repository at: > > https://gitlab.com/juan.quintela/qemu.git > tags/migration-20231024-pull-request > > for you to fetch changes up to 088f7f03da3f5b3487091302b795c22b1bfe56fb: > > migration: Deprecate old compression method (2023-10-24 13:48:24 +0200) > > > Migration Pull request (20231024) > > Hi > > In this PULL: > - vmstate registration fixes (thomas, juan) > - start merging vmstate_section_needed changes (marc) > - migration depreactions (juan) > - migration documentation for backwards compatibility (juan) > > Please apply. Hi Juan, I'm seeing CI failures: https://gitlab.com/qemu-project/qemu/-/pipelines/1048630760 You can ignore avocado-system-debian, but the others look like real failures. Please take a look. Thanks! Stefan > > > > Juan Quintela (31): > migration/doc: Add contents > migration/doc: Add documentation for backwards compatiblity > migration/doc: How to migrate when hosts have different features > migration/doc: We broke backwards compatibility > migration: Receiving a zero page non zero is an error > migration: Rename ram_handle_compressed() to ram_handle_zero() > migration: Give one error if trying to set MULTIFD and XBZRLE > migration: Give one error if trying to set COMPRESSION and XBZRLE > migration: Remove save_page_use_compression() > migration: Make compress_data_with_multithreads return bool > migration: Simplify compress_page_with_multithread() > migration: Move busy++ to migrate_with_multithread > migration: Create compress_update_rates() > migration: Export send_queued_data() > migration: Move ram_flush_compressed_data() to ram-compress.c > migration: Merge flush_compressed_data() and compress_flush_data() > migration: Rename ram_compressed_pages() to compress_ram_pages() > migration: Create vmstate_register_any() > migration: Use vmstate_register_any() > migration: Use vmstate_register_any() for isa-ide > migration: Use VMSTATE_INSTANCE_ID_ANY for slirp > migration: Hack to maintain backwards compatibility for ppc > migration: Improve example and documentation of vmstate_register() > migration: Use vmstate_register_any() for audio > migration: Use vmstate_register_any() for eeprom93xx > migration: Use vmstate_register_any() for vmware_vga > qemu-iotests: Filter warnings about block migration being deprecated > migration: migrate 'inc' command option is deprecated. > migration: migrate 'blk' command option is deprecated. > migration: Deprecate block migration > migration: Deprecate old compression method > > Marc-André Lureau (2): > migration: rename vmstate_save_needed->vmstate_section_needed > migration: set file error on subsection loading > > Peter Xu (1): > migration: Check in savevm_state_handler_insert for dups > > Thomas Huth (5): > hw/ipmi: Don't call vmstate_register() from instance_init() functions > hw/s390x/s390-skeys: Don't call register_savevm_live() during > instance_init() > hw/s390x/s390-stattrib: Simplify handling of the "migration-enabled" > property > hw/s390x/s390-stattrib: Don't call register_savevm_live() during > instance_init() > migration/ram: Fix compilation with -Wshadow=local > > docs/about/deprecated.rst| 35 ++ > docs/devel/migration.rst | 532 ++- > qapi/migration.json | 93 -- > include/migration/vmstate.h | 30 +- > migration/ram-compress.h | 10 +- > migration/ram.h | 3 +- > audio/audio.c| 2 +- > backends/dbus-vmstate.c | 3 +- > backends/tpm/tpm_emulator.c | 3 +- > hw/display/vmware_vga.c | 2 +- > hw/i2c/core.c| 2 +- > hw/ide/isa.c | 2 +- > hw/input/adb.c | 2 +- > hw/input/ads7846.c | 2 +- > hw/input/stellaris_input.c | 3 +- > hw/intc/xics.c | 18 +- > hw/ipmi/ipmi_bmc_extern.c| 29 +- > hw/ipmi/isa_ipmi_bt.c| 34 +- > hw/ipmi/isa_ipmi_kcs.c | 50 +-- > hw/net/eepro100.c| 3 +- > hw/nvram/eeprom93xx.c| 2 +- > hw/pci/pci.c | 2 +- > hw/ppc/spapr.c | 25 +- > hw/ppc/spapr_nvdimm.c| 3 +- > hw/s390x/s390-skeys.c| 35 +- > hw/s390x/s390-stattrib.c | 71 ++--- > hw/timer/arm_timer.c | 2 +- > hw/virtio/virtio-mem.c | 4 +- > migration/block.c| 3 + > migration/migration-hmp-cmds.c | 10 + >
[PULL 00/39] Migration 20231024 patches
The following changes since commit a95260486aa7e78d7c7194eba65cf03311ad94ad: Merge tag 'pull-tcg-20231023' of https://gitlab.com/rth7680/qemu into staging (2023-10-23 14:45:46 -0700) are available in the Git repository at: https://gitlab.com/juan.quintela/qemu.git tags/migration-20231024-pull-request for you to fetch changes up to 088f7f03da3f5b3487091302b795c22b1bfe56fb: migration: Deprecate old compression method (2023-10-24 13:48:24 +0200) Migration Pull request (20231024) Hi In this PULL: - vmstate registration fixes (thomas, juan) - start merging vmstate_section_needed changes (marc) - migration depreactions (juan) - migration documentation for backwards compatibility (juan) Please apply. Juan Quintela (31): migration/doc: Add contents migration/doc: Add documentation for backwards compatiblity migration/doc: How to migrate when hosts have different features migration/doc: We broke backwards compatibility migration: Receiving a zero page non zero is an error migration: Rename ram_handle_compressed() to ram_handle_zero() migration: Give one error if trying to set MULTIFD and XBZRLE migration: Give one error if trying to set COMPRESSION and XBZRLE migration: Remove save_page_use_compression() migration: Make compress_data_with_multithreads return bool migration: Simplify compress_page_with_multithread() migration: Move busy++ to migrate_with_multithread migration: Create compress_update_rates() migration: Export send_queued_data() migration: Move ram_flush_compressed_data() to ram-compress.c migration: Merge flush_compressed_data() and compress_flush_data() migration: Rename ram_compressed_pages() to compress_ram_pages() migration: Create vmstate_register_any() migration: Use vmstate_register_any() migration: Use vmstate_register_any() for isa-ide migration: Use VMSTATE_INSTANCE_ID_ANY for slirp migration: Hack to maintain backwards compatibility for ppc migration: Improve example and documentation of vmstate_register() migration: Use vmstate_register_any() for audio migration: Use vmstate_register_any() for eeprom93xx migration: Use vmstate_register_any() for vmware_vga qemu-iotests: Filter warnings about block migration being deprecated migration: migrate 'inc' command option is deprecated. migration: migrate 'blk' command option is deprecated. migration: Deprecate block migration migration: Deprecate old compression method Marc-André Lureau (2): migration: rename vmstate_save_needed->vmstate_section_needed migration: set file error on subsection loading Peter Xu (1): migration: Check in savevm_state_handler_insert for dups Thomas Huth (5): hw/ipmi: Don't call vmstate_register() from instance_init() functions hw/s390x/s390-skeys: Don't call register_savevm_live() during instance_init() hw/s390x/s390-stattrib: Simplify handling of the "migration-enabled" property hw/s390x/s390-stattrib: Don't call register_savevm_live() during instance_init() migration/ram: Fix compilation with -Wshadow=local docs/about/deprecated.rst| 35 ++ docs/devel/migration.rst | 532 ++- qapi/migration.json | 93 -- include/migration/vmstate.h | 30 +- migration/ram-compress.h | 10 +- migration/ram.h | 3 +- audio/audio.c| 2 +- backends/dbus-vmstate.c | 3 +- backends/tpm/tpm_emulator.c | 3 +- hw/display/vmware_vga.c | 2 +- hw/i2c/core.c| 2 +- hw/ide/isa.c | 2 +- hw/input/adb.c | 2 +- hw/input/ads7846.c | 2 +- hw/input/stellaris_input.c | 3 +- hw/intc/xics.c | 18 +- hw/ipmi/ipmi_bmc_extern.c| 29 +- hw/ipmi/isa_ipmi_bt.c| 34 +- hw/ipmi/isa_ipmi_kcs.c | 50 +-- hw/net/eepro100.c| 3 +- hw/nvram/eeprom93xx.c| 2 +- hw/pci/pci.c | 2 +- hw/ppc/spapr.c | 25 +- hw/ppc/spapr_nvdimm.c| 3 +- hw/s390x/s390-skeys.c| 35 +- hw/s390x/s390-stattrib.c | 71 ++--- hw/timer/arm_timer.c | 2 +- hw/virtio/virtio-mem.c | 4 +- migration/block.c| 3 + migration/migration-hmp-cmds.c | 10 + migration/migration.c| 10 + migration/options.c | 36 ++- migration/ram-compress.c | 112 +-- migration/ram.c | 114 ++- migration/rdma.c | 8 +- migration/savevm.c | 34 +- migration/vmstate.c | 5 +- net/slirp.c | 5 +- tests/qemu-iotests/183 | 2 +- tests/qemu-iotests/common.filter | 7 + 40 files changed, 1041 insertions(+), 307
