Re: [Qemu-block] [PATCH] blkdebug: Don't confuse image as backing file

[Kevin Wolf]

Am 16.10.2015 um 12:46 hat Fam Zheng geschrieben:
> The word "backing file" nowadays refers to the backing_hd in the
> external snapshot sense (i.e. bs->backing_hd), instead of the file sense
> (bs->file). Correct the comment to use the right term.
> 
> Signed-off-by: Fam Zheng 

Thanks, applied to the block branch.

Kevin

Re: [Qemu-block] [PATCH] blkdebug: Don't confuse image as backing file

[Alberto Garcia]

On Fri 16 Oct 2015 12:46:04 PM CEST, Fam Zheng wrote:
> The word "backing file" nowadays refers to the backing_hd in the
> external snapshot sense (i.e. bs->backing_hd), instead of the file sense
> (bs->file). Correct the comment to use the right term.
>
> Signed-off-by: Fam Zheng 

Reviewed-by: Alberto Garcia 

Berto

[Qemu-block] [PATCH] blkdebug: Don't confuse image as backing file

[Fam Zheng]

The word "backing file" nowadays refers to the backing_hd in the
external snapshot sense (i.e. bs->backing_hd), instead of the file sense
(bs->file). Correct the comment to use the right term.

Signed-off-by: Fam Zheng 
---
 block/blkdebug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blkdebug.c b/block/blkdebug.c
index bc247f4..54650a7 100644
--- a/block/blkdebug.c
+++ b/block/blkdebug.c
@@ -426,7 +426,7 @@ static int blkdebug_open(BlockDriverState *bs, QDict 
*options, int flags,
 /* Set initial state */
 s->state = 1;
 
-/* Open the backing file */
+/* Open the image file */
 assert(bs->file == NULL);
 ret = bdrv_open_image(&bs->file, qemu_opt_get(opts, "x-image"), options, 
"image",
   bs, &child_file, false, &local_err);
-- 
2.4.3