Re: [Qemu-block] [PATCH] qemu-img: fix formatting of error message

[Kevin Wolf]

Am 06.04.2016 um 11:16 hat Daniel P. Berrange geschrieben:
> The error_reportf_err() will not automatically append a
> ': ' before adding its suffix, so we must include that
> in the message we pass it, otherwise we get a badly
> formatted message lacking whitespace:
> 
> qemu-img: Could not open 
> 'driver=nbd,host=127.0.0.1,port=,tls-creds=tls0'Failed to connect socket: 
> Connection refused
> 
> Signed-off-by: Daniel P. Berrange 

Thanks, applied to the block branch.

Kevin

[Qemu-block] [PATCH] qemu-img: fix formatting of error message

[Daniel P. Berrange]

The error_reportf_err() will not automatically append a
': ' before adding its suffix, so we must include that
in the message we pass it, otherwise we get a badly
formatted message lacking whitespace:

qemu-img: Could not open 
'driver=nbd,host=127.0.0.1,port=,tls-creds=tls0'Failed to connect socket: 
Connection refused

Signed-off-by: Daniel P. Berrange 
---
 qemu-img.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-img.c b/qemu-img.c
index 06264d9..17c5cfd 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -256,7 +256,7 @@ static BlockBackend *img_open_opts(const char *optstr,
 options = qemu_opts_to_qdict(opts, NULL);
 blk = blk_new_open(NULL, NULL, options, flags, _err);
 if (!blk) {
-error_reportf_err(local_err, "Could not open '%s'", optstr);
+error_reportf_err(local_err, "Could not open '%s': ", optstr);
 return NULL;
 }
 blk_set_enable_write_cache(blk, !writethrough);
-- 
2.5.5