Re: [Qemu-block] [PATCH 02/14] vhdx: Fix vhdx_co_create() return value

[Jeff Cody]

On Fri, May 25, 2018 at 06:33:15PM +0200, Kevin Wolf wrote:
> .bdrv_co_create() is supposed to return 0 on success, but vhdx could
> return a positive value instead. Fix this.
> 
> Signed-off-by: Kevin Wolf 
> ---
>  block/vhdx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/vhdx.c b/block/vhdx.c
> index 0b1e21c750..b1ba121bb6 100644
> --- a/block/vhdx.c
> +++ b/block/vhdx.c
> @@ -1951,7 +1951,7 @@ static int coroutine_fn 
> vhdx_co_create(BlockdevCreateOptions *opts,
>  goto delete_and_exit;
>  }
>  
> -
> +ret = 0;
>  delete_and_exit:
>  blk_unref(blk);
>  bdrv_unref(bs);
> -- 
> 2.13.6
> 
> 

Reviewed-by: Jeff Cody 

Re: [Qemu-block] [PATCH 02/14] vhdx: Fix vhdx_co_create() return value

[Max Reitz]

On 2018-05-25 18:33, Kevin Wolf wrote:
> .bdrv_co_create() is supposed to return 0 on success, but vhdx could
> return a positive value instead. Fix this.
> 
> Signed-off-by: Kevin Wolf 
> ---
>  block/vhdx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Max Reitz 



signature.asc
Description: OpenPGP digital signature

[Qemu-block] [PATCH 02/14] vhdx: Fix vhdx_co_create() return value

[Kevin Wolf]

.bdrv_co_create() is supposed to return 0 on success, but vhdx could
return a positive value instead. Fix this.

Signed-off-by: Kevin Wolf 
---
 block/vhdx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/vhdx.c b/block/vhdx.c
index 0b1e21c750..b1ba121bb6 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -1951,7 +1951,7 @@ static int coroutine_fn 
vhdx_co_create(BlockdevCreateOptions *opts,
 goto delete_and_exit;
 }
 
-
+ret = 0;
 delete_and_exit:
 blk_unref(blk);
 bdrv_unref(bs);
-- 
2.13.6