Re: [Qemu-block] [PATCH v2 0/6] nbd export qmp interface
Am 18.01.2018 um 23:45 hat Eric Blake geschrieben: > On 01/18/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote: > > v2: > > 01: tweak comment > > add Eric's r-b > > 02: new patch > > 03: rewritten, to move form 'bool force' flag to 'enum mode' parameter > > 04: add Eric's r-b > > 05: improve commit message > > tweak comment > > 06: rebase on 03 changes > > make PEP8 happy > > some other tweaks > > I've left nbd_port variable hard-set to 10900. I think all such things > > should be fixed together, and it is simple to change in future > > nbd_port = '10900' > > to > > nbd_port = iotests.get_free_port() > > if needed. > > > > [Unfortunately, qmp query-nbd-server is not finished yet, coming soon, > > but may be after my vocation on the next week] > > Enjoy your time off. I think the series is nearly ready to go; I had > some tweaks that I suggested, and will probably replace your 2/6 with my > counterproposal, but I don't mind doing that cleanup if you don't have > time to respin. I'll give it a few more days in case anyone else has > comments, then add it to my NBD queue. I haven't reviewed the patches in detail, but the API changes look good to me. Kevin signature.asc Description: PGP signature
Re: [Qemu-block] [PATCH v2 0/6] nbd export qmp interface
On 01/18/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote: > v2: > 01: tweak comment > add Eric's r-b > 02: new patch > 03: rewritten, to move form 'bool force' flag to 'enum mode' parameter > 04: add Eric's r-b > 05: improve commit message > tweak comment > 06: rebase on 03 changes > make PEP8 happy > some other tweaks > I've left nbd_port variable hard-set to 10900. I think all such things > should be fixed together, and it is simple to change in future > nbd_port = '10900' > to > nbd_port = iotests.get_free_port() > if needed. > > [Unfortunately, qmp query-nbd-server is not finished yet, coming soon, > but may be after my vocation on the next week] Enjoy your time off. I think the series is nearly ready to go; I had some tweaks that I suggested, and will probably replace your 2/6 with my counterproposal, but I don't mind doing that cleanup if you don't have time to respin. I'll give it a few more days in case anyone else has comments, then add it to my NBD queue. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature
[Qemu-block] [PATCH v2 0/6] nbd export qmp interface
v2: 01: tweak comment add Eric's r-b 02: new patch 03: rewritten, to move form 'bool force' flag to 'enum mode' parameter 04: add Eric's r-b 05: improve commit message tweak comment 06: rebase on 03 changes make PEP8 happy some other tweaks I've left nbd_port variable hard-set to 10900. I think all such things should be fixed together, and it is simple to change in future nbd_port = '10900' to nbd_port = iotests.get_free_port() if needed. [Unfortunately, qmp query-nbd-server is not finished yet, coming soon, but may be after my vocation on the next week] Vladimir Sementsov-Ogievskiy (6): qapi: add name parameter to nbd-server-add hmp: add name parameter to nbd_server_add qapi: add nbd-server-remove iotest 147: add cases to test new @name parameter of nbd-server-add iotests: implement QemuIoInteractive class iotest 201: new test for qmp nbd-server-remove qapi/block.json | 54 +- include/block/nbd.h | 1 + blockdev-nbd.c| 38 -- hmp.c | 6 +- nbd/server.c | 21 ++ hmp-commands.hx | 9 +-- tests/qemu-iotests/147| 68 ++ tests/qemu-iotests/147.out| 4 +- tests/qemu-iotests/201| 159 ++ tests/qemu-iotests/201.out| 5 ++ tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 38 ++ 12 files changed, 376 insertions(+), 28 deletions(-) create mode 100644 tests/qemu-iotests/201 create mode 100644 tests/qemu-iotests/201.out -- 2.11.1
[Qemu-block] [PATCH v2 0/6] nbd export qmp interface
Here: 1. separate export name from device name 1.1 several exports per device possible 2. add nbd-server-remove v2: 01: add r-bs by Max and Eric, add comment to code (hope you don't mind) 03: address export by its name, not by device name make it possible to force-remove export, which is already non-force-removed (thourh new "hidden" field) other patches are new v1: Add command to remove nbd export, pair to nbd-server-add. The whole thing and description are in patch 02. Vladimir Sementsov-Ogievskiy (6): nbd/server: add additional assert to nbd_export_put qapi: add name parameter to nbd-server-add qapi: add nbd-server-remove iotest 147: add cases to test new @name parameter of nbd-server-add iotests: implement QemuIoInteractive class iotest 201: new test for qmp nbd-server-remove qapi/block.json | 27 - include/block/nbd.h | 3 +- blockdev-nbd.c| 41 +++-- hmp.c | 5 +- nbd/server.c | 31 +- tests/qemu-iotests/147| 68 +- tests/qemu-iotests/147.out| 4 +- tests/qemu-iotests/201| 130 ++ tests/qemu-iotests/201.out| 5 ++ tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 38 11 files changed, 325 insertions(+), 28 deletions(-) create mode 100644 tests/qemu-iotests/201 create mode 100644 tests/qemu-iotests/201.out -- 2.11.1
