Re: [Qemu-block] [PATCH v3 2/5] util/qemu-sockets: Make inet_connect_saddr() public

[Kevin Wolf]

Am 17.10.2016 um 19:32 hat Ashijeet Acharya geschrieben:
> Make inet_connect_saddr() in util/qemu-sockets.c public in order to be
> able to use it with InetSocketAddress sockets outside of
> util/qemu-sockets.c independently.
> 
> Signed-off-by: Ashijeet Acharya 

Reviewed-by: Kevin Wolf 

[Qemu-block] [PATCH v3 2/5] util/qemu-sockets: Make inet_connect_saddr() public

[Ashijeet Acharya]

Make inet_connect_saddr() in util/qemu-sockets.c public in order to be
able to use it with InetSocketAddress sockets outside of
util/qemu-sockets.c independently.

Signed-off-by: Ashijeet Acharya 
---
 include/qemu/sockets.h | 2 ++
 util/qemu-sockets.c| 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h
index 9eb2470..5589e68 100644
--- a/include/qemu/sockets.h
+++ b/include/qemu/sockets.h
@@ -34,6 +34,8 @@ typedef void NonBlockingConnectHandler(int fd, Error *err, 
void *opaque);
 
 InetSocketAddress *inet_parse(const char *str, Error **errp);
 int inet_connect(const char *str, Error **errp);
+int inet_connect_saddr(InetSocketAddress *saddr, Error **errp,
+   NonBlockingConnectHandler *callback, void *opaque);
 
 NetworkAddressFamily inet_netfamily(int family);
 
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index 4cef549..31f7fc6 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -412,8 +412,8 @@ static struct addrinfo 
*inet_parse_connect_saddr(InetSocketAddress *saddr,
  * function succeeds, callback will be called when the connection
  * completes, with the file descriptor on success, or -1 on error.
  */
-static int inet_connect_saddr(InetSocketAddress *saddr, Error **errp,
-  NonBlockingConnectHandler *callback, void 
*opaque)
+int inet_connect_saddr(InetSocketAddress *saddr, Error **errp,
+   NonBlockingConnectHandler *callback, void *opaque)
 {
 Error *local_err = NULL;
 struct addrinfo *res, *e;
-- 
2.6.2