Re: [Qemu-block] [PATCH v5 2/6] qapi/qlist: Add qlist_append_null() macro

2017-09-21 Thread Alberto Garcia 
On Sat 16 Sep 2017 08:51:19 PM CEST, Max Reitz wrote:
> Signed-off-by: Max Reitz 

> @@ -37,6 +38,8 @@ typedef struct QList {
>  qlist_append(qlist, qbool_from_bool(value))
>  #define qlist_append_str(qlist, value) \
>  qlist_append(qlist, qstring_from_str(value))
> +#define qlist_append_null(qlist) \
> +qlist_append(qlist, qnull())

Reviewed-by: Alberto Garcia 

Berto

Re: [Qemu-block] [PATCH v5 2/6] qapi/qlist: Add qlist_append_null() macro

2017-09-18 Thread Eric Blake 
On 09/16/2017 01:51 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz 
> ---
>  include/qapi/qmp/qlist.h | 3 +++
>  1 file changed, 3 insertions(+)

Please update scripts/coccinelle/qobject.cocci to also cover this (since
we updated it for qdict_put_null() in 0f9afc2).

With that addition,
Reviewed-by: Eric Blake 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



signature.asc
Description: OpenPGP digital signature

[Qemu-block] [PATCH v5 2/6] qapi/qlist: Add qlist_append_null() macro

2017-09-16 Thread Max Reitz 
Signed-off-by: Max Reitz 
---
 include/qapi/qmp/qlist.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/qapi/qmp/qlist.h b/include/qapi/qmp/qlist.h
index c4b5fdad9b..59d209bbae 100644
--- a/include/qapi/qmp/qlist.h
+++ b/include/qapi/qmp/qlist.h
@@ -15,6 +15,7 @@
 
 #include "qapi/qmp/qobject.h"
 #include "qapi/qmp/qnum.h"
+#include "qapi/qmp/qnull.h"
 #include "qemu/queue.h"
 
 typedef struct QListEntry {
@@ -37,6 +38,8 @@ typedef struct QList {
 qlist_append(qlist, qbool_from_bool(value))
 #define qlist_append_str(qlist, value) \
 qlist_append(qlist, qstring_from_str(value))
+#define qlist_append_null(qlist) \
+qlist_append(qlist, qnull())
 
 #define QLIST_FOREACH_ENTRY(qlist, var) \
 for ((var) = ((qlist)->head.tqh_first); \
-- 
2.13.5