Re: [Qemu-block] [PATCH v8 04/10] qcow2: Use abort() instead of assert(false)

2015-06-04 Thread Alberto Garcia
On Wed 03 Jun 2015 10:13:33 PM CEST, Max Reitz wrote:
 Signed-off-by: Max Reitz mre...@redhat.com
 Reviewed-by: Eric Blake ebl...@redhat.com
 Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

Reviewed-by: Alberto Garcia be...@igalia.com

Berto



[Qemu-block] [PATCH v8 04/10] qcow2: Use abort() instead of assert(false)

2015-06-03 Thread Max Reitz
Signed-off-by: Max Reitz mre...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
---
 block/qcow2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/qcow2.c b/block/qcow2.c
index 0b514f9..c444960 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -2744,9 +2744,9 @@ static int qcow2_amend_options(BlockDriverState *bs, 
QemuOpts *opts,
 error_report(Cannot change refcount entry width);
 return -ENOTSUP;
 } else {
-/* if this assertion fails, this probably means a new option was
+/* if this point is reached, this probably means a new option was
  * added without having it covered here */
-assert(false);
+abort();
 }
 
 desc++;
-- 
2.4.1