Re: [Qemu-block] [Qemu-devel] [PATCH 3/9] block: Remove bdrv_aio_pdiscard()
On 10/21/2016 05:59 AM, Kevin Wolf wrote: > Am 20.10.2016 um 19:32 hat Eric Blake geschrieben: >> On 10/20/2016 08:46 AM, Kevin Wolf wrote: >>> It is unused now. >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> block/io.c| 29 - >>> block/trace-events| 1 - >>> include/block/block.h | 3 --- >>> 3 files changed, 33 deletions(-) >> >> Might be nice to research which commit id removed the last use, and >> mention it in the commit message as an idea for how long we've had dead >> code, but that's not a necessity. > > Patch 2 removed the last user. Aha. So maybe "removed in the previous patch" is all the more mention it needs, if at all. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
Re: [Qemu-block] [Qemu-devel] [PATCH 3/9] block: Remove bdrv_aio_pdiscard()
Am 20.10.2016 um 19:32 hat Eric Blake geschrieben: > On 10/20/2016 08:46 AM, Kevin Wolf wrote: > > It is unused now. > > > > Signed-off-by: Kevin Wolf > > --- > > block/io.c| 29 - > > block/trace-events| 1 - > > include/block/block.h | 3 --- > > 3 files changed, 33 deletions(-) > > Might be nice to research which commit id removed the last use, and > mention it in the commit message as an idea for how long we've had dead > code, but that's not a necessity. Patch 2 removed the last user. Kevin pgpU5Ror3TxJK.pgp Description: PGP signature
Re: [Qemu-block] [Qemu-devel] [PATCH 3/9] block: Remove bdrv_aio_pdiscard()
On 10/20/2016 08:46 AM, Kevin Wolf wrote: > It is unused now. > > Signed-off-by: Kevin Wolf > --- > block/io.c| 29 - > block/trace-events| 1 - > include/block/block.h | 3 --- > 3 files changed, 33 deletions(-) Might be nice to research which commit id removed the last use, and mention it in the commit message as an idea for how long we've had dead code, but that's not a necessity. Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
