Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 20180529172156.29311-1-kw...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/20] Drain fixes and cleanups, part 3 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20180529172156.29311-1-kw...@redhat.com -> patchew/20180529172156.29311-1-kw...@redhat.com Switched to a new branch 'test' eab5e8287f test-bdrv-drain: Test graph changes in drain_all section 3300d94a9b block: Allow graph changes in bdrv_drain_all_begin/end sections 3a37012ee9 block: ignore_bds_parents parameter for drain functions a0cd9923b2 block: Move bdrv_drain_all_begin() out of coroutine context 7df9cb285f block: Allow AIO_WAIT_WHILE with NULL ctx fa7d0ac25e test-bdrv-drain: Test that bdrv_drain_invoke() doesn't poll 3c98182ba5 block: Defer .bdrv_drain_begin callback to polling phase 928f6f85a4 test-bdrv-drain: Graph change through parent callback 75e58be3aa block: Don't poll in parent drain callbacks 84fea14482 test-bdrv-drain: Test node deletion in subtree recursion 6e4d9cda70 block: Drain recursively with a single BDRV_POLL_WHILE() 9531ba32b7 test-bdrv-drain: Add test for node deletion f6fe14abad block: Remove bdrv_drain_recurse() aa7ade75cf block: Really pause block jobs on drain 00d52a27b6 block: Avoid unnecessary aio_poll() in AIO_WAIT_WHILE() c96450896a tests/test-bdrv-drain: bdrv_drain_all() works in coroutines now 955c52ae29 block: Don't manually poll in bdrv_drain_all() 09713c9ac7 block: Remove 'recursive' parameter from bdrv_drain_invoke() e0ccd9c8f2 block: Use bdrv_do_drain_begin/end in bdrv_drain_all() 9e0ea8ed00 test-bdrv-drain: bdrv_drain() works with cross-AioContext events === OUTPUT BEGIN === Checking PATCH 1/20: test-bdrv-drain: bdrv_drain() works with cross-AioContext events... Checking PATCH 2/20: block: Use bdrv_do_drain_begin/end in bdrv_drain_all()... Checking PATCH 3/20: block: Remove 'recursive' parameter from bdrv_drain_invoke()... Checking PATCH 4/20: block: Don't manually poll in bdrv_drain_all()... Checking PATCH 5/20: tests/test-bdrv-drain: bdrv_drain_all() works in coroutines now... Checking PATCH 6/20: block: Avoid unnecessary aio_poll() in AIO_WAIT_WHILE()... ERROR: trailing statements should be on next line #38: FILE: block/io.c:190: + while (aio_poll(bs->aio_context, false)); ERROR: braces {} are necessary for all arms of this statement #38: FILE: block/io.c:190: + while (aio_poll(bs->aio_context, false)); [...] total: 2 errors, 0 warnings, 60 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 7/20: block: Really pause block jobs on drain... Checking PATCH 8/20: block: Remove bdrv_drain_recurse()... Checking PATCH 9/20: test-bdrv-drain: Add test for node deletion... Checking PATCH 10/20: block: Drain recursively with a single BDRV_POLL_WHILE()... Checking PATCH 11/20: test-bdrv-drain: Test node deletion in subtree recursion... WARNING: line over 80 characters #85: FILE: tests/test-bdrv-drain.c:1034: + g_test_add_func("/bdrv-drain/detach/drain_subtree", test_detach_by_drain_subtree); total: 0 errors, 1 warnings, 68 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 12/20: block: Don't poll in parent drain callbacks... Checking PATCH 13/20: test-bdrv-drain: Graph change through parent callback... WARNING: line over 80 characters #81: FILE: tests/test-bdrv-drain.c:1049: + child_a = bdrv_attach_child(parent_b, a, "PB-A", &child_backing, &error_abort); total: 0 errors, 1 warnings, 142 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 14/20: block: Defer .bdrv_drain_begin callback to polling phase... Checking PATCH 15/20: test-bdrv-drain: Test that bdrv_drain_invoke() doesn't poll... Checking PATCH 16/20: block: Allow AIO_WAIT_WHILE with NULL ctx... Checking PATCH 17/20: block: Move bdrv_drain_all_begin() out of coroutine context... WARNING: line over 80 characters #27: FILE: block/io.c:270: + bdrv_do_drained_begin(bs, data->recursive, data->parent, data->poll); total: 0 errors, 1 warnings, 41 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 18/20: block: ignore_bds_parents parameter for drain functions... Checking PATCH 19/20: block: Allow graph changes in bdrv_drain_all_begin/end sections... ERROR: do not initialise globals to 0 or NULL #123: FILE: block/io.c:477: +unsigned int bdrv_drain_all_count = 0; ERROR: trailing statements should be on next line #132: FILE: block/io.c:486: + while (aio_poll(qemu_get_aio_context(), false)); ERROR: braces {} are necessary for all arms of this statement #132: FILE: block/io.c:486: + while (aio_poll(qemu_get_aio_context(), false)); [...] total: 3 errors, 0 warnings, 193 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 20/20: test-bdrv-drain: Test graph changes in drain_all section... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com