Re: [PATCH v2 3/3] hw/usb/dev-uas: Report command additional adb length as unsupported
On 1/21/21 12:14 PM, Gerd Hoffmann wrote: > On Wed, Jan 20, 2021 at 04:35:22PM +0100, Philippe Mathieu-Daudé wrote: >> We are not ready to handle additional CDB data. >> >> If a guest sends a packet with such additional data, >> report the command parameter as not supported. >> >> Specify a size (of 1 byte) for the add_cdb member we >> are not using, to fix the following warning: >> >> usb/dev-uas.c:157:31: error: field 'status' with variable sized type >> 'uas_iu' not at the end of a struct or class is a GNU extension >> [-Werror,-Wgnu-variable-sized-type-not-at-end] >> uas_iustatus; >> ^ >> >> Reported-by: Ed Maste >> Reported-by: Daniele Buono >> Reported-by: Han Han >> Reviewed-by: Eric Blake >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> Cc: Marc-André Lureau >> Cc: Paolo Bonzini >> Cc: Gustavo A. R. Silva >> >> v2: include Eric feedbacks > > Queued 2+3, fixup #2 conflicts due to dropping #1. Thank you!
Re: [PATCH v2 3/3] hw/usb/dev-uas: Report command additional adb length as unsupported
On Wed, Jan 20, 2021 at 04:35:22PM +0100, Philippe Mathieu-Daudé wrote: > We are not ready to handle additional CDB data. > > If a guest sends a packet with such additional data, > report the command parameter as not supported. > > Specify a size (of 1 byte) for the add_cdb member we > are not using, to fix the following warning: > > usb/dev-uas.c:157:31: error: field 'status' with variable sized type > 'uas_iu' not at the end of a struct or class is a GNU extension > [-Werror,-Wgnu-variable-sized-type-not-at-end] > uas_iustatus; > ^ > > Reported-by: Ed Maste > Reported-by: Daniele Buono > Reported-by: Han Han > Reviewed-by: Eric Blake > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Marc-André Lureau > Cc: Paolo Bonzini > Cc: Gustavo A. R. Silva > > v2: include Eric feedbacks Queued 2+3, fixup #2 conflicts due to dropping #1. thanks, Gerd
