Re: [Qemu-block] [PATCH] qemu-io: Use getopt() correctly

2015-05-13 Thread Kevin Wolf
Am 12.05.2015 um 17:10 hat Eric Blake geschrieben:
 POSIX says getopt() returns -1 on completion.  While Linux happens
 to define EOF as -1, this definition is not required by POSIX, and
 there may be platforms where checking for EOF instead of -1 would
 lead to an infinite loop.
 
 Signed-off-by: Eric Blake ebl...@redhat.com

Thanks, applied to my block branch.

Kevin



Re: [Qemu-block] [PATCH] qemu-io: Use getopt() correctly

2015-05-12 Thread Alberto Garcia
On Tue 12 May 2015 05:10:56 PM CEST, Eric Blake ebl...@redhat.com wrote:

 POSIX says getopt() returns -1 on completion.  While Linux happens
 to define EOF as -1, this definition is not required by POSIX, and
 there may be platforms where checking for EOF instead of -1 would
 lead to an infinite loop.

 Signed-off-by: Eric Blake ebl...@redhat.com
Reviewed-by: Alberto Garcia be...@igalia.com

Berto