Re: [Qemu-block] [PATCH 1/3] timer: fix misleading comment in timer.h
On Thu, Dec 01, 2016 at 04:23:17PM +0100, Paolo Bonzini wrote: > > > On 01/12/2016 14:50, Stefan Hajnoczi wrote: > > On Wed, Nov 30, 2016 at 11:30:38PM -0500, Yaowei Bai wrote: > >> It's timer to expire, not clock. > >> > >> Signed-off-by: Yaowei Bai> >> --- > >> include/qemu/timer.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > For the whole series: > > > > Reviewed-by: Stefan Hajnoczi > > > > PS: I suggest sending a cover letter "[PATCH 0/3]" in the future. This > > makes it easy for reviewers to indicate they have reviewed the whole > > series. Without a cover letter it's ambiguous whether my single > > Reviewed-by: applies to just this patch or to the whole series - and > > patch management tools will probably get it wrong too. > > > > I've queued the series for QEMU 2.9. This kind of patch can probably be > sent to qemu-triv...@nongnu.org, which will simplify their inclusion. > > Of course, this is not meant to diminish your contribution! "Trivial" > patches are important and good comments will also help the next person > studying QEMU's source code. Got it from both of you, will correct it in the future, thanks. > > Thanks, > > Paolo
Re: [Qemu-block] [PATCH 1/3] timer: fix misleading comment in timer.h
On 01/12/2016 14:50, Stefan Hajnoczi wrote: > On Wed, Nov 30, 2016 at 11:30:38PM -0500, Yaowei Bai wrote: >> It's timer to expire, not clock. >> >> Signed-off-by: Yaowei Bai>> --- >> include/qemu/timer.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > For the whole series: > > Reviewed-by: Stefan Hajnoczi > > PS: I suggest sending a cover letter "[PATCH 0/3]" in the future. This > makes it easy for reviewers to indicate they have reviewed the whole > series. Without a cover letter it's ambiguous whether my single > Reviewed-by: applies to just this patch or to the whole series - and > patch management tools will probably get it wrong too. > I've queued the series for QEMU 2.9. This kind of patch can probably be sent to qemu-triv...@nongnu.org, which will simplify their inclusion. Of course, this is not meant to diminish your contribution! "Trivial" patches are important and good comments will also help the next person studying QEMU's source code. Thanks, Paolo
Re: [Qemu-block] [PATCH 1/3] timer: fix misleading comment in timer.h
On Wed, Nov 30, 2016 at 11:30:38PM -0500, Yaowei Bai wrote: > It's timer to expire, not clock. > > Signed-off-by: Yaowei Bai> --- > include/qemu/timer.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) For the whole series: Reviewed-by: Stefan Hajnoczi PS: I suggest sending a cover letter "[PATCH 0/3]" in the future. This makes it easy for reviewers to indicate they have reviewed the whole series. Without a cover letter it's ambiguous whether my single Reviewed-by: applies to just this patch or to the whole series - and patch management tools will probably get it wrong too. signature.asc Description: PGP signature