Re: [Qemu-block] [PATCH v5 00/38] blockdev: BlockBackend and media

[Wen Congyang]

On 09/22/2015 11:09 PM, Max Reitz wrote:
> On 22.09.2015 16:45, Kevin Wolf wrote:
>> Am 18.09.2015 um 17:22 hat Max Reitz geschrieben:
>>> This series reworks a lot regarding BlockBackend and media. Basically,
>>> it allows empty BlockBackends, that is BBs without a BDS tree.
>>>
>>> Before this series, empty drives are represented by a BlockBackend with
>>> an empty BDS attached to it (a BDS with a NULL driver). However, now we
>>> have BlockBackends, thus an empty drive should be represented by a
>>> BlockBackend without any BDS tree attached to it. This is what this
>>> series does.
>>
>> Patches 1-16 and 18: Reviewed-by: Kevin Wolf 
>>
>> I had comments for 17 and 19-21, and can't seem to find a base commit
>> that patch 22 applies cleanly to, so I'm stopping the review here,
>> waiting for another rebase or instructions how to apply the series.
> 
> 16a1b6e97c2a2919fd296db4bea2f9da2ad3cc4d was my base, if that was the
> question. ;-)

It can be applied to the upstream qemu very easily:
s/qmp_marshal_input_/qmp_marshal_/

> 
> Thanks for reviewing!
> 
> Max
> 

Re: [Qemu-block] [PATCH v5 00/38] blockdev: BlockBackend and media

[Kevin Wolf]

Am 18.09.2015 um 17:22 hat Max Reitz geschrieben:
> This series reworks a lot regarding BlockBackend and media. Basically,
> it allows empty BlockBackends, that is BBs without a BDS tree.
> 
> Before this series, empty drives are represented by a BlockBackend with
> an empty BDS attached to it (a BDS with a NULL driver). However, now we
> have BlockBackends, thus an empty drive should be represented by a
> BlockBackend without any BDS tree attached to it. This is what this
> series does.

Patches 1-16 and 18: Reviewed-by: Kevin Wolf 

I had comments for 17 and 19-21, and can't seem to find a base commit
that patch 22 applies cleanly to, so I'm stopping the review here,
waiting for another rebase or instructions how to apply the series.

Kevin