Re: [Qemu-block] [Qemu-devel] [PATCH] block/crypto: Simplify block_crypto_{open, create}_opts_init()
Kevin Wolf writes: > Am 14.06.2018 um 16:29 hat Markus Armbruster geschrieben: >> block_crypto_open_opts_init() and block_crypto_create_opts_init() >> contain a virtual visit of QCryptoBlockOptions and >> QCryptoBlockCreateOptions less member "format", respectively. >> >> Change their callers to put member "format" in the QDict, so they can >> use the generated visitors for these types instead. >> >> Signed-off-by: Markus Armbruster > > This doesn't seem to apply cleanly any more. Can you rebase? v2 sent.
Re: [Qemu-block] [Qemu-devel] [PATCH] block/crypto: Simplify block_crypto_{open, create}_opts_init()
On 06/14/2018 09:29 AM, Markus Armbruster wrote: block_crypto_open_opts_init() and block_crypto_create_opts_init() contain a virtual visit of QCryptoBlockOptions and QCryptoBlockCreateOptions less member "format", respectively. Change their callers to put member "format" in the QDict, so they can use the generated visitors for these types instead. Signed-off-by: Markus Armbruster --- block/crypto.c | 95 ++ block/crypto.h | 8 ++--- block/qcow.c | 5 ++- block/qcow2.c | 10 +++--- 4 files changed, 18 insertions(+), 100 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
