Re: [Qemu-devel] [PATCH v2] flatload: fix non-GOT relocations

[Corey Boyle]

Ping

http://patchwork.ozlabs.org/patch/280764/


On Sat, Oct 5, 2013 at 7:46 AM, Corey J. Boyle co...@kansanian.com wrote:

 From: Corey J. Boyle co...@kansanian.com

 Use target address rather than host address when performing
 non-GOT relocations

 Signed-off-by: Corey J. Boyle co...@kansanian.com
 ---
  linux-user/flatload.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/linux-user/flatload.c b/linux-user/flatload.c
 index 58f679e..ceb89bb 100644
 --- a/linux-user/flatload.c
 +++ b/linux-user/flatload.c
 @@ -633,7 +633,7 @@ static int load_flat_file(struct linux_binprm * bprm,
  /* Get the pointer's value.  */
  if (get_user_ual(addr, rp))
  return -EFAULT;
 -addr = flat_get_addr_from_rp(rp, relval, flags, persistent);
 +addr = flat_get_addr_from_rp(addr, relval, flags,
 persistent);
  if (addr != 0) {
  /*
   * Do the relocation.  PIC relocs in the data section are
 --
 1.7.9.5

Re: [Qemu-devel] [PATCH] flatload: fix non-GOT relocations

[Corey Boyle]

On Sat, Oct 5, 2013 at 4:04 AM, Peter Maydell peter.mayd...@linaro.orgwrote:

 On 5 October 2013 07:50, Corey J. Boyle co...@kansanian.com wrote:
  From: Corey J. Boyle co...@kansanian.com
 
  Use target address rather than host address when performing
  non-GOT relocations
 
  Signed-off-by: Corey J. Boyle co...@kansanian.com
  ---
   linux-user/flatload.c |4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
 
  diff --git a/linux-user/flatload.c b/linux-user/flatload.c
  index 58f679e..c13a201 100644
  --- a/linux-user/flatload.c
  +++ b/linux-user/flatload.c
  @@ -44,7 +44,7 @@
   #define ntohl(x) be32_to_cpu(x)
   #include target_flat.h
 
  -//#define DEBUG
  +#define DEBUG

 I assume you didn't mean to leave debugging enabled...

 No, I didn't mean for that to stick around.  I'll upload a new patch.

Thanks
Corey