Re: [Qemu-devel] [PATCH 0/1 resend] Add vhost-pci-blk driver

[Vitaly Mayatskih]

On Mon, Nov 5, 2018 at 12:45 PM Michael S. Tsirkin  wrote:

> I think you should Cc more widely to get meaningful
> review. At least virtio-blk and block layer core people.

Thanks, it turns out I missed the existence of qemu/scripts directory
completely.

-- 
wbr, Vitaly

Re: [Qemu-devel] [PATCH 1/1] Add vhost-pci-blk driver

[Vitaly Mayatskih]

> >  configure  | 10 +++
> >  default-configs/virtio.mak |  1 +
> >  hw/block/Makefile.objs |  1 +
> >  hw/virtio/virtio-pci.c | 60 ++
> >  hw/virtio/virtio-pci.h | 19 
> >  5 files changed, 91 insertions(+)
> >
>
> I think that you haven't sent all the files because at least some of the files
> are missing.
> For example the build fails with missing 'hw/virtio/vhost-blk.h'
>
> Also I don't see here any mention on how the qemu passes to the in-kernel
> driver, the file which the in-kernel driver is supposed to read/write.
> I don't think that generic vhost backend have this functionality because till
> now it was limited to iscsi, and thus qemu just passed to the kernel, the wwpn
> of the device.

Yes, I screwed it up and forgot two files. Will resend shortly.

Thanks!

-- 
wbr, Vitaly