Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board
On Mon, 25 Nov 2019, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 11/14/19 2:50 PM, Philippe Mathieu-Daudé wrote: --- But let's wait to see what Huacai Chen thinks of it, before posting it. Aleksandar, can you stay as co-maintainer? The patch would be: -- 8< -- Fulong 2E +M: Philippe Mathieu-Daudé M: Aleksandar Markovic -R: Aleksandar Rikalo You are a prolific contributor of the Fuloong, are you OK to be listed as reviewer in this section? Aleksandar M. has already asked me but no thanks. I've only contributed to Fulong 2E because it happens to use the same or similar components that I'm interested in for PPC machines emulation (VIA superio for Pegasos2 and ati-vga) and it was a good way to cross check these with something else but otherwise I don't use the MIPS boards. Regards, BALATON Zoltan
Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board
Hi Zoltan, On 11/14/19 2:50 PM, Philippe Mathieu-Daudé wrote: On 11/14/19 2:08 PM, chen huacai wrote: Hi, all, On Thu, Nov 14, 2019 at 8:34 PM Aleksandar Markovic wrote: Hi, Philippe, From: Philippe Mathieu-Daudé Hi Aleksandar, On 11/13/19 2:47 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic Change the maintainership for Fulong 2E board to improve its quality. IIRC you told me once this board is named Fuloong, and its CPU is a > Loongson, both with 2x 'o' :) I have a patch renaming the various occurrences. I still think that the oficial name is "Fuloong 2E", however, it is shortened to "Fulong 2E" quite often in communication, and, it seems, sometimes even in various docs/app notes etc. Can perhaps Huacai Chen enlighten us regarding the right spelling? The right spelling is Fuloong. [...]>>> The original author is active on the Linux kernel, let ask him if he'd be OK to keep an eye on his work. Huacai, would you agree to be listed as a reviewer on the Fuloong related QEMU files? You don't have to worry about the generic QEMU code plate (like keeping API up to date) I'll manage that, but I'd like to have you listed to assert the hardware is properly modeled. You would appear as: R: Huacai Chen That is a great idea! Please, Chen, get involved, you would be very welcomed, there is a place for you in QEMU community! I'm sorry that I'm busy now, but I think I will do something in QEMU in the next year. No problem, we'll keep in touch. +R: Hervé Poussineau I don't think Hervé is interested by this board, he has not modified the code. +R: Aleksandar Markovic +S: Maintained Let keep it as "Odd Fixes" :) OK. Odd Fixes: It has a maintainer but they don't have time to do much other than throw the odd patch in. F: hw/mips/mips_fulong2e.c F: hw/isa/vt82c686.c F: hw/pci-host/bonito.c So the patch would be: -- 8< -- Fulong 2E -M: Aleksandar Markovic -R: Aleksandar Rikalo +M: Philippe Mathieu-Daudé +R: Aleksandar Markovic +R: Huacai Chen S: Odd Fixes F: hw/mips/mips_fulong2e.c F: hw/isa/vt82c686.c Plus possible s/Fulong 2E/Fuloong 2E/ I'd prefer to keep this change for later, with the patch cleaning its use in the codebase (not that trivial because we need to alias the machine name to keep backward compatibility). --- But let's wait to see what Huacai Chen thinks of it, before posting it. Aleksandar, can you stay as co-maintainer? The patch would be: -- 8< -- Fulong 2E +M: Philippe Mathieu-Daudé M: Aleksandar Markovic -R: Aleksandar Rikalo You are a prolific contributor of the Fuloong, are you OK to be listed as reviewer in this section? S: Odd Fixes F: hw/mips/mips_fulong2e.c F: hw/isa/vt82c686.c --- Either this way, or if you prefer to be listed with a R-tag: Acked-by: Philippe Mathieu-Daudé
Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board
Hi, all, On Thu, Nov 14, 2019 at 8:34 PM Aleksandar Markovic wrote: > > Hi, Philippe, > > > From: Philippe Mathieu-Daudé > > > > Hi Aleksandar, > > > > On 11/13/19 2:47 PM, Aleksandar Markovic wrote: > > > From: Aleksandar Markovic > > > > > > Change the maintainership for Fulong 2E board to improve its quality. > > > > IIRC you told me once this board is named Fuloong, and its CPU is a > > Loongson, both with 2x 'o' :) I have a patch renaming the various > > occurrences. > > > > I still think that the oficial name is "Fuloong 2E", however, it is > shortened to "Fulong 2E" quite often in communication, and, it seems, > sometimes even in various docs/app notes etc. > > Can perhaps Huacai Chen enlighten us regarding the right spelling? The right spelling is Fuloong. > > > > Signed-off-by: Aleksandar Markovic > > > --- > > > MAINTAINERS | 7 --- > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index fd9ba32..3bf2144 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -976,9 +976,10 @@ S: Maintained > > > F: hw/mips/mips_r4k.c > > > > > > Fulong 2E > > > -M: Aleksandar Markovic > > > -R: Aleksandar Rikalo > > > -S: Odd Fixes > > > +M: Philippe Mathieu-Daudé > > > > I am happy to keep the Fuloong working, but this will be on my personal > > (hobbyist) time. This area is not a priority for my employer, so I'll > > use my personal email: f4...@amsat.org. > > > > OK. > > > The original author is active on the Linux kernel, let ask him if he'd > > be OK to keep an eye on his work. > > > > Huacai, would you agree to be listed as a reviewer on the Fuloong > > related QEMU files? You don't have to worry about the generic QEMU code > > plate (like keeping API up to date) I'll manage that, but I'd like to > > have you listed to assert the hardware is properly modeled. > > > > You would appear as: > > R: Huacai Chen > > > > That is a great idea! > > Please, Chen, get involved, you would be very welcomed, there is a place > for you in QEMU community! I'm sorry that I'm busy now, but I think I will do something in QEMU in the next year. > > > > > +R: Hervé Poussineau > > > > I don't think Hervé is interested by this board, he has not modified the > > code. > > > > > +R: Aleksandar Markovic > > > +S: Maintained > > > > Let keep it as "Odd Fixes" :) > > > > OK. > > >Odd Fixes: It has a maintainer but they don't have > > time to do much other than throw the odd > > patch in. > > > > > F: hw/mips/mips_fulong2e.c > > > F: hw/isa/vt82c686.c > > > F: hw/pci-host/bonito.c > > > > > > > So the patch would be: > > > > -- 8< -- > > Fulong 2E > > -M: Aleksandar Markovic > > -R: Aleksandar Rikalo > > +M: Philippe Mathieu-Daudé > > +R: Aleksandar Markovic > > +R: Huacai Chen > > S: Odd Fixes > > F: hw/mips/mips_fulong2e.c > > F: hw/isa/vt82c686.c > > Plus possible s/Fulong 2E/Fuloong 2E/ > > > --- > > > > But let's wait to see what Huacai Chen thinks of it, before posting it. > > > > Thanks for taking care of those changes! > > > > Phil. > > > > > > Thank you! > > Aleksandar Thanks, Huacai
Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board
On 11/14/19 2:08 PM, chen huacai wrote: Hi, all, On Thu, Nov 14, 2019 at 8:34 PM Aleksandar Markovic wrote: Hi, Philippe, From: Philippe Mathieu-Daudé Hi Aleksandar, On 11/13/19 2:47 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic Change the maintainership for Fulong 2E board to improve its quality. IIRC you told me once this board is named Fuloong, and its CPU is a > Loongson, both with 2x 'o' :) I have a patch renaming the various occurrences. I still think that the oficial name is "Fuloong 2E", however, it is shortened to "Fulong 2E" quite often in communication, and, it seems, sometimes even in various docs/app notes etc. Can perhaps Huacai Chen enlighten us regarding the right spelling? The right spelling is Fuloong. [...]>>> The original author is active on the Linux kernel, let ask him if he'd be OK to keep an eye on his work. Huacai, would you agree to be listed as a reviewer on the Fuloong related QEMU files? You don't have to worry about the generic QEMU code plate (like keeping API up to date) I'll manage that, but I'd like to have you listed to assert the hardware is properly modeled. You would appear as: R: Huacai Chen That is a great idea! Please, Chen, get involved, you would be very welcomed, there is a place for you in QEMU community! I'm sorry that I'm busy now, but I think I will do something in QEMU in the next year. No problem, we'll keep in touch. +R: Hervé Poussineau I don't think Hervé is interested by this board, he has not modified the code. +R: Aleksandar Markovic +S: Maintained Let keep it as "Odd Fixes" :) OK. Odd Fixes: It has a maintainer but they don't have time to do much other than throw the odd patch in. F: hw/mips/mips_fulong2e.c F: hw/isa/vt82c686.c F: hw/pci-host/bonito.c So the patch would be: -- 8< -- Fulong 2E -M: Aleksandar Markovic -R: Aleksandar Rikalo +M: Philippe Mathieu-Daudé +R: Aleksandar Markovic +R: Huacai Chen S: Odd Fixes F: hw/mips/mips_fulong2e.c F: hw/isa/vt82c686.c Plus possible s/Fulong 2E/Fuloong 2E/ I'd prefer to keep this change for later, with the patch cleaning its use in the codebase (not that trivial because we need to alias the machine name to keep backward compatibility). --- But let's wait to see what Huacai Chen thinks of it, before posting it. Aleksandar, can you stay as co-maintainer? The patch would be: -- 8< -- Fulong 2E +M: Philippe Mathieu-Daudé M: Aleksandar Markovic -R: Aleksandar Rikalo S: Odd Fixes F: hw/mips/mips_fulong2e.c F: hw/isa/vt82c686.c --- Either this way, or if you prefer to be listed with a R-tag: Acked-by: Philippe Mathieu-Daudé
Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board
Hi, Philippe, > From: Philippe Mathieu-Daudé > > Hi Aleksandar, > > On 11/13/19 2:47 PM, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > > > Change the maintainership for Fulong 2E board to improve its quality. > > IIRC you told me once this board is named Fuloong, and its CPU is a > Loongson, both with 2x 'o' :) I have a patch renaming the various > occurrences. > I still think that the oficial name is "Fuloong 2E", however, it is shortened to "Fulong 2E" quite often in communication, and, it seems, sometimes even in various docs/app notes etc. Can perhaps Huacai Chen enlighten us regarding the right spelling? > > Signed-off-by: Aleksandar Markovic > > --- > > MAINTAINERS | 7 --- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index fd9ba32..3bf2144 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -976,9 +976,10 @@ S: Maintained > > F: hw/mips/mips_r4k.c > > > > Fulong 2E > > -M: Aleksandar Markovic > > -R: Aleksandar Rikalo > > -S: Odd Fixes > > +M: Philippe Mathieu-Daudé > > I am happy to keep the Fuloong working, but this will be on my personal > (hobbyist) time. This area is not a priority for my employer, so I'll > use my personal email: f4...@amsat.org. > OK. > The original author is active on the Linux kernel, let ask him if he'd > be OK to keep an eye on his work. > > Huacai, would you agree to be listed as a reviewer on the Fuloong > related QEMU files? You don't have to worry about the generic QEMU code > plate (like keeping API up to date) I'll manage that, but I'd like to > have you listed to assert the hardware is properly modeled. > > You would appear as: > R: Huacai Chen > That is a great idea! Please, Chen, get involved, you would be very welcomed, there is a place for you in QEMU community! > > +R: Hervé Poussineau > > I don't think Hervé is interested by this board, he has not modified the > code. > > > +R: Aleksandar Markovic > > +S: Maintained > > Let keep it as "Odd Fixes" :) > OK. >Odd Fixes: It has a maintainer but they don't have > time to do much other than throw the odd > patch in. > > > F: hw/mips/mips_fulong2e.c > > F: hw/isa/vt82c686.c > > F: hw/pci-host/bonito.c > > > > So the patch would be: > > -- 8< -- > Fulong 2E > -M: Aleksandar Markovic > -R: Aleksandar Rikalo > +M: Philippe Mathieu-Daudé > +R: Aleksandar Markovic > +R: Huacai Chen > S: Odd Fixes > F: hw/mips/mips_fulong2e.c > F: hw/isa/vt82c686.c Plus possible s/Fulong 2E/Fuloong 2E/ > --- > > But let's wait to see what Huacai Chen thinks of it, before posting it. > > Thanks for taking care of those changes! > > Phil. > > Thank you! Aleksandar
