Re: [PATCH] Reduce scope of def_regnum, remove dead assignment

[Matheus Tavares Bernardino]

On Sun, 14 Jan 2024 15:44:53 -0800 Brian Cain  wrote:
>
> This is intended to address a coverity finding: CID 1527408.
> 
> Signed-off-by: Brian Cain 
> ---

Reviewed-by: Matheus Tavares Bernardino 

[PATCH] Reduce scope of def_regnum, remove dead assignment

[Brian Cain]

This is intended to address a coverity finding: CID 1527408.

Signed-off-by: Brian Cain 
---
 target/hexagon/mmvec/decode_ext_mmvec.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/target/hexagon/mmvec/decode_ext_mmvec.c 
b/target/hexagon/mmvec/decode_ext_mmvec.c
index 174eb3b78b..202d84c7c0 100644
--- a/target/hexagon/mmvec/decode_ext_mmvec.c
+++ b/target/hexagon/mmvec/decode_ext_mmvec.c
@@ -33,7 +33,6 @@ check_new_value(Packet *pkt)
 const char *dststr = NULL;
 uint16_t def_opcode;
 char letter;
-int def_regnum;
 
 for (i = 1; i < pkt->num_insns; i++) {
 uint16_t use_opcode = pkt->insn[i].opcode;
@@ -78,7 +77,6 @@ check_new_value(Packet *pkt)
 }
 }
 if ((dststr == NULL)  && GET_ATTRIB(def_opcode, A_CVI_GATHER)) {
-def_regnum = 0;
 pkt->insn[i].regno[use_regidx] = def_oreg;
 pkt->insn[i].new_value_producer_slot = pkt->insn[def_idx].slot;
 } else {
@@ -86,7 +84,7 @@ check_new_value(Packet *pkt)
 /* still not there, we have a bad packet */
 g_assert_not_reached();
 }
-def_regnum = pkt->insn[def_idx].regno[dststr - reginfo];
+int def_regnum = pkt->insn[def_idx].regno[dststr - reginfo];
 /* Now patch up the consumer with the register number */
 pkt->insn[i].regno[use_regidx] = def_regnum ^ def_oreg;
 /* special case for (Vx,Vy) */
-- 
2.25.1