Re: [PATCH] bugfix: hostmem: Free host_nodes list right after visited
On Wed, 9 Dec 2020 10:56:48 +0800 Keqian Zhu wrote: > In host_memory_backend_get_host_nodes, we build host_nodes > list and output it to v (a StringOutputVisitor) but forget > to free the list. This fixes the memory leak. > > The memory leak stack: > > ==qemu-kvm==209357==ERROR: LeakSanitizer: detected memory leaks > Direct leak of 32 byte(s) in 2 object(s) allocated from: > #0 0xfffe430e3393 in __interceptor_calloc (/lib64/libasan.so.4+0xd3393) > ??:? > #1 0xfffe41d58b9b in g_malloc0 (/lib64/libglib-2.0.so.0+0x58b9b) ??:? > #2 0xaaac0cdb6e43 (/usr/libexec/qemu-kvm+0xe16e43) backends/hostmem.c:94 > #3 0xaaac0d2edf83 (/usr/libexec/qemu-kvm+0x134df83) qom/object.c:1478 > #4 0xaaac0c976513 (/usr/libexec/qemu-kvm+0x9d6513) > hw/core/machine-qmp-cmds.c:312 > #5 0xaaac0d2e980b (/usr/libexec/qemu-kvm+0x134980b) qom/object.c:1001 > #6 0xaaac0c97779b (/usr/libexec/qemu-kvm+0x9d779b) > hw/core/machine-qmp-cmds.c:328 (discriminator 1) > #7 0xaaac0d26ed3f (/usr/libexec/qemu-kvm+0x12ced3f) > qapi/qapi-commands-machine.c:327 > #8 0xaaac0d43d647 (/usr/libexec/qemu-kvm+0x149d647) qapi/qmp-dispatch.c:147 > #9 0xaaac0d21f74b (/usr/libexec/qemu-kvm+0x127f74b) monitor/qmp.c:120 > #10 0xaaac0d22074b (/usr/libexec/qemu-kvm+0x128074b) monitor/qmp.c:209 > (discriminator 4) > #11 0xaaac0d4daefb (/usr/libexec/qemu-kvm+0x153aefb) util/async.c:117 > #12 0xaaac0d4e30fb (/usr/libexec/qemu-kvm+0x15430fb) util/aio-posix.c:459 > #13 0xaaac0d4dac8f (/usr/libexec/qemu-kvm+0x153ac8f) util/async.c:268 > #14 0xfffe41d52a6b in g_main_context_dispatch > (/lib64/libglib-2.0.so.0+0x52a6b) ??:? > #15 0xaaac0d4e0e97 (/usr/libexec/qemu-kvm+0x1540e97) util/main-loop.c:218 > #16 0xaaac0cd9bfa7 (/usr/libexec/qemu-kvm+0xdfbfa7) vl.c:1791 > #17 0xaaac0c823bc3 (/usr/libexec/qemu-kvm+0x883bc3) vl.c:4473 > #18 0xfffe40ab3ebf in __libc_start_main (/lib64/libc.so.6+0x23ebf) ??:? > #19 0xaaac0c82ed5f (/usr/libexec/qemu-kvm+0x88ed5f) ??:? > SUMMARY: AddressSanitizer: 32 byte(s) leaked in 2 allocation(s). > > Fixes: 4cf1b76bf1e2 (hostmem: add properties for NUMA memory policy) > Reported-by: Euler Robot > Signed-off-by: Keqian Zhu Reviewed-by: Igor Mammedov > --- > backends/hostmem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/backends/hostmem.c b/backends/hostmem.c > index 4bde00e8e7..9f9ac95edd 100644 > --- a/backends/hostmem.c > +++ b/backends/hostmem.c > @@ -105,6 +105,7 @@ host_memory_backend_get_host_nodes(Object *obj, Visitor > *v, const char *name, > > ret: > visit_type_uint16List(v, name, _nodes, errp); > +qapi_free_uint16List(host_nodes); > } > > static void
RE: [PATCH] bugfix: hostmem: Free host_nodes list right after visited
> -Original Message- > From: zhukeqian > Sent: Wednesday, December 9, 2020 10:57 AM > To: Peter Maydell ; Igor Mammedov > ; Eduardo Habkost > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; Wanghaibin (D) > ; Chenqun (kuhn) > ; Chenzhendong (alex) > ; zhukeqian > Subject: [PATCH] bugfix: hostmem: Free host_nodes list right after visited > > In host_memory_backend_get_host_nodes, we build host_nodes list and > output it to v (a StringOutputVisitor) but forget to free the list. This > fixes the > memory leak. > > The memory leak stack: > > ==qemu-kvm==209357==ERROR: LeakSanitizer: detected memory leaks Direct > leak of 32 byte(s) in 2 object(s) allocated from: > #0 0xfffe430e3393 in __interceptor_calloc > (/lib64/libasan.so.4+0xd3393) ??:? > #1 0xfffe41d58b9b in g_malloc0 (/lib64/libglib-2.0.so.0+0x58b9b) ??:? > #2 0xaaac0cdb6e43 (/usr/libexec/qemu-kvm+0xe16e43) > backends/hostmem.c:94 > #3 0xaaac0d2edf83 (/usr/libexec/qemu-kvm+0x134df83) qom/object.c:1478 > #4 0xaaac0c976513 (/usr/libexec/qemu-kvm+0x9d6513) > hw/core/machine-qmp-cmds.c:312 > #5 0xaaac0d2e980b (/usr/libexec/qemu-kvm+0x134980b) qom/object.c:1001 > #6 0xaaac0c97779b (/usr/libexec/qemu-kvm+0x9d779b) > hw/core/machine-qmp-cmds.c:328 (discriminator 1) > #7 0xaaac0d26ed3f (/usr/libexec/qemu-kvm+0x12ced3f) > qapi/qapi-commands-machine.c:327 > #8 0xaaac0d43d647 (/usr/libexec/qemu-kvm+0x149d647) > qapi/qmp-dispatch.c:147 > #9 0xaaac0d21f74b (/usr/libexec/qemu-kvm+0x127f74b) monitor/qmp.c:120 > #10 0xaaac0d22074b (/usr/libexec/qemu-kvm+0x128074b) > monitor/qmp.c:209 (discriminator 4) > #11 0xaaac0d4daefb (/usr/libexec/qemu-kvm+0x153aefb) util/async.c:117 > #12 0xaaac0d4e30fb (/usr/libexec/qemu-kvm+0x15430fb) > util/aio-posix.c:459 > #13 0xaaac0d4dac8f (/usr/libexec/qemu-kvm+0x153ac8f) util/async.c:268 > #14 0xfffe41d52a6b in g_main_context_dispatch > (/lib64/libglib-2.0.so.0+0x52a6b) ??:? > #15 0xaaac0d4e0e97 (/usr/libexec/qemu-kvm+0x1540e97) > util/main-loop.c:218 > #16 0xaaac0cd9bfa7 (/usr/libexec/qemu-kvm+0xdfbfa7) vl.c:1791 > #17 0xaaac0c823bc3 (/usr/libexec/qemu-kvm+0x883bc3) vl.c:4473 > #18 0xfffe40ab3ebf in __libc_start_main (/lib64/libc.so.6+0x23ebf) ??:? > #19 0xaaac0c82ed5f (/usr/libexec/qemu-kvm+0x88ed5f) ??:? > SUMMARY: AddressSanitizer: 32 byte(s) leaked in 2 allocation(s). > > Fixes: 4cf1b76bf1e2 (hostmem: add properties for NUMA memory policy) > Reported-by: Euler Robot > Signed-off-by: Keqian Zhu > --- Tested-by: Chen Qun By the way, the bug detailed stack is as follows: Direct leak of 32 byte(s) in 2 object(s) allocated from: #0 0xfffda30b3393 in __interceptor_calloc (/usr/lib64/libasan.so.4+0xd3393) #1 0xfffda1d28b9b in g_malloc0 (/usr/lib64/libglib-2.0.so.0+0x58b9b) #2 0xaaab05ca6e43 in host_memory_backend_get_host_nodes backends/hostmem.c:94 #3 0xaaab061ddf83 in object_property_get_uint16List qom/object.c:1478 #4 0xaaab05866513 in query_memdev hw/core/machine-qmp-cmds.c:312 #5 0xaaab061d980b in do_object_child_foreach qom/object.c:1001 #6 0xaaab0586779b in qmp_query_memdev hw/core/machine-qmp-cmds.c:328 #7 0xaaab0615ed3f in qmp_marshal_query_memdev qapi/qapi-commands-machine.c:327 #8 0xaaab0632d647 in do_qmp_dispatch qapi/qmp-dispatch.c:147 #9 0xaaab0632d647 in qmp_dispatch qapi/qmp-dispatch.c:190 #10 0xaaab0610f74b in monitor_qmp_dispatch monitor/qmp.c:120 #11 0xaaab0611074b in monitor_qmp_bh_dispatcher monitor/qmp.c:209 #12 0xaaab063caefb in aio_bh_poll util/async.c:117 #13 0xaaab063d30fb in aio_dispatch util/aio-posix.c:459 #14 0xaaab063cac8f in aio_ctx_dispatch util/async.c:268 #15 0xfffda1d22a6b in g_main_context_dispatch (/usr/lib64/libglib-2.0.so.0+0x52a6b) #16 0xaaab063d0e97 in glib_pollfds_poll util/main-loop.c:218 #17 0xaaab063d0e97 in os_host_main_loop_wait util/main-loop.c:241 #18 0xaaab063d0e97 in main_loop_wait util/main-loop.c:517 #19 0xaaab05c8bfa7 in main_loop /root/rpmbuild/BUILD/qemu-4.1.0/vl.c:1791 #20 0xaaab05713bc3 in main /root/rpmbuild/BUILD/qemu-4.1.0/vl.c:4473 #21 0xfffda0a83ebf in __libc_start_main (/usr/lib64/libc.so.6+0x23ebf) #22 0xaaab0571ed5f (aarch64-softmmu/qemu-system-aarch64+0x88ed5f) SUMMARY: AddressSanitizer: 32 byte(s) leaked in 2 allocation(s). > backends/hostmem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/backends/hostmem.c b/backends/hostmem.c index > 4bde00e8e7..9f9ac95edd 100644 > --- a/backends/hostmem.c > +++ b/backends/hostmem.c > @@ -105,6 +105,7 @@ host_memory_backend_get_host_nodes(Object *obj, > Visitor *v, const char *name, > > ret: > visit_type_uint16List(v, name, _nodes, errp); > +qapi_free_uint16List(host_nodes); > } > > static void > -- > 2.23.0
[PATCH] bugfix: hostmem: Free host_nodes list right after visited
In host_memory_backend_get_host_nodes, we build host_nodes list and output it to v (a StringOutputVisitor) but forget to free the list. This fixes the memory leak. The memory leak stack: ==qemu-kvm==209357==ERROR: LeakSanitizer: detected memory leaks Direct leak of 32 byte(s) in 2 object(s) allocated from: #0 0xfffe430e3393 in __interceptor_calloc (/lib64/libasan.so.4+0xd3393) ??:? #1 0xfffe41d58b9b in g_malloc0 (/lib64/libglib-2.0.so.0+0x58b9b) ??:? #2 0xaaac0cdb6e43 (/usr/libexec/qemu-kvm+0xe16e43) backends/hostmem.c:94 #3 0xaaac0d2edf83 (/usr/libexec/qemu-kvm+0x134df83) qom/object.c:1478 #4 0xaaac0c976513 (/usr/libexec/qemu-kvm+0x9d6513) hw/core/machine-qmp-cmds.c:312 #5 0xaaac0d2e980b (/usr/libexec/qemu-kvm+0x134980b) qom/object.c:1001 #6 0xaaac0c97779b (/usr/libexec/qemu-kvm+0x9d779b) hw/core/machine-qmp-cmds.c:328 (discriminator 1) #7 0xaaac0d26ed3f (/usr/libexec/qemu-kvm+0x12ced3f) qapi/qapi-commands-machine.c:327 #8 0xaaac0d43d647 (/usr/libexec/qemu-kvm+0x149d647) qapi/qmp-dispatch.c:147 #9 0xaaac0d21f74b (/usr/libexec/qemu-kvm+0x127f74b) monitor/qmp.c:120 #10 0xaaac0d22074b (/usr/libexec/qemu-kvm+0x128074b) monitor/qmp.c:209 (discriminator 4) #11 0xaaac0d4daefb (/usr/libexec/qemu-kvm+0x153aefb) util/async.c:117 #12 0xaaac0d4e30fb (/usr/libexec/qemu-kvm+0x15430fb) util/aio-posix.c:459 #13 0xaaac0d4dac8f (/usr/libexec/qemu-kvm+0x153ac8f) util/async.c:268 #14 0xfffe41d52a6b in g_main_context_dispatch (/lib64/libglib-2.0.so.0+0x52a6b) ??:? #15 0xaaac0d4e0e97 (/usr/libexec/qemu-kvm+0x1540e97) util/main-loop.c:218 #16 0xaaac0cd9bfa7 (/usr/libexec/qemu-kvm+0xdfbfa7) vl.c:1791 #17 0xaaac0c823bc3 (/usr/libexec/qemu-kvm+0x883bc3) vl.c:4473 #18 0xfffe40ab3ebf in __libc_start_main (/lib64/libc.so.6+0x23ebf) ??:? #19 0xaaac0c82ed5f (/usr/libexec/qemu-kvm+0x88ed5f) ??:? SUMMARY: AddressSanitizer: 32 byte(s) leaked in 2 allocation(s). Fixes: 4cf1b76bf1e2 (hostmem: add properties for NUMA memory policy) Reported-by: Euler Robot Signed-off-by: Keqian Zhu --- backends/hostmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/backends/hostmem.c b/backends/hostmem.c index 4bde00e8e7..9f9ac95edd 100644 --- a/backends/hostmem.c +++ b/backends/hostmem.c @@ -105,6 +105,7 @@ host_memory_backend_get_host_nodes(Object *obj, Visitor *v, const char *name, ret: visit_type_uint16List(v, name, _nodes, errp); +qapi_free_uint16List(host_nodes); } static void -- 2.23.0
