Re: [PATCH] ccid-card-emulated: fix cast warning

[Marc-André Lureau]

On Mon, Nov 14, 2022 at 5:22 PM  wrote:

> From: Marc-André Lureau 
>
> ../hw/usb/ccid-card-emulated.c: In function 'handle_apdu_thread':
> ../hw/usb/ccid-card-emulated.c:251:24: error: cast from pointer to integer
> of different size [-Werror=pointer-to-int-cast]
>   251 | assert((unsigned long)event > 1000);
>
> Signed-off-by: Marc-André Lureau 
>

ping


> ---
>  hw/usb/ccid-card-emulated.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c
> index ee41a81801..c328660075 100644
> --- a/hw/usb/ccid-card-emulated.c
> +++ b/hw/usb/ccid-card-emulated.c
> @@ -248,7 +248,7 @@ static void *handle_apdu_thread(void* arg)
>  WITH_QEMU_LOCK_GUARD(>vreader_mutex) {
>  while (!QSIMPLEQ_EMPTY(>guest_apdu_list)) {
>  event = QSIMPLEQ_FIRST(>guest_apdu_list);
> -assert((unsigned long)event > 1000);
> +assert(event != NULL);
>  QSIMPLEQ_REMOVE_HEAD(>guest_apdu_list, entry);
>  if (event->p.data.type != EMUL_GUEST_APDU) {
>  DPRINTF(card, 1, "unexpected message in
> handle_apdu_thread\n");
> --
> 2.38.1
>
>

[PATCH] ccid-card-emulated: fix cast warning

[marcandre . lureau]

From: Marc-André Lureau 

../hw/usb/ccid-card-emulated.c: In function 'handle_apdu_thread':
../hw/usb/ccid-card-emulated.c:251:24: error: cast from pointer to integer of 
different size [-Werror=pointer-to-int-cast]
  251 | assert((unsigned long)event > 1000);

Signed-off-by: Marc-André Lureau 
---
 hw/usb/ccid-card-emulated.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c
index ee41a81801..c328660075 100644
--- a/hw/usb/ccid-card-emulated.c
+++ b/hw/usb/ccid-card-emulated.c
@@ -248,7 +248,7 @@ static void *handle_apdu_thread(void* arg)
 WITH_QEMU_LOCK_GUARD(>vreader_mutex) {
 while (!QSIMPLEQ_EMPTY(>guest_apdu_list)) {
 event = QSIMPLEQ_FIRST(>guest_apdu_list);
-assert((unsigned long)event > 1000);
+assert(event != NULL);
 QSIMPLEQ_REMOVE_HEAD(>guest_apdu_list, entry);
 if (event->p.data.type != EMUL_GUEST_APDU) {
 DPRINTF(card, 1, "unexpected message in 
handle_apdu_thread\n");
-- 
2.38.1