Re: [PATCH] docs/devel: fix missing antislash

2021-08-10 Thread Alexandre IOOSS 

On 8/9/21 8:14 PM, Eduardo Habkost wrote:

On Mon, Aug 09, 2021 at 07:31:41PM +0200, Alexandre Iooss wrote:

Signed-off-by: Alexandre Iooss 
---
  docs/devel/qom.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst
index e5fe3597cd..b9568c0fb8 100644
--- a/docs/devel/qom.rst
+++ b/docs/devel/qom.rst
@@ -309,7 +309,7 @@ This is equivalent to the following:
 OBJECT_GET_CLASS(MyDeviceClass, obj, TYPE_MY_DEVICE)
 #define MY_DEVICE_CLASS(void *klass) \
 OBJECT_CLASS_CHECK(MyDeviceClass, klass, TYPE_MY_DEVICE)
-   #define MY_DEVICE(void *obj)
+   #define MY_DEVICE(void *obj) \
 OBJECT_CHECK(MyDevice, obj, TYPE_MY_DEVICE)


Oops, nice catch!

However, the code above is already going to be deleted by:
https://lore.kernel.org/qemu-devel/20210729175554.686474-9-ehabk...@redhat.com



Oh I was not aware of that new patch, it looks great while also solving 
the anti-slash problem!


Thanks,
-- Alexandre



OpenPGP_signature
Description: OpenPGP digital signature

Re: [PATCH] docs/devel: fix missing antislash

2021-08-09 Thread Eduardo Habkost 
On Mon, Aug 09, 2021 at 07:31:41PM +0200, Alexandre Iooss wrote:
> Signed-off-by: Alexandre Iooss 
> ---
>  docs/devel/qom.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst
> index e5fe3597cd..b9568c0fb8 100644
> --- a/docs/devel/qom.rst
> +++ b/docs/devel/qom.rst
> @@ -309,7 +309,7 @@ This is equivalent to the following:
> OBJECT_GET_CLASS(MyDeviceClass, obj, TYPE_MY_DEVICE)
> #define MY_DEVICE_CLASS(void *klass) \
> OBJECT_CLASS_CHECK(MyDeviceClass, klass, TYPE_MY_DEVICE)
> -   #define MY_DEVICE(void *obj)
> +   #define MY_DEVICE(void *obj) \
> OBJECT_CHECK(MyDevice, obj, TYPE_MY_DEVICE)

Oops, nice catch!

However, the code above is already going to be deleted by:
https://lore.kernel.org/qemu-devel/20210729175554.686474-9-ehabk...@redhat.com

-- 
Eduardo

[PATCH] docs/devel: fix missing antislash

2021-08-09 Thread Alexandre Iooss 
Signed-off-by: Alexandre Iooss 
---
 docs/devel/qom.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst
index e5fe3597cd..b9568c0fb8 100644
--- a/docs/devel/qom.rst
+++ b/docs/devel/qom.rst
@@ -309,7 +309,7 @@ This is equivalent to the following:
OBJECT_GET_CLASS(MyDeviceClass, obj, TYPE_MY_DEVICE)
#define MY_DEVICE_CLASS(void *klass) \
OBJECT_CLASS_CHECK(MyDeviceClass, klass, TYPE_MY_DEVICE)
-   #define MY_DEVICE(void *obj)
+   #define MY_DEVICE(void *obj) \
OBJECT_CHECK(MyDevice, obj, TYPE_MY_DEVICE)
 
struct MyDeviceClass {
-- 
2.31.1