Re: [PATCH] hw/block/nvme: fix error handling in nvme_ns_realize

2021-02-11 Thread Minwoo Im
Reviewed-by: Minwoo Im 



[PATCH] hw/block/nvme: fix error handling in nvme_ns_realize

2021-02-11 Thread Klaus Jensen
From: Klaus Jensen 

nvme_ns_realize passes errp to nvme_register_namespaces, but then try to
prepend errp with local_err.

Just remove the local_err and use errp directly.

Fixes: 15d024d4aa9b ("hw/block/nvme: split setup and register for namespace")
Cc: Minwoo Im 
Signed-off-by: Klaus Jensen 
---
 hw/block/nvme-ns.c | 7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c
index dfed71a950fa..93ac6e107a09 100644
--- a/hw/block/nvme-ns.c
+++ b/hw/block/nvme-ns.c
@@ -358,17 +358,12 @@ static void nvme_ns_realize(DeviceState *dev, Error 
**errp)
 NvmeNamespace *ns = NVME_NS(dev);
 BusState *s = qdev_get_parent_bus(dev);
 NvmeCtrl *n = NVME(s->parent);
-Error *local_err = NULL;
 
-if (nvme_ns_setup(ns, _err)) {
-error_propagate_prepend(errp, local_err,
-"could not setup namespace: ");
+if (nvme_ns_setup(ns, errp)) {
 return;
 }
 
 if (nvme_register_namespace(n, ns, errp)) {
-error_propagate_prepend(errp, local_err,
-"could not register namespace: ");
 return;
 }
 
-- 
2.30.0