Re: [PATCH] hw/intc: Pass correct hartid while updating mtimecmp

[Alistair Francis]

On Sat, May 14, 2022 at 8:15 AM Atish Patra  wrote:
>
> timecmp update function should be invoked with hartid for which
> timecmp is being updated. The following patch passes the incorrect
> hartid to the update function.
>
> Fixes: e2f01f3c2e13 ("hw/intc: Make RISC-V ACLINT mtime MMIO register 
> writable")
>
> Signed-off-by: Atish Patra 

Thanks!

Applied to riscv-to-apply.next

Alistair

> ---
>  hw/intc/riscv_aclint.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/riscv_aclint.c b/hw/intc/riscv_aclint.c
> index 0412edc98257..e6bceceefdbc 100644
> --- a/hw/intc/riscv_aclint.c
> +++ b/hw/intc/riscv_aclint.c
> @@ -233,7 +233,8 @@ static void riscv_aclint_mtimer_write(void *opaque, 
> hwaddr addr,
>  continue;
>  }
>  riscv_aclint_mtimer_write_timecmp(mtimer, RISCV_CPU(cpu),
> -  i, env->timecmp);
> +  mtimer->hartid_base + i,
> +  env->timecmp);
>  }
>  return;
>  }
> --
> 2.25.1
>
>

Re: [PATCH] hw/intc: Pass correct hartid while updating mtimecmp

[Alistair Francis]

On Sat, May 14, 2022 at 8:15 AM Atish Patra  wrote:
>
> timecmp update function should be invoked with hartid for which
> timecmp is being updated. The following patch passes the incorrect
> hartid to the update function.
>
> Fixes: e2f01f3c2e13 ("hw/intc: Make RISC-V ACLINT mtime MMIO register 
> writable")
>
> Signed-off-by: Atish Patra 

Reviewed-by: Alistair Francis 

Alistair

> ---
>  hw/intc/riscv_aclint.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/riscv_aclint.c b/hw/intc/riscv_aclint.c
> index 0412edc98257..e6bceceefdbc 100644
> --- a/hw/intc/riscv_aclint.c
> +++ b/hw/intc/riscv_aclint.c
> @@ -233,7 +233,8 @@ static void riscv_aclint_mtimer_write(void *opaque, 
> hwaddr addr,
>  continue;
>  }
>  riscv_aclint_mtimer_write_timecmp(mtimer, RISCV_CPU(cpu),
> -  i, env->timecmp);
> +  mtimer->hartid_base + i,
> +  env->timecmp);
>  }
>  return;
>  }
> --
> 2.25.1
>
>

Re: [PATCH] hw/intc: Pass correct hartid while updating mtimecmp

[Anup Patel]

On Sat, May 14, 2022 at 3:45 AM Atish Patra  wrote:
>
> timecmp update function should be invoked with hartid for which
> timecmp is being updated. The following patch passes the incorrect
> hartid to the update function.
>
> Fixes: e2f01f3c2e13 ("hw/intc: Make RISC-V ACLINT mtime MMIO register 
> writable")
>
> Signed-off-by: Atish Patra 

Looks good to me.

Reviewed-by: Anup Patel 

Regards,
Anup

> ---
>  hw/intc/riscv_aclint.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/riscv_aclint.c b/hw/intc/riscv_aclint.c
> index 0412edc98257..e6bceceefdbc 100644
> --- a/hw/intc/riscv_aclint.c
> +++ b/hw/intc/riscv_aclint.c
> @@ -233,7 +233,8 @@ static void riscv_aclint_mtimer_write(void *opaque, 
> hwaddr addr,
>  continue;
>  }
>  riscv_aclint_mtimer_write_timecmp(mtimer, RISCV_CPU(cpu),
> -  i, env->timecmp);
> +  mtimer->hartid_base + i,
> +  env->timecmp);
>  }
>  return;
>  }
> --
> 2.25.1
>
>

Re: [PATCH] hw/intc: Pass correct hartid while updating mtimecmp

[Frank Chang]

Reviewed-by: Frank Chang 

On Sat, May 14, 2022 at 6:15 AM Atish Patra  wrote:

> timecmp update function should be invoked with hartid for which
> timecmp is being updated. The following patch passes the incorrect
> hartid to the update function.
>
> Fixes: e2f01f3c2e13 ("hw/intc: Make RISC-V ACLINT mtime MMIO register
> writable")
>
> Signed-off-by: Atish Patra 
> ---
>  hw/intc/riscv_aclint.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/riscv_aclint.c b/hw/intc/riscv_aclint.c
> index 0412edc98257..e6bceceefdbc 100644
> --- a/hw/intc/riscv_aclint.c
> +++ b/hw/intc/riscv_aclint.c
> @@ -233,7 +233,8 @@ static void riscv_aclint_mtimer_write(void *opaque,
> hwaddr addr,
>  continue;
>  }
>  riscv_aclint_mtimer_write_timecmp(mtimer, RISCV_CPU(cpu),
> -  i, env->timecmp);
> +  mtimer->hartid_base + i,
> +  env->timecmp);
>  }
>  return;
>  }
> --
> 2.25.1
>
>

[PATCH] hw/intc: Pass correct hartid while updating mtimecmp

[Atish Patra]

timecmp update function should be invoked with hartid for which
timecmp is being updated. The following patch passes the incorrect
hartid to the update function.

Fixes: e2f01f3c2e13 ("hw/intc: Make RISC-V ACLINT mtime MMIO register writable")

Signed-off-by: Atish Patra 
---
 hw/intc/riscv_aclint.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/intc/riscv_aclint.c b/hw/intc/riscv_aclint.c
index 0412edc98257..e6bceceefdbc 100644
--- a/hw/intc/riscv_aclint.c
+++ b/hw/intc/riscv_aclint.c
@@ -233,7 +233,8 @@ static void riscv_aclint_mtimer_write(void *opaque, hwaddr 
addr,
 continue;
 }
 riscv_aclint_mtimer_write_timecmp(mtimer, RISCV_CPU(cpu),
-  i, env->timecmp);
+  mtimer->hartid_base + i,
+  env->timecmp);
 }
 return;
 }
-- 
2.25.1