Re: [PATCH] hw/openrisc: use right OMPIC size variable

[Jason A. Donenfeld]

On Tue, May 03, 2022 at 06:19:29PM +0900, Stafford Horne wrote:
> On Mon, May 02, 2022 at 04:59:47PM -0700, Richard Henderson wrote:
> > On 5/2/22 16:28, Jason A. Donenfeld wrote:
> > > This appears to be a copy and paste error. The UART size was used
> > > instead of the much smaller OMPIC size.
> > > 
> > > Signed-off-by: Jason A. Donenfeld
> > > ---
> > >   hw/openrisc/openrisc_sim.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Reviewed-by: Richard Henderson 
> 
> Thanks,
> 
> I will queue this one.
> 
Please take a look at the v2 I posted instead.

Re: [PATCH] hw/openrisc: use right OMPIC size variable

[Stafford Horne]

On Mon, May 02, 2022 at 04:59:47PM -0700, Richard Henderson wrote:
> On 5/2/22 16:28, Jason A. Donenfeld wrote:
> > This appears to be a copy and paste error. The UART size was used
> > instead of the much smaller OMPIC size.
> > 
> > Signed-off-by: Jason A. Donenfeld
> > ---
> >   hw/openrisc/openrisc_sim.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Richard Henderson 

Thanks,

I will queue this one.

Re: [PATCH] hw/openrisc: use right OMPIC size variable

[Richard Henderson]

On 5/2/22 16:28, Jason A. Donenfeld wrote:

This appears to be a copy and paste error. The UART size was used
instead of the much smaller OMPIC size.

Signed-off-by: Jason A. Donenfeld
---
  hw/openrisc/openrisc_sim.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Richard Henderson 

r~

[PATCH] hw/openrisc: use right OMPIC size variable

[Jason A. Donenfeld]

This appears to be a copy and paste error. The UART size was used
instead of the much smaller OMPIC size.

Signed-off-by: Jason A. Donenfeld 
---
 hw/openrisc/openrisc_sim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c
index 99b14940f4..bf434e9737 100644
--- a/hw/openrisc/openrisc_sim.c
+++ b/hw/openrisc/openrisc_sim.c
@@ -410,7 +410,7 @@ static void openrisc_sim_init(MachineState *machine)
 
 if (smp_cpus > 1) {
 openrisc_sim_ompic_init(state, or1ksim_memmap[OR1KSIM_OMPIC].base,
-or1ksim_memmap[OR1KSIM_UART].size,
+or1ksim_memmap[OR1KSIM_OMPIC].size,
 smp_cpus, cpus, OR1KSIM_OMPIC_IRQ);
 }
 
-- 
2.35.1