Re: [PATCH] nbd/server.c: Remove unused field

[Eric Blake]

On Tue, Jan 11, 2022 at 09:17:43PM +0100, Philippe Mathieu-Daudé wrote:
> On 1/11/22 20:43, Nir Soffer wrote:
> > NBDRequestData struct has unused QSIMPLEQ_ENTRY filed. It seems that

s/filed/field/

> > this field exists since the first git commit and was never used.

If my git sleuthing is right, that's commit d9a73806, from 2011.

> > 
> > Signed-off-by: Nir Soffer 
> > ---
> >  nbd/server.c | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Reviewed-by: Philippe Mathieu-Daudé 

Thanks, I'll add that to my NBD queue.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [PATCH] nbd/server.c: Remove unused field

[Philippe Mathieu-Daudé]

On 1/11/22 20:43, Nir Soffer wrote:
> NBDRequestData struct has unused QSIMPLEQ_ENTRY filed. It seems that
> this field exists since the first git commit and was never used.
> 
> Signed-off-by: Nir Soffer 
> ---
>  nbd/server.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé 

[PATCH] nbd/server.c: Remove unused field

[Nir Soffer]

NBDRequestData struct has unused QSIMPLEQ_ENTRY filed. It seems that
this field exists since the first git commit and was never used.

Signed-off-by: Nir Soffer 
---
 nbd/server.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/nbd/server.c b/nbd/server.c
index 3927f7789d..ce5b2a1d02 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -70,21 +70,20 @@ static int system_errno_to_nbd_errno(int err)
 default:
 return NBD_EINVAL;
 }
 }
 
 /* Definitions for opaque data types */
 
 typedef struct NBDRequestData NBDRequestData;
 
 struct NBDRequestData {
-QSIMPLEQ_ENTRY(NBDRequestData) entry;
 NBDClient *client;
 uint8_t *data;
 bool complete;
 };
 
 struct NBDExport {
 BlockExport common;
 
 char *name;
 char *description;
-- 
2.34.1