Re: [PATCH] target/i386: Fix decode of cr8

2021-06-03 Thread Paolo Bonzini 

On 02/06/21 05:55, Richard Henderson wrote:

A recent cleanup did not recognize that there are two ways
to encode cr8: one via the LOCK and the other via REX.

Fixes: 7eff2e7c
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/380
Signed-off-by: Richard Henderson 
---
  target/i386/tcg/translate.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index 834186bcae..a7f5c0c8f2 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -8091,6 +8091,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState 
*cpu)
  case 2:
  case 3:
  case 4:
+case 8:
  break;
  default:
  goto unknown_op;



Queued, thanks.

Paolo

[PATCH] target/i386: Fix decode of cr8

2021-06-01 Thread Richard Henderson 
A recent cleanup did not recognize that there are two ways
to encode cr8: one via the LOCK and the other via REX.

Fixes: 7eff2e7c
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/380
Signed-off-by: Richard Henderson 
---
 target/i386/tcg/translate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index 834186bcae..a7f5c0c8f2 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -8091,6 +8091,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState 
*cpu)
 case 2:
 case 3:
 case 4:
+case 8:
 break;
 default:
 goto unknown_op;
-- 
2.25.1