Re: [PATCH] tb-maint: Document #ifdef..else..endif correctly

[Philippe Mathieu-Daudé]

On 6/7/23 15:43, Richard W.M. Jones wrote:

It was hard to tell from the comments whether the code applied to user
mode (CONFIG_USER_ONLY) or system mode.  Fix the comments on the #else
and #endif directives to be clearer.

Signed-off-by: Richard W.M. Jones 
---
  accel/tcg/tb-maint.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé 

[PATCH] tb-maint: Document #ifdef..else..endif correctly

[Richard W.M. Jones]

It was hard to tell from the comments whether the code applied to user
mode (CONFIG_USER_ONLY) or system mode.  Fix the comments on the #else
and #endif directives to be clearer.

Signed-off-by: Richard W.M. Jones 
---
 accel/tcg/tb-maint.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c
index 9566224d18..bf99a46872 100644
--- a/accel/tcg/tb-maint.c
+++ b/accel/tcg/tb-maint.c
@@ -156,7 +156,7 @@ static PageForEachNext foreach_tb_next(PageForEachNext tb,
 return NULL;
 }
 
-#else
+#else /* !CONFIG_USER_ONLY */
 /*
  * In system mode we want L1_MAP to be based on ram offsets.
  */
@@ -722,7 +722,7 @@ static void page_unlock_tb(const TranslationBlock *tb)
 }
 }
 }
-#endif /* CONFIG_USER_ONLY */
+#endif /* !CONFIG_USER_ONLY */
 
 /* flush all the translation blocks */
 static void do_tb_flush(CPUState *cpu, run_on_cpu_data tb_flush_count)
-- 
2.41.0