Re: [PATCH] util: Return void on iova_tree_remove

2022-06-28 Thread Laurent Vivier 

Le 27/04/2022 à 17:49, Eugenio Pérez a écrit :

It always returns IOVA_OK so nobody uses it.

Acked-by: Jason Wang 
Reviewed-by: Peter Xu 
Signed-off-by: Eugenio Pérez 
---
  include/qemu/iova-tree.h | 4 +---
  util/iova-tree.c | 4 +---
  2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/include/qemu/iova-tree.h b/include/qemu/iova-tree.h
index c938fb0793..16bbfdf5f8 100644
--- a/include/qemu/iova-tree.h
+++ b/include/qemu/iova-tree.h
@@ -72,10 +72,8 @@ int iova_tree_insert(IOVATree *tree, const DMAMap *map);
   * provided.  The range does not need to be exactly what has inserted,
   * all the mappings that are included in the provided range will be
   * removed from the tree.  Here map->translated_addr is meaningless.
- *
- * Return: 0 if succeeded, or <0 if error.
   */
-int iova_tree_remove(IOVATree *tree, const DMAMap *map);
+void iova_tree_remove(IOVATree *tree, const DMAMap *map);

  /**
   * iova_tree_find:
diff --git a/util/iova-tree.c b/util/iova-tree.c
index 6dff29c1f6..fee530a579 100644
--- a/util/iova-tree.c
+++ b/util/iova-tree.c
@@ -164,15 +164,13 @@ void iova_tree_foreach(IOVATree *tree, iova_tree_iterator 
iterator)
  g_tree_foreach(tree->tree, iova_tree_traverse, iterator);
  }

-int iova_tree_remove(IOVATree *tree, const DMAMap *map)
+void iova_tree_remove(IOVATree *tree, const DMAMap *map)
  {
  const DMAMap *overlap;

  while ((overlap = iova_tree_find(tree, map))) {
  g_tree_remove(tree->tree, overlap);
  }
-
-return IOVA_OK;
  }

  /**
--
2.27.0




Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [PATCH] util: Return void on iova_tree_remove

2022-05-12 Thread Laurent Vivier 

On 12/05/2022 18:03, Peter Xu wrote:

On Thu, May 12, 2022 at 05:48:47PM +0200, Eugenio Perez Martin wrote:

On Wed, Apr 27, 2022 at 5:50 PM Eugenio Pérez  wrote:


It always returns IOVA_OK so nobody uses it.

Acked-by: Jason Wang 
Reviewed-by: Peter Xu 
Signed-off-by: Eugenio Pérez 


Hi! Friendly ping about this, is it something pending from my side?


Don't think so. :)

This patch does look fine to go via trivial branch, Laurent?

Also copying Michael since for other iova-tree change it always go via
Michael before.



I can take it via qemu-trivial.

Thanks,
Laurent

Re: [PATCH] util: Return void on iova_tree_remove

2022-05-12 Thread Peter Xu 
On Thu, May 12, 2022 at 05:48:47PM +0200, Eugenio Perez Martin wrote:
> On Wed, Apr 27, 2022 at 5:50 PM Eugenio Pérez  wrote:
> >
> > It always returns IOVA_OK so nobody uses it.
> >
> > Acked-by: Jason Wang 
> > Reviewed-by: Peter Xu 
> > Signed-off-by: Eugenio Pérez 
> 
> Hi! Friendly ping about this, is it something pending from my side?

Don't think so. :)

This patch does look fine to go via trivial branch, Laurent?

Also copying Michael since for other iova-tree change it always go via
Michael before.

Thanks,

-- 
Peter Xu

Re: [PATCH] util: Return void on iova_tree_remove

2022-05-12 Thread Eugenio Perez Martin 
On Wed, Apr 27, 2022 at 5:50 PM Eugenio Pérez  wrote:
>
> It always returns IOVA_OK so nobody uses it.
>
> Acked-by: Jason Wang 
> Reviewed-by: Peter Xu 
> Signed-off-by: Eugenio Pérez 

Hi! Friendly ping about this, is it something pending from my side?

Thanks!

> ---
>  include/qemu/iova-tree.h | 4 +---
>  util/iova-tree.c | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/include/qemu/iova-tree.h b/include/qemu/iova-tree.h
> index c938fb0793..16bbfdf5f8 100644
> --- a/include/qemu/iova-tree.h
> +++ b/include/qemu/iova-tree.h
> @@ -72,10 +72,8 @@ int iova_tree_insert(IOVATree *tree, const DMAMap *map);
>   * provided.  The range does not need to be exactly what has inserted,
>   * all the mappings that are included in the provided range will be
>   * removed from the tree.  Here map->translated_addr is meaningless.
> - *
> - * Return: 0 if succeeded, or <0 if error.
>   */
> -int iova_tree_remove(IOVATree *tree, const DMAMap *map);
> +void iova_tree_remove(IOVATree *tree, const DMAMap *map);
>
>  /**
>   * iova_tree_find:
> diff --git a/util/iova-tree.c b/util/iova-tree.c
> index 6dff29c1f6..fee530a579 100644
> --- a/util/iova-tree.c
> +++ b/util/iova-tree.c
> @@ -164,15 +164,13 @@ void iova_tree_foreach(IOVATree *tree, 
> iova_tree_iterator iterator)
>  g_tree_foreach(tree->tree, iova_tree_traverse, iterator);
>  }
>
> -int iova_tree_remove(IOVATree *tree, const DMAMap *map)
> +void iova_tree_remove(IOVATree *tree, const DMAMap *map)
>  {
>  const DMAMap *overlap;
>
>  while ((overlap = iova_tree_find(tree, map))) {
>  g_tree_remove(tree->tree, overlap);
>  }
> -
> -return IOVA_OK;
>  }
>
>  /**
> --
> 2.27.0
>
>

[PATCH] util: Return void on iova_tree_remove

2022-04-27 Thread Eugenio Pérez 
It always returns IOVA_OK so nobody uses it.

Acked-by: Jason Wang 
Reviewed-by: Peter Xu 
Signed-off-by: Eugenio Pérez 
---
 include/qemu/iova-tree.h | 4 +---
 util/iova-tree.c | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/include/qemu/iova-tree.h b/include/qemu/iova-tree.h
index c938fb0793..16bbfdf5f8 100644
--- a/include/qemu/iova-tree.h
+++ b/include/qemu/iova-tree.h
@@ -72,10 +72,8 @@ int iova_tree_insert(IOVATree *tree, const DMAMap *map);
  * provided.  The range does not need to be exactly what has inserted,
  * all the mappings that are included in the provided range will be
  * removed from the tree.  Here map->translated_addr is meaningless.
- *
- * Return: 0 if succeeded, or <0 if error.
  */
-int iova_tree_remove(IOVATree *tree, const DMAMap *map);
+void iova_tree_remove(IOVATree *tree, const DMAMap *map);

 /**
  * iova_tree_find:
diff --git a/util/iova-tree.c b/util/iova-tree.c
index 6dff29c1f6..fee530a579 100644
--- a/util/iova-tree.c
+++ b/util/iova-tree.c
@@ -164,15 +164,13 @@ void iova_tree_foreach(IOVATree *tree, iova_tree_iterator 
iterator)
 g_tree_foreach(tree->tree, iova_tree_traverse, iterator);
 }

-int iova_tree_remove(IOVATree *tree, const DMAMap *map)
+void iova_tree_remove(IOVATree *tree, const DMAMap *map)
 {
 const DMAMap *overlap;

 while ((overlap = iova_tree_find(tree, map))) {
 g_tree_remove(tree->tree, overlap);
 }
-
-return IOVA_OK;
 }

 /**
--
2.27.0

Re: [PATCH] util: Return void on iova_tree_remove

2022-03-31 Thread Jason Wang 
On Fri, Apr 1, 2022 at 2:17 AM Eugenio Pérez  wrote:
>
> It always returns IOVA_OK so nobody uses it.
>
> Signed-off-by: Eugenio Pérez 

Acked-by: Jason Wang 

> ---
>  include/qemu/iova-tree.h | 4 +---
>  util/iova-tree.c | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/include/qemu/iova-tree.h b/include/qemu/iova-tree.h
> index c938fb0793..16bbfdf5f8 100644
> --- a/include/qemu/iova-tree.h
> +++ b/include/qemu/iova-tree.h
> @@ -72,10 +72,8 @@ int iova_tree_insert(IOVATree *tree, const DMAMap *map);
>   * provided.  The range does not need to be exactly what has inserted,
>   * all the mappings that are included in the provided range will be
>   * removed from the tree.  Here map->translated_addr is meaningless.
> - *
> - * Return: 0 if succeeded, or <0 if error.
>   */
> -int iova_tree_remove(IOVATree *tree, const DMAMap *map);
> +void iova_tree_remove(IOVATree *tree, const DMAMap *map);
>
>  /**
>   * iova_tree_find:
> diff --git a/util/iova-tree.c b/util/iova-tree.c
> index 6dff29c1f6..fee530a579 100644
> --- a/util/iova-tree.c
> +++ b/util/iova-tree.c
> @@ -164,15 +164,13 @@ void iova_tree_foreach(IOVATree *tree, 
> iova_tree_iterator iterator)
>  g_tree_foreach(tree->tree, iova_tree_traverse, iterator);
>  }
>
> -int iova_tree_remove(IOVATree *tree, const DMAMap *map)
> +void iova_tree_remove(IOVATree *tree, const DMAMap *map)
>  {
>  const DMAMap *overlap;
>
>  while ((overlap = iova_tree_find(tree, map))) {
>  g_tree_remove(tree->tree, overlap);
>  }
> -
> -return IOVA_OK;
>  }
>
>  /**
> --
> 2.27.0
>

Re: [PATCH] util: Return void on iova_tree_remove

2022-03-31 Thread Peter Xu 
On Thu, Mar 31, 2022 at 08:17:12PM +0200, Eugenio Pérez wrote:
> It always returns IOVA_OK so nobody uses it.
> 
> Signed-off-by: Eugenio Pérez 

Reviewed-by: Peter Xu 

-- 
Peter Xu

[PATCH] util: Return void on iova_tree_remove

2022-03-31 Thread Eugenio Pérez 
It always returns IOVA_OK so nobody uses it.

Signed-off-by: Eugenio Pérez 
---
 include/qemu/iova-tree.h | 4 +---
 util/iova-tree.c | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/include/qemu/iova-tree.h b/include/qemu/iova-tree.h
index c938fb0793..16bbfdf5f8 100644
--- a/include/qemu/iova-tree.h
+++ b/include/qemu/iova-tree.h
@@ -72,10 +72,8 @@ int iova_tree_insert(IOVATree *tree, const DMAMap *map);
  * provided.  The range does not need to be exactly what has inserted,
  * all the mappings that are included in the provided range will be
  * removed from the tree.  Here map->translated_addr is meaningless.
- *
- * Return: 0 if succeeded, or <0 if error.
  */
-int iova_tree_remove(IOVATree *tree, const DMAMap *map);
+void iova_tree_remove(IOVATree *tree, const DMAMap *map);

 /**
  * iova_tree_find:
diff --git a/util/iova-tree.c b/util/iova-tree.c
index 6dff29c1f6..fee530a579 100644
--- a/util/iova-tree.c
+++ b/util/iova-tree.c
@@ -164,15 +164,13 @@ void iova_tree_foreach(IOVATree *tree, iova_tree_iterator 
iterator)
 g_tree_foreach(tree->tree, iova_tree_traverse, iterator);
 }

-int iova_tree_remove(IOVATree *tree, const DMAMap *map)
+void iova_tree_remove(IOVATree *tree, const DMAMap *map)
 {
 const DMAMap *overlap;

 while ((overlap = iova_tree_find(tree, map))) {
 g_tree_remove(tree->tree, overlap);
 }
-
-return IOVA_OK;
 }

 /**
--
2.27.0