Re: [PATCH-for-9.0 v2 3/8] hw/arm/bcm2836: Use ARM_CPU 'mp-affinity' property

[Peter Maydell]

On Thu, 23 Nov 2023 at 14:38, Philippe Mathieu-Daudé  wrote:
>
> The 'mp-affinity' property is present since commit 15a21fe028
> ("target-arm: Add mp-affinity property for ARM CPU class").
> Use it and remove a /* TODO */ comment. Since all ARM CPUs
> have this property, use _abort, because this call can
> not fail.
>
> Signed-off-by: Philippe Mathieu-Daudé 

Reviewed-by: Peter Maydell 

thanks
-- PMM

[PATCH-for-9.0 v2 3/8] hw/arm/bcm2836: Use ARM_CPU 'mp-affinity' property

[Philippe Mathieu-Daudé]

The 'mp-affinity' property is present since commit 15a21fe028
("target-arm: Add mp-affinity property for ARM CPU class").
Use it and remove a /* TODO */ comment. Since all ARM CPUs
have this property, use _abort, because this call can
not fail.

Signed-off-by: Philippe Mathieu-Daudé 
---
 hw/arm/bcm2836.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c
index a1bd1406e1..289c30e6b6 100644
--- a/hw/arm/bcm2836.c
+++ b/hw/arm/bcm2836.c
@@ -127,8 +127,8 @@ static void bcm2836_realize(DeviceState *dev, Error **errp)
 qdev_get_gpio_in_named(DEVICE(>control), "gpu-fiq", 0));
 
 for (n = 0; n < BCM283X_NCPUS; n++) {
-/* TODO: this should be converted to a property of ARM_CPU */
-s->cpu[n].core.mp_affinity = (bc->clusterid << 8) | n;
+object_property_set_int(OBJECT(>cpu[n].core), "mp-affinity",
+(bc->clusterid << 8) | n, _abort);
 
 /* set periphbase/CBAR value for CPU-local registers */
 object_property_set_int(OBJECT(>cpu[n].core), "reset-cbar",
-- 
2.41.0