Re: [PATCH 0/6] audio/jack: fixes to overall jack behaviour
Patchew URL:
https://patchew.org/QEMU/20200613040518.38172-1-ge...@hostfission.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20200613040518.38172-1-ge...@hostfission.com
Subject: [PATCH 0/6] audio/jack: fixes to overall jack behaviour
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c962352 audio/jack: simplify the re-init code path
1b80c6e audio/jack: honour the enable state of the audio device
d549d5e0 audio/jack: do not remove ports when finishing
d9f3c84 audio/jack: remove invalid set of input support bool
c612550 audio/jack: remove unused stopped state
62d579e audio/jack: fix invalid minimum buffer size check
=== OUTPUT BEGIN ===
1/6 Checking commit 62d579e00e55 (audio/jack: fix invalid minimum buffer size
check)
2/6 Checking commit c612550cb58e (audio/jack: remove unused stopped state)
3/6 Checking commit d9f3c846ec2f (audio/jack: remove invalid set of input
support bool)
4/6 Checking commit d549d5e05a30 (audio/jack: do not remove ports when
finishing)
5/6 Checking commit 1b80c6eb42f5 (audio/jack: honour the enable state of the
audio device)
ERROR: space required before the open parenthesis '('
#42: FILE: audio/jackaudio.c:277:
+for(int i = 0; i < c->nchannels; ++i) {
total: 1 errors, 0 warnings, 91 lines checked
Patch 5/6 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/6 Checking commit c9623522cfe0 (audio/jack: simplify the re-init code path)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200613040518.38172-1-ge...@hostfission.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
[PATCH 0/6] audio/jack: fixes to overall jack behaviour
This patch set addresses several issues that cause inconsistent behaviour in the guest when the sound device is stopped and started or the JACK server stops responding on the host. Geoffrey McRae (6): audio/jack: fix invalid minimum buffer size check audio/jack: remove unused stopped state audio/jack: remove invalid set of input support bool audio/jack: do not remove ports when finishing audio/jack: honour the enable state of the audio device audio/jack: simplify the re-init code path audio/jackaudio.c | 73 --- 1 file changed, 38 insertions(+), 35 deletions(-) -- 2.20.1
Re: [PATCH 0/6] audio/jack: fixes to overall jack behaviour
On Fri, Jun 12, 2020 at 06:05:48PM +1000, Geoffrey McRae wrote:
> Thanks, still learning how best to submit these things :)
> Is it worth re-sending this again as per the below?
Most commit messages are rather brief (just the subject line).
For really simple changes ("remove unused state") this is fine,
but for most patches I'd appreciate a more verbose description.
So, yes, please adjust commit messages and resend as thread.
thanks,
Gerd
Re: [PATCH 0/6] audio/jack: fixes to overall jack behaviour
Thanks, still learning how best to submit these things :) Is it worth re-sending this again as per the below? On 2020-06-12 17:11, Gerd Hoffmann wrote: On Fri, Jun 12, 2020 at 10:12:37AM +1000, Geoffrey McRae wrote: Sorry for the spam, resubmitted due to missing subject on this cover letter. Seems patchew.org can't find the associated patches without it. Alot of tools (patchew probably included) depend on "git send-email --thread" which sends all patches as reply to the cover letter. HTH, Gerd
Re: [PATCH 0/6] audio/jack: fixes to overall jack behaviour
On Fri, Jun 12, 2020 at 10:12:37AM +1000, Geoffrey McRae wrote: > Sorry for the spam, resubmitted due to missing subject on this cover > letter. Seems patchew.org can't find the associated patches without it. Alot of tools (patchew probably included) depend on "git send-email --thread" which sends all patches as reply to the cover letter. HTH, Gerd
[PATCH 0/6] audio/jack: fixes to overall jack behaviour
Sorry for the spam, resubmitted due to missing subject on this cover letter. Seems patchew.org can't find the associated patches without it. This patch set addresses several issues that cause inconsistent behaviour in the guest when the sound device is stopped and started or the JACK server stops responding on the host. Geoffrey McRae (6): audio/jack: fix invalid minimum buffer size check audio/jack: remove unused stopped state audio/jack: remove invalid set of input support bool audio/jack: do not remove ports when finishing audio/jack: honour the enable state of the audio device audio/jack: simplify the re-init code path audio/jackaudio.c | 73 --- 1 file changed, 38 insertions(+), 35 deletions(-) -- 2.20.1
