Re: [PATCH 03/10] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS

[Bin Meng]

On Fri, May 14, 2021 at 12:53 AM Philippe Mathieu-Daudé
 wrote:
>
> The TYPE_NPCM7XX_SMBUS device model exposes an SMBus, but
> this isn't advertised with proper Kconfig symbol, leading
> to an early build failure when building NPCM7XX machines
> standalone:
>
>   The following clauses were found for AT24C
>
>   config AT24C depends on I2C
>   select AT24C if NPCM7XX
>
> Fix by adding SMBUS to NPCM7XX.
>
> Fixes: 94e77879395 ("hw/i2c: Implement NPCM7XX SMBus Module Single Mode")
> Signed-off-by: Philippe Mathieu-Daudé 
> ---
> Cc: Doug Evans
> Cc: Hao Wu 
> Cc: Tyrong Ting
> Cc: Corey Minyard 
> ---
>  hw/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Bin Meng 

Re: [PATCH 03/10] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS

[Hao Wu]

Reviewed-by: Hao Wu 

On Thu, May 13, 2021 at 9:39 AM Philippe Mathieu-Daudé 
wrote:

> The TYPE_NPCM7XX_SMBUS device model exposes an SMBus, but
> this isn't advertised with proper Kconfig symbol, leading
> to an early build failure when building NPCM7XX machines
> standalone:
>
>   The following clauses were found for AT24C
>
>   config AT24C depends on I2C
>   select AT24C if NPCM7XX
>
> Fix by adding SMBUS to NPCM7XX.
>
> Fixes: 94e77879395 ("hw/i2c: Implement NPCM7XX SMBus Module Single Mode")
> Signed-off-by: Philippe Mathieu-Daudé 
> ---
> Cc: Doug Evans
> Cc: Hao Wu 
> Cc: Tyrong Ting
> Cc: Corey Minyard 
> ---
>  hw/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 67723d9ea6a..85c6a1a088c 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -373,6 +373,7 @@ config NPCM7XX
>  bool
>  select A9MPCORE
>  select ARM_GIC
> +select SMBUS
>  select AT24C  # EEPROM
>  select PL310  # cache controller
>  select SERIAL
> --
> 2.26.3
>
>

[PATCH 03/10] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS

[Philippe Mathieu-Daudé]

The TYPE_NPCM7XX_SMBUS device model exposes an SMBus, but
this isn't advertised with proper Kconfig symbol, leading
to an early build failure when building NPCM7XX machines
standalone:

  The following clauses were found for AT24C

  config AT24C depends on I2C
  select AT24C if NPCM7XX

Fix by adding SMBUS to NPCM7XX.

Fixes: 94e77879395 ("hw/i2c: Implement NPCM7XX SMBus Module Single Mode")
Signed-off-by: Philippe Mathieu-Daudé 
---
Cc: Doug Evans
Cc: Hao Wu 
Cc: Tyrong Ting
Cc: Corey Minyard 
---
 hw/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 67723d9ea6a..85c6a1a088c 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -373,6 +373,7 @@ config NPCM7XX
 bool
 select A9MPCORE
 select ARM_GIC
+select SMBUS
 select AT24C  # EEPROM
 select PL310  # cache controller
 select SERIAL
-- 
2.26.3