Re: [PATCH 1/4] hw/isa/vt82c686: Consolidate the use of device_class_set_parent_realize()

[Thomas Huth]

On 01/02/2024 09.40, Zhao Liu wrote:

From: Zhao Liu 

Use device_class_set_parent_realize() to set parent realize() directly.

Signed-off-by: Zhao Liu 
---
  hw/isa/vt82c686.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index d3e0f6d01fb6..a99eae4f6333 100644
--- a/hw/isa/vt82c686.c
+++ b/hw/isa/vt82c686.c
@@ -328,8 +328,8 @@ static void via_superio_class_init(ObjectClass *klass, void 
*data)
  DeviceClass *dc = DEVICE_CLASS(klass);
  ISASuperIOClass *sc = ISA_SUPERIO_CLASS(klass);
  
-sc->parent_realize = dc->realize;

-dc->realize = via_superio_realize;
+device_class_set_parent_realize(dc, via_superio_realize,
+&sc->parent_realize);
  }
  
  static const TypeInfo via_superio_info = {


Reviewed-by: Thomas Huth 

[PATCH 1/4] hw/isa/vt82c686: Consolidate the use of device_class_set_parent_realize()

[Zhao Liu]

From: Zhao Liu 

Use device_class_set_parent_realize() to set parent realize() directly.

Signed-off-by: Zhao Liu 
---
 hw/isa/vt82c686.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index d3e0f6d01fb6..a99eae4f6333 100644
--- a/hw/isa/vt82c686.c
+++ b/hw/isa/vt82c686.c
@@ -328,8 +328,8 @@ static void via_superio_class_init(ObjectClass *klass, void 
*data)
 DeviceClass *dc = DEVICE_CLASS(klass);
 ISASuperIOClass *sc = ISA_SUPERIO_CLASS(klass);
 
-sc->parent_realize = dc->realize;
-dc->realize = via_superio_realize;
+device_class_set_parent_realize(dc, via_superio_realize,
+&sc->parent_realize);
 }
 
 static const TypeInfo via_superio_info = {
-- 
2.34.1