Re: [PATCH 1/5] virtio-gpu: do not byteswap padding

2021-11-11 Thread Alex Bennée 


Paolo Bonzini  writes:

> In Linux 5.16, the padding of struct virtio_gpu_ctrl_hdr has become a
> single-byte field followed by a uint8_t[3] array of padding bytes,
> and virtio_gpu_ctrl_hdr_bswap does not compile anymore.
>
> Signed-off-by: Paolo Bonzini 

Reviewed-by: Alex Bennée 

-- 
Alex Bennée

Re: [PATCH 1/5] virtio-gpu: do not byteswap padding

2021-11-11 Thread Michael S. Tsirkin 
On Thu, Nov 11, 2021 at 12:06:00PM +0100, Paolo Bonzini wrote:
> In Linux 5.16, the padding of struct virtio_gpu_ctrl_hdr has become a
> single-byte field followed by a uint8_t[3] array of padding bytes,
> and virtio_gpu_ctrl_hdr_bswap does not compile anymore.
> 
> Signed-off-by: Paolo Bonzini 

Reviewed-by: Michael S. Tsirkin 

No idea why we bothered swapping it anyway.
> ---
>  include/hw/virtio/virtio-gpu-bswap.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/hw/virtio/virtio-gpu-bswap.h 
> b/include/hw/virtio/virtio-gpu-bswap.h
> index e2bee8f595..5faac0d8d5 100644
> --- a/include/hw/virtio/virtio-gpu-bswap.h
> +++ b/include/hw/virtio/virtio-gpu-bswap.h
> @@ -24,7 +24,6 @@ virtio_gpu_ctrl_hdr_bswap(struct virtio_gpu_ctrl_hdr *hdr)
>  le32_to_cpus(>flags);
>  le64_to_cpus(>fence_id);
>  le32_to_cpus(>ctx_id);
> -le32_to_cpus(>padding);
>  }
>  
>  static inline void
> -- 
> 2.33.1
>

Re: [PATCH 1/5] virtio-gpu: do not byteswap padding

2021-11-11 Thread Philippe Mathieu-Daudé 
On 11/11/21 12:06, Paolo Bonzini wrote:
> In Linux 5.16, the padding of struct virtio_gpu_ctrl_hdr has become a
> single-byte field followed by a uint8_t[3] array of padding bytes,
> and virtio_gpu_ctrl_hdr_bswap does not compile anymore.
> 
> Signed-off-by: Paolo Bonzini 
> ---
>  include/hw/virtio/virtio-gpu-bswap.h | 1 -
>  1 file changed, 1 deletion(-)

:)

Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 1/5] virtio-gpu: do not byteswap padding

2021-11-11 Thread Cornelia Huck 
On Thu, Nov 11 2021, Paolo Bonzini  wrote:

> In Linux 5.16, the padding of struct virtio_gpu_ctrl_hdr has become a
> single-byte field followed by a uint8_t[3] array of padding bytes,
> and virtio_gpu_ctrl_hdr_bswap does not compile anymore.
>
> Signed-off-by: Paolo Bonzini 
> ---
>  include/hw/virtio/virtio-gpu-bswap.h | 1 -
>  1 file changed, 1 deletion(-)

Looks like the right way to adapt to the changes.

Acked-by: Cornelia Huck

[PATCH 1/5] virtio-gpu: do not byteswap padding

2021-11-11 Thread Paolo Bonzini 
In Linux 5.16, the padding of struct virtio_gpu_ctrl_hdr has become a
single-byte field followed by a uint8_t[3] array of padding bytes,
and virtio_gpu_ctrl_hdr_bswap does not compile anymore.

Signed-off-by: Paolo Bonzini 
---
 include/hw/virtio/virtio-gpu-bswap.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/hw/virtio/virtio-gpu-bswap.h 
b/include/hw/virtio/virtio-gpu-bswap.h
index e2bee8f595..5faac0d8d5 100644
--- a/include/hw/virtio/virtio-gpu-bswap.h
+++ b/include/hw/virtio/virtio-gpu-bswap.h
@@ -24,7 +24,6 @@ virtio_gpu_ctrl_hdr_bswap(struct virtio_gpu_ctrl_hdr *hdr)
 le32_to_cpus(>flags);
 le64_to_cpus(>fence_id);
 le32_to_cpus(>ctx_id);
-le32_to_cpus(>padding);
 }
 
 static inline void
-- 
2.33.1