Re: [PATCH 1/7] target/ppc: Enforce that the root page directory size must be at least 5

[David Gibson]

On Mon, Mar 30, 2020 at 11:49:40AM +0200, Cédric Le Goater wrote:
> From: Suraj Jitindar Singh 
> 
> According to the ISA the root page directory size of a radix tree for
> either process- or partition-scoped translation must be >= 5.
> 
> Thus add this to the list of conditions checked when validating the
> partition table entry in validate_pate();
> 
> Signed-off-by: Suraj Jitindar Singh 
> Reviewed-by: David Gibson 
> Signed-off-by: Cédric Le Goater 

Applied to ppc-for-5.1.

> ---
>  target/ppc/mmu-radix64.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> index 224e646c5094..99678570581b 100644
> --- a/target/ppc/mmu-radix64.c
> +++ b/target/ppc/mmu-radix64.c
> @@ -212,6 +212,9 @@ static bool validate_pate(PowerPCCPU *cpu, uint64_t lpid, 
> ppc_v3_pate_t *pate)
>  if (lpid == 0 && !msr_hv) {
>  return false;
>  }
> +if ((pate->dw0 & PATE1_R_PRTS) < 5) {
> +return false;
> +}
>  /* More checks ... */
>  return true;
>  }

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature

Re: [PATCH 1/7] target/ppc: Enforce that the root page directory size must be at least 5

[Greg Kurz]

On Mon, 30 Mar 2020 11:49:40 +0200
Cédric Le Goater  wrote:

> From: Suraj Jitindar Singh 
> 
> According to the ISA the root page directory size of a radix tree for
> either process- or partition-scoped translation must be >= 5.
> 
> Thus add this to the list of conditions checked when validating the
> partition table entry in validate_pate();
> 
> Signed-off-by: Suraj Jitindar Singh 
> Reviewed-by: David Gibson 
> Signed-off-by: Cédric Le Goater 
> ---

Reviewed-by: Greg Kurz 

>  target/ppc/mmu-radix64.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> index 224e646c5094..99678570581b 100644
> --- a/target/ppc/mmu-radix64.c
> +++ b/target/ppc/mmu-radix64.c
> @@ -212,6 +212,9 @@ static bool validate_pate(PowerPCCPU *cpu, uint64_t lpid, 
> ppc_v3_pate_t *pate)
>  if (lpid == 0 && !msr_hv) {
>  return false;
>  }
> +if ((pate->dw0 & PATE1_R_PRTS) < 5) {
> +return false;
> +}
>  /* More checks ... */
>  return true;
>  }

[PATCH 1/7] target/ppc: Enforce that the root page directory size must be at least 5

[Cédric Le Goater]

From: Suraj Jitindar Singh 

According to the ISA the root page directory size of a radix tree for
either process- or partition-scoped translation must be >= 5.

Thus add this to the list of conditions checked when validating the
partition table entry in validate_pate();

Signed-off-by: Suraj Jitindar Singh 
Reviewed-by: David Gibson 
Signed-off-by: Cédric Le Goater 
---
 target/ppc/mmu-radix64.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
index 224e646c5094..99678570581b 100644
--- a/target/ppc/mmu-radix64.c
+++ b/target/ppc/mmu-radix64.c
@@ -212,6 +212,9 @@ static bool validate_pate(PowerPCCPU *cpu, uint64_t lpid, 
ppc_v3_pate_t *pate)
 if (lpid == 0 && !msr_hv) {
 return false;
 }
+if ((pate->dw0 & PATE1_R_PRTS) < 5) {
+return false;
+}
 /* More checks ... */
 return true;
 }
-- 
2.21.1