Re: [PATCH 1/8] etsec: Use TYPE_ETSEC_COMMON constant

[David Gibson]

On Wed, Aug 26, 2020 at 02:43:27PM -0400, Eduardo Habkost wrote:
> This will make future conversion to use OBJECT_DECLARE* easier.
> 
> Signed-off-by: Eduardo Habkost 

Acked-by: David Gibson 

> ---
> Cc: David Gibson 
> Cc: Jason Wang 
> Cc: qemu-...@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
>  hw/net/fsl_etsec/etsec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
> index 7035cf4eb9..ad20b22cdd 100644
> --- a/hw/net/fsl_etsec/etsec.c
> +++ b/hw/net/fsl_etsec/etsec.c
> @@ -430,7 +430,7 @@ static void etsec_class_init(ObjectClass *klass, void 
> *data)
>  }
>  
>  static TypeInfo etsec_info = {
> -.name  = "eTSEC",
> +.name  = TYPE_ETSEC_COMMON,
>  .parent= TYPE_SYS_BUS_DEVICE,
>  .instance_size = sizeof(eTSEC),
>  .class_init= etsec_class_init,

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature

Re: [PATCH 1/8] etsec: Use TYPE_ETSEC_COMMON constant

[Li Qiang]

Eduardo Habkost  于2020年8月27日周四 上午2:46写道：
>
> This will make future conversion to use OBJECT_DECLARE* easier.
>
> Signed-off-by: Eduardo Habkost 

Reviewed-by: Li Qiang 

> ---
> Cc: David Gibson 
> Cc: Jason Wang 
> Cc: qemu-...@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
>  hw/net/fsl_etsec/etsec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
> index 7035cf4eb9..ad20b22cdd 100644
> --- a/hw/net/fsl_etsec/etsec.c
> +++ b/hw/net/fsl_etsec/etsec.c
> @@ -430,7 +430,7 @@ static void etsec_class_init(ObjectClass *klass, void 
> *data)
>  }
>
>  static TypeInfo etsec_info = {
> -.name  = "eTSEC",
> +.name  = TYPE_ETSEC_COMMON,
>  .parent= TYPE_SYS_BUS_DEVICE,
>  .instance_size = sizeof(eTSEC),
>  .class_init= etsec_class_init,
> --
> 2.26.2
>
>

[PATCH 1/8] etsec: Use TYPE_ETSEC_COMMON constant

[Eduardo Habkost]

This will make future conversion to use OBJECT_DECLARE* easier.

Signed-off-by: Eduardo Habkost 
---
Cc: David Gibson 
Cc: Jason Wang 
Cc: qemu-...@nongnu.org
Cc: qemu-devel@nongnu.org
---
 hw/net/fsl_etsec/etsec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
index 7035cf4eb9..ad20b22cdd 100644
--- a/hw/net/fsl_etsec/etsec.c
+++ b/hw/net/fsl_etsec/etsec.c
@@ -430,7 +430,7 @@ static void etsec_class_init(ObjectClass *klass, void *data)
 }
 
 static TypeInfo etsec_info = {
-.name  = "eTSEC",
+.name  = TYPE_ETSEC_COMMON,
 .parent= TYPE_SYS_BUS_DEVICE,
 .instance_size = sizeof(eTSEC),
 .class_init= etsec_class_init,
-- 
2.26.2