Re: [PATCH 2/6] mt48t59: Set default value of base-year property to 1968

2020-10-18 Thread Philippe Mathieu-Daudé 

On 10/17/20 10:13 PM, BALATON Zoltan via wrote:

All instances set this value explicitely so make it the default to


Typo explicitely -> explicitly.


make it simpler to create instances without setting property.

Signed-off-by: BALATON Zoltan 


Reviewed-by: Philippe Mathieu-Daudé 


---
  hw/rtc/m48t59.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/rtc/m48t59.c b/hw/rtc/m48t59.c
index 6525206976..3108cf3d3f 100644
--- a/hw/rtc/m48t59.c
+++ b/hw/rtc/m48t59.c
@@ -655,7 +655,7 @@ static void m48txx_sysbus_toggle_lock(Nvram *obj, int lock)
  }
  
  static Property m48t59_sysbus_properties[] = {

-DEFINE_PROP_INT32("base-year", M48txxSysBusState, state.base_year, 0),
+DEFINE_PROP_INT32("base-year", M48txxSysBusState, state.base_year, 1968),
  DEFINE_PROP_END_OF_LIST(),
  };

[PATCH 2/6] mt48t59: Set default value of base-year property to 1968

2020-10-17 Thread BALATON Zoltan via 
All instances set this value explicitely so make it the default to
make it simpler to create instances without setting property.

Signed-off-by: BALATON Zoltan 
---
 hw/rtc/m48t59.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/rtc/m48t59.c b/hw/rtc/m48t59.c
index 6525206976..3108cf3d3f 100644
--- a/hw/rtc/m48t59.c
+++ b/hw/rtc/m48t59.c
@@ -655,7 +655,7 @@ static void m48txx_sysbus_toggle_lock(Nvram *obj, int lock)
 }
 
 static Property m48t59_sysbus_properties[] = {
-DEFINE_PROP_INT32("base-year", M48txxSysBusState, state.base_year, 0),
+DEFINE_PROP_INT32("base-year", M48txxSysBusState, state.base_year, 1968),
 DEFINE_PROP_END_OF_LIST(),
 };
 
-- 
2.21.3