Re: [PATCH 4/4] configure: Test if $make actually exists
On Sun, Aug 23, 2020 at 12:21:29AM +0300, Roman Bolshakov wrote: > configure doesn't detect if $make is installed on the build host. > This is also helpful for hosts where an alias for make is used, i.e. > configure would fail if gmake is not present on macOS. > > Signed-off-by: Roman Bolshakov > --- > configure | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
[PATCH 4/4] configure: Test if $make actually exists
configure doesn't detect if $make is installed on the build host. This is also helpful for hosts where an alias for make is used, i.e. configure would fail if gmake is not present on macOS. Signed-off-by: Roman Bolshakov --- configure | 4 1 file changed, 4 insertions(+) diff --git a/configure b/configure index 90b02b7271..c324252f60 100755 --- a/configure +++ b/configure @@ -2021,6 +2021,10 @@ if test -z "$python" then error_exit "Python not found. Use --python=/path/to/python" fi +if ! has "$make" +then +error_exit "GNU make ($make) not found" +fi # Note that if the Python conditional here evaluates True we will exit # with status 1 which is a shell 'false' value. -- 2.28.0
