Re: [PATCH 4/5] hw/isa/Kconfig: Add missing dependency to VT82C686
Am 12. Dezember 2022 10:37:12 UTC schrieb "Philippe Mathieu-Daudé" : >On 8/12/22 00:12, Bernhard Beschow wrote: >> Both ACPI_PIIX4 (directly) and ACPI_ICH9 (indirectly) require ACPI to be >> selected. Require it for VT82C686's ACPI controller too for consistency. >> >> Signed-off-by: Bernhard Beschow >> --- >> hw/isa/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig >> index 0a6a04947c..bc2e3ecf02 100644 >> --- a/hw/isa/Kconfig >> +++ b/hw/isa/Kconfig >> @@ -63,6 +63,7 @@ config VT82C686 >> select IDE_VIA >> select MC146818RTC >> select PARALLEL >> +depends on ACPI > >The VT82C686 *provides* the ACPI interface, so here we want to "select" >ACPI (if we need a VT82C686, then ACPI will be available). I agree. I'd then also adapt PIIX4 and LPC. Best regards, Bernhard
Re: [PATCH 4/5] hw/isa/Kconfig: Add missing dependency to VT82C686
On 8/12/22 00:12, Bernhard Beschow wrote: Both ACPI_PIIX4 (directly) and ACPI_ICH9 (indirectly) require ACPI to be selected. Require it for VT82C686's ACPI controller too for consistency. Signed-off-by: Bernhard Beschow --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 0a6a04947c..bc2e3ecf02 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -63,6 +63,7 @@ config VT82C686 select IDE_VIA select MC146818RTC select PARALLEL +depends on ACPI The VT82C686 *provides* the ACPI interface, so here we want to "select" ACPI (if we need a VT82C686, then ACPI will be available).
[PATCH 4/5] hw/isa/Kconfig: Add missing dependency to VT82C686
Both ACPI_PIIX4 (directly) and ACPI_ICH9 (indirectly) require ACPI to be selected. Require it for VT82C686's ACPI controller too for consistency. Signed-off-by: Bernhard Beschow --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 0a6a04947c..bc2e3ecf02 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -63,6 +63,7 @@ config VT82C686 select IDE_VIA select MC146818RTC select PARALLEL +depends on ACPI config SMC37C669 bool -- 2.38.1
