Re: [PATCH 5/5] Fixing Lesser GPL version number [5/5]

2020-10-09 Thread Daniel P . Berrangé
On Fri, Oct 09, 2020 at 06:44:10AM +, Chetan Pant wrote:
> There is no "version 2" of the "Lesser" General Public License. It is
> either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all
> occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in 
> comment section.
> Also, It came to notice that some of the files that were edited for the change
> were not following latest comment rules. For example using "//" to mark 
> comment
> instead of "/*". That is also fixed in this patch.
> 
> This patch is divided in 5 parts, directory wise, in order to make reviewing 
> process easier.
> Below listed are the parts of the patch, where asterisk denotes the part you 
> are currently viewing.
> 
>   [ ] Files in authz/backends/block/linux-user/tests/migration directory 
> (82 Files)
>   [ ] Files in hw/include/disas (100 files)
>   [ ] Files inside target/ 'alpha,arm,cris,hppa,i386' (96 files)
>   [ ] Files inside target/ 
> 'lm32,microblaze,mips,ppc,rx,sparc,tilegx,tricore,xtensa' (63 files)
>   [*] Files in ui/util/include/scripts and QEMU root directory (76 Files)
> 
> Below is how the license version was corrected:
> 
> 1. To find the number of file having "Lesser GPL version 2 ":
>   grep -l Lesser $(grep -rl "version 2 " * ) > result.dat
>Total of 417 files were found (After manually exluding the files like 
> COPYING and COPYING.LIB from the result)
> 
> 2. To find the number of occurences of "version 2 " in the resulted files:
>   egrep -c "version 2 " $(cat result.dat)
>410 files had "version 2" occurence 1 time (name of those files was saved 
> in one_timers.dat)
>and in 7 files "version 2" occurences were multiple times.
> 
> 3. Files having occurence exactly 1 time were corrected using below command:
>   sed -i "s/version 2 /version 2.1 /g" $(cat one_timers.dat)
>For rest of 7 files, correction was done manually.
> 
> Signed-off-by: Chetan Pant 
> ---
>  cpus-common.c | 2 +-
>  exec-vary.c   | 2 +-
>  exec.c| 2 +-
>  include/authz/base.h  | 2 +-
>  include/authz/list.h  | 2 +-
>  include/authz/listfile.h  | 2 +-
>  include/authz/pamacct.h   | 2 +-
>  include/authz/simple.h| 2 +-

Can you include these with the "authz" pieces from patch 1 and I'll
queue them


>  include/io/channel-buffer.h   | 2 +-
>  include/io/channel-command.h  | 2 +-
>  include/io/channel-file.h | 2 +-
>  include/io/channel-socket.h   | 2 +-
>  include/io/channel-tls.h  | 2 +-
>  include/io/channel-util.h | 2 +-
>  include/io/channel-watch.h| 2 +-
>  include/io/channel-websock.h  | 2 +-
>  include/io/channel.h  | 2 +-
>  include/io/dns-resolver.h | 2 +-
>  include/io/task.h | 2 +-

Combine with the "io" pieces from patch 1.


Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|




[PATCH 5/5] Fixing Lesser GPL version number [5/5]

2020-10-09 Thread Chetan Pant
There is no "version 2" of the "Lesser" General Public License. It is
either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all
occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment 
section.
Also, It came to notice that some of the files that were edited for the change
were not following latest comment rules. For example using "//" to mark comment
instead of "/*". That is also fixed in this patch.

This patch is divided in 5 parts, directory wise, in order to make reviewing 
process easier.
Below listed are the parts of the patch, where asterisk denotes the part you 
are currently viewing.

[ ] Files in authz/backends/block/linux-user/tests/migration directory 
(82 Files)
[ ] Files in hw/include/disas (100 files)
[ ] Files inside target/ 'alpha,arm,cris,hppa,i386' (96 files)
[ ] Files inside target/ 
'lm32,microblaze,mips,ppc,rx,sparc,tilegx,tricore,xtensa' (63 files)
[*] Files in ui/util/include/scripts and QEMU root directory (76 Files)

Below is how the license version was corrected:

1. To find the number of file having "Lesser GPL version 2 ":
grep -l Lesser $(grep -rl "version 2 " * ) > result.dat
   Total of 417 files were found (After manually exluding the files like 
COPYING and COPYING.LIB from the result)

2. To find the number of occurences of "version 2 " in the resulted files:
egrep -c "version 2 " $(cat result.dat)
   410 files had "version 2" occurence 1 time (name of those files was saved in 
one_timers.dat)
   and in 7 files "version 2" occurences were multiple times.

3. Files having occurence exactly 1 time were corrected using below command:
sed -i "s/version 2 /version 2.1 /g" $(cat one_timers.dat)
   For rest of 7 files, correction was done manually.

Signed-off-by: Chetan Pant 
---
 cpus-common.c | 2 +-
 exec-vary.c   | 2 +-
 exec.c| 2 +-
 include/authz/base.h  | 2 +-
 include/authz/list.h  | 2 +-
 include/authz/listfile.h  | 2 +-
 include/authz/pamacct.h   | 2 +-
 include/authz/simple.h| 2 +-
 include/exec/cpu-all.h| 2 +-
 include/exec/cpu-defs.h   | 2 +-
 include/exec/cpu_ldst.h   | 2 +-
 include/exec/cputlb.h | 2 +-
 include/exec/exec-all.h   | 2 +-
 include/exec/ioport.h | 2 +-
 include/exec/memory_ldst.h.inc| 2 +-
 include/exec/memory_ldst_cached.h.inc | 2 +-
 include/exec/memory_ldst_phys.h.inc   | 2 +-
 include/exec/tb-context.h | 2 +-
 include/exec/tb-hash.h| 2 +-
 include/exec/user/thunk.h | 2 +-
 include/hw/acpi/acpi.h| 2 +-
 include/hw/acpi/ich9.h| 2 +-
 include/hw/acpi/pcihp.h   | 2 +-
 include/hw/display/milkymist_tmu2.h   | 2 +-
 include/hw/i386/apic_internal.h   | 2 +-
 include/hw/i386/ioapic.h  | 2 +-
 include/hw/i386/ioapic_internal.h | 2 +-
 include/hw/ide/ahci.h | 2 +-
 include/hw/loader-fit.h   | 2 +-
 include/hw/mips/cps.h | 2 +-
 include/hw/misc/mips_cpc.h| 2 +-
 include/hw/misc/mips_itu.h| 2 +-
 include/hw/pci-host/designware.h  | 2 +-
 include/hw/pci-host/spapr.h   | 2 +-
 include/hw/pci-host/xilinx-pcie.h | 2 +-
 include/hw/platform-bus.h | 2 +-
 include/hw/ppc/pnv.h  | 2 +-
 include/hw/ppc/pnv_core.h | 2 +-
 include/hw/ppc/pnv_homer.h| 2 +-
 include/hw/ppc/pnv_lpc.h  | 2 +-
 include/hw/ppc/pnv_occ.h  | 2 +-
 include/hw/ppc/pnv_psi.h  | 2 +-
 include/hw/ppc/pnv_xscom.h| 2 +-
 include/hw/ppc/spapr_vio.h| 2 +-
 include/hw/semihosting/semihost.h | 2 +-
 include/io/channel-buffer.h   | 2 +-
 include/io/channel-command.h  | 2 +-
 include/io/channel-file.h | 2 +-
 include/io/channel-socket.h   | 2 +-
 include/io/channel-tls.h  | 2 +-
 include/io/channel-util.h | 2 +-
 include/io/channel-watch.h| 2 +-
 include/io/channel-websock.h  | 2 +-
 include/io/channel.h  | 2 +-
 include/io/dns-resolver.h | 2 +-
 include/io/task.h | 2 +-
 include/qemu/base64.h | 2 +-
 include/qemu/buffer.h | 2 +-
 include/qemu/filemonitor.h| 2 +-
 include/sysemu/cryptodev-vhost-user.h | 2 +-
 include/sysemu/cryptodev-vhost.h  | 2 +-
 include/sysemu/cryptodev.h| 2 +-
 include/sysemu/tpm_util.h | 2 +-
 memory_ldst.c.inc | 2 +-
 qdev-monitor.c| 2 +-
 scripts/analyze-migration.py  | 2 +-
 scripts/decodetree.py | 2 +-
 scripts/replay-dump.py| 2 +-
 thunk.c