Re: [PATCH 66/70] target/xtensa: Split constant in bit shift

[Philippe Mathieu-Daudé]

On 27/2/23 06:42, Richard Henderson wrote:

Signed-off-by: Richard Henderson 
---
  target/xtensa/translate.c | 8 
  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé 

Re: [PATCH 66/70] target/xtensa: Split constant in bit shift

[Max Filippov]

On Sun, Feb 26, 2023 at 9:48 PM Richard Henderson
 wrote:
>
> Signed-off-by: Richard Henderson 
> ---
>  target/xtensa/translate.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Max Filippov 

-- 
Thanks.
-- Max

[PATCH 66/70] target/xtensa: Split constant in bit shift

[Richard Henderson]

Signed-off-by: Richard Henderson 
---
 target/xtensa/translate.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 2903c73f8e..f906ba7ed5 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
@@ -2047,8 +2047,8 @@ static uint32_t test_exceptions_retw(DisasContext *dc, 
const OpcodeArg arg[],
 static void translate_retw(DisasContext *dc, const OpcodeArg arg[],
const uint32_t par[])
 {
-TCGv_i32 tmp = tcg_const_i32(1);
-tcg_gen_shl_i32(tmp, tmp, cpu_SR[WINDOW_BASE]);
+TCGv_i32 tmp = tcg_temp_new();
+tcg_gen_shl_i32(tmp, tcg_constant_i32(1), cpu_SR[WINDOW_BASE]);
 tcg_gen_andc_i32(cpu_SR[WINDOW_START],
  cpu_SR[WINDOW_START], tmp);
 tcg_gen_movi_i32(tmp, dc->pc);
@@ -2080,10 +2080,10 @@ static void translate_rfi(DisasContext *dc, const 
OpcodeArg arg[],
 static void translate_rfw(DisasContext *dc, const OpcodeArg arg[],
   const uint32_t par[])
 {
-TCGv_i32 tmp = tcg_const_i32(1);
+TCGv_i32 tmp = tcg_temp_new();
 
 tcg_gen_andi_i32(cpu_SR[PS], cpu_SR[PS], ~PS_EXCM);
-tcg_gen_shl_i32(tmp, tmp, cpu_SR[WINDOW_BASE]);
+tcg_gen_shl_i32(tmp, tcg_constant_i32(1), cpu_SR[WINDOW_BASE]);
 
 if (par[0]) {
 tcg_gen_andc_i32(cpu_SR[WINDOW_START],
-- 
2.34.1