Re: [PATCH 70/71] tests/unit/test-vmstate: Constify VMState

2023-11-06 Thread Juan Quintela
Richard Henderson  wrote:
> While const data in tests is not particularly important,
> this makes a grep test clear across the tree.
>
> Signed-off-by: Richard Henderson 

Reviewed-by: Juan Quintela 




[PATCH 70/71] tests/unit/test-vmstate: Constify VMState

2023-11-05 Thread Richard Henderson
While const data in tests is not particularly important,
this makes a grep test clear across the tree.

Signed-off-by: Richard Henderson 
---
 tests/unit/test-vmstate.c | 36 ++--
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/tests/unit/test-vmstate.c b/tests/unit/test-vmstate.c
index 0b7d5ecd68..c4f9faa273 100644
--- a/tests/unit/test-vmstate.c
+++ b/tests/unit/test-vmstate.c
@@ -197,7 +197,7 @@ static const VMStateDescription vmstate_simple_primitive = {
 .name = "simple/primitive",
 .version_id = 1,
 .minimum_version_id = 1,
-.fields = (VMStateField[]) {
+.fields = (const VMStateField[]) {
 VMSTATE_BOOL(b_1, TestSimple),
 VMSTATE_BOOL(b_2, TestSimple),
 VMSTATE_UINT8(u8_1, TestSimple),
@@ -299,7 +299,7 @@ static const VMStateDescription vmstate_simple_arr = {
 .name = "simple/array",
 .version_id = 1,
 .minimum_version_id = 1,
-.fields = (VMStateField[]) {
+.fields = (const VMStateField[]) {
 VMSTATE_UINT16_ARRAY(u16_1, TestSimpleArray, 3),
 VMSTATE_END_OF_LIST()
 }
@@ -341,7 +341,7 @@ static const VMStateDescription vmstate_versioned = {
 .name = "test/versioned",
 .version_id = 2,
 .minimum_version_id = 1,
-.fields = (VMStateField[]) {
+.fields = (const VMStateField[]) {
 VMSTATE_UINT32(a, TestStruct),
 VMSTATE_UINT32_V(b, TestStruct, 2), /* Versioned field in the middle, 
so
  * we catch bugs more easily.
@@ -412,7 +412,7 @@ static const VMStateDescription vmstate_skipping = {
 .name = "test/skip",
 .version_id = 2,
 .minimum_version_id = 1,
-.fields = (VMStateField[]) {
+.fields = (const VMStateField[]) {
 VMSTATE_UINT32(a, TestStruct),
 VMSTATE_UINT32(b, TestStruct),
 VMSTATE_UINT32_TEST(c, TestStruct, test_skip),
@@ -524,7 +524,7 @@ const VMStateDescription vmsd_tst = {
 .name = "test/tst",
 .version_id = 1,
 .minimum_version_id = 1,
-.fields = (VMStateField[]) {
+.fields = (const VMStateField[]) {
 VMSTATE_INT32(i, TestStructTriv),
 VMSTATE_END_OF_LIST()
 }
@@ -542,7 +542,7 @@ const VMStateDescription vmsd_arps = {
 .name = "test/arps",
 .version_id = 1,
 .minimum_version_id = 1,
-.fields = (VMStateField[]) {
+.fields = (const VMStateField[]) {
 VMSTATE_ARRAY_OF_POINTER_TO_STRUCT(ar, TestArrayOfPtrToStuct,
 AR_SIZE, 0, vmsd_tst, TestStructTriv),
 VMSTATE_END_OF_LIST()
@@ -630,7 +630,7 @@ const VMStateDescription vmsd_arpp = {
 .name = "test/arps",
 .version_id = 1,
 .minimum_version_id = 1,
-.fields = (VMStateField[]) {
+.fields = (const VMStateField[]) {
 VMSTATE_ARRAY_OF_POINTER(ar, TestArrayOfPtrToInt,
 AR_SIZE, 0, vmstate_info_int32, int32_t*),
 VMSTATE_END_OF_LIST()
@@ -685,7 +685,7 @@ static const VMStateDescription vmstate_q_element = {
 .name = "test/queue-element",
 .version_id = 1,
 .minimum_version_id = 1,
-.fields = (VMStateField[]) {
+.fields = (const VMStateField[]) {
 VMSTATE_BOOL(b, TestQtailqElement),
 VMSTATE_UINT8(u8, TestQtailqElement),
 VMSTATE_END_OF_LIST()
@@ -696,7 +696,7 @@ static const VMStateDescription vmstate_q = {
 .name = "test/queue",
 .version_id = 1,
 .minimum_version_id = 1,
-.fields = (VMStateField[]) {
+.fields = (const VMStateField[]) {
 VMSTATE_INT16(i16, TestQtailq),
 VMSTATE_QTAILQ_V(q, TestQtailq, 1, vmstate_q_element, 
TestQtailqElement,
  next),
@@ -821,7 +821,7 @@ typedef struct TestGTreeInterval {
 .name = "interval",\
 .version_id = 1,   \
 .minimum_version_id = 1,   \
-.fields = (VMStateField[]) {   \
+.fields = (const VMStateField[]) { \
 VMSTATE_UINT64(low, TestGTreeInterval),\
 VMSTATE_UINT64(high, TestGTreeInterval),   \
 VMSTATE_END_OF_LIST()  \
@@ -839,7 +839,7 @@ typedef struct TestGTreeMapping {
 .name = "mapping",\
 .version_id = 1,  \
 .minimum_version_id = 1,  \
-.fields = (VMStateField[]) {  \
+.fields = (const VMStateField[]) {\
 VMSTATE_UINT64(phys_addr, TestGTreeMapping),  \
 VMSTATE_UINT32(flags, TestGTreeMapping),  \
 VMSTATE_END_OF_LIST() \
@@ -915,7 +915,7 @@ static const VMStateDescription vmstate_domain = {
 .version_id = 1,
 .minimum_version_id = 1,
 .pre_load = domain_preload,
-.fields = (VMStateField[]) {
+.fields = (const VMStateField[]) {
 VMSTATE_INT32(id, TestGTreeDomain),
 VMSTATE_GTREE_V(mappings