Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH
On Wed, Jul 6, 2022 at 1:02 PM Zhang, Chen wrote:
>
> > > > > > > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen
> > wrote:
> > > > > > > >
> > > > > > > > If the checkpoint occurs when the guest finishes restarting
> > > > > > > > but has not started running, the runstate_set() may reject
> > > > > > > > the transition from COLO to PRELAUNCH with the crash log:
> > > > > > > >
> > > > > > > > {"timestamp": {"seconds": 1593484591, "microseconds":
> > > > > > > > 26605},\
> > > > > > > > "event": "RESET", "data": {"guest": true, "reason":
> > > > > > > > "guest-reset"}}
> > > > > > > > qemu-system-x86_64: invalid runstate transition: 'colo' ->
> > 'prelaunch'
> > > > > > > >
> > > > > > > > Long-term testing says that it's pretty safe.
> > > > > > > >
> > > > > > > > Signed-off-by: Like Xu
> > > > > > > > Signed-off-by: Zhang Chen
> > > > > > >
> > > > > > > I'd expect this to get ack from the relevant maintainers.
> > > > > > >
> > > > > >
> > > > > > The scripts/get_maintainer.pl can't find relevant maintainers for
> > > > > > this
> > patch.
> > > > > > Maybe Paolo have time to cover this simple patch related to
> > > > > > runstate?
> > > > >
> > > > > No news for a while, any comments for unmaintained files changes ?
> > > > > Ping...
> > > >
> > > > Adding David and Juan.
> > >
> > > This looks OK to me;
> > >
> > > Acked-by: Dr. David Alan Gilbert
> >
> > Great.
> >
> > >
> > > it should be fine to merge it along with the pull that takes the other
> > > patches.
> >
> > Yes, I've queued this series.
>
> Hi Jason, did this series get lost in the net queue branch?
Unfortunately, yes.
It will be included in the net pull request.
Sorry.
>
> Thanks
> Chen
>
> >
> > Thanks
> >
> > >
> > > Dave
> > >
> > > > Thanks
> > > >
> > > > >
> > >
>
RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH
> > > > > > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen
> wrote:
> > > > > > >
> > > > > > > If the checkpoint occurs when the guest finishes restarting
> > > > > > > but has not started running, the runstate_set() may reject
> > > > > > > the transition from COLO to PRELAUNCH with the crash log:
> > > > > > >
> > > > > > > {"timestamp": {"seconds": 1593484591, "microseconds":
> > > > > > > 26605},\
> > > > > > > "event": "RESET", "data": {"guest": true, "reason":
> > > > > > > "guest-reset"}}
> > > > > > > qemu-system-x86_64: invalid runstate transition: 'colo' ->
> 'prelaunch'
> > > > > > >
> > > > > > > Long-term testing says that it's pretty safe.
> > > > > > >
> > > > > > > Signed-off-by: Like Xu
> > > > > > > Signed-off-by: Zhang Chen
> > > > > >
> > > > > > I'd expect this to get ack from the relevant maintainers.
> > > > > >
> > > > >
> > > > > The scripts/get_maintainer.pl can't find relevant maintainers for this
> patch.
> > > > > Maybe Paolo have time to cover this simple patch related to runstate?
> > > >
> > > > No news for a while, any comments for unmaintained files changes ?
> > > > Ping...
> > >
> > > Adding David and Juan.
> >
> > This looks OK to me;
> >
> > Acked-by: Dr. David Alan Gilbert
>
> Great.
>
> >
> > it should be fine to merge it along with the pull that takes the other
> > patches.
>
> Yes, I've queued this series.
Hi Jason, did this series get lost in the net queue branch?
Thanks
Chen
>
> Thanks
>
> >
> > Dave
> >
> > > Thanks
> > >
> > > >
> >
Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH
On Wed, May 18, 2022 at 9:09 PM Dr. David Alan Gilbert
wrote:
>
> * Jason Wang (jasow...@redhat.com) wrote:
> > On Sat, May 7, 2022 at 10:03 AM Zhang, Chen wrote:
> > >
> > >
> > >
> > > > -Original Message-
> > > > From: Zhang, Chen
> > > > Sent: Wednesday, April 27, 2022 5:26 PM
> > > > To: Jason Wang ; Paolo Bonzini
> > > >
> > > > Cc: Li Zhijian ; qemu-dev > > > de...@nongnu.org>; Like Xu
> > > > Subject: RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> > > > support form COLO to PRELAUNCH
> > > >
> > > >
> > > >
> > > > > -Original Message-
> > > > > From: Jason Wang
> > > > > Sent: Wednesday, April 27, 2022 4:57 PM
> > > > > To: Zhang, Chen
> > > > > Cc: Li Zhijian ; qemu-dev > > > > de...@nongnu.org>; Like Xu
> > > > > Subject: Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> > > > > support form COLO to PRELAUNCH
> > > > >
> > > > > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen
> > > > > wrote:
> > > > > >
> > > > > > If the checkpoint occurs when the guest finishes restarting but has
> > > > > > not started running, the runstate_set() may reject the transition
> > > > > > from COLO to PRELAUNCH with the crash log:
> > > > > >
> > > > > > {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\
> > > > > > "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}}
> > > > > > qemu-system-x86_64: invalid runstate transition: 'colo' ->
> > > > > > 'prelaunch'
> > > > > >
> > > > > > Long-term testing says that it's pretty safe.
> > > > > >
> > > > > > Signed-off-by: Like Xu
> > > > > > Signed-off-by: Zhang Chen
> > > > >
> > > > > I'd expect this to get ack from the relevant maintainers.
> > > > >
> > > >
> > > > The scripts/get_maintainer.pl can't find relevant maintainers for this
> > > > patch.
> > > > Maybe Paolo have time to cover this simple patch related to runstate?
> > >
> > > No news for a while, any comments for unmaintained files changes ?
> > > Ping...
> >
> > Adding David and Juan.
>
> This looks OK to me;
>
> Acked-by: Dr. David Alan Gilbert
Great.
>
> it should be fine to merge it along with the pull that takes the other
> patches.
Yes, I've queued this series.
Thanks
>
> Dave
>
> > Thanks
> >
> > >
> > > Thanks
> > > Chen
> > >
> > > >
> > > > Thanks
> > > > Chen
> > > >
> > > > > Thanks
> > > > >
> > > > > > ---
> > > > > > softmmu/runstate.c | 1 +
> > > > > > 1 file changed, 1 insertion(+)
> > > > > >
> > > > > > diff --git a/softmmu/runstate.c b/softmmu/runstate.c index
> > > > > > e0d869b21a..c021c56338 100644
> > > > > > --- a/softmmu/runstate.c
> > > > > > +++ b/softmmu/runstate.c
> > > > > > @@ -127,6 +127,7 @@ static const RunStateTransition
> > > > > runstate_transitions_def[] = {
> > > > > > { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
> > > > > >
> > > > > > { RUN_STATE_COLO, RUN_STATE_RUNNING },
> > > > > > +{ RUN_STATE_COLO, RUN_STATE_PRELAUNCH },
> > > > > > { RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
> > > > > >
> > > > > > { RUN_STATE_RUNNING, RUN_STATE_DEBUG },
> > > > > > --
> > > > > > 2.25.1
> > > > > >
> > >
> >
> --
> Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
>
Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH
* Jason Wang (jasow...@redhat.com) wrote:
> On Sat, May 7, 2022 at 10:03 AM Zhang, Chen wrote:
> >
> >
> >
> > > -Original Message-
> > > From: Zhang, Chen
> > > Sent: Wednesday, April 27, 2022 5:26 PM
> > > To: Jason Wang ; Paolo Bonzini
> > >
> > > Cc: Li Zhijian ; qemu-dev > > de...@nongnu.org>; Like Xu
> > > Subject: RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> > > support form COLO to PRELAUNCH
> > >
> > >
> > >
> > > > -Original Message-
> > > > From: Jason Wang
> > > > Sent: Wednesday, April 27, 2022 4:57 PM
> > > > To: Zhang, Chen
> > > > Cc: Li Zhijian ; qemu-dev > > > de...@nongnu.org>; Like Xu
> > > > Subject: Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> > > > support form COLO to PRELAUNCH
> > > >
> > > > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen wrote:
> > > > >
> > > > > If the checkpoint occurs when the guest finishes restarting but has
> > > > > not started running, the runstate_set() may reject the transition
> > > > > from COLO to PRELAUNCH with the crash log:
> > > > >
> > > > > {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\
> > > > > "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}}
> > > > > qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch'
> > > > >
> > > > > Long-term testing says that it's pretty safe.
> > > > >
> > > > > Signed-off-by: Like Xu
> > > > > Signed-off-by: Zhang Chen
> > > >
> > > > I'd expect this to get ack from the relevant maintainers.
> > > >
> > >
> > > The scripts/get_maintainer.pl can't find relevant maintainers for this
> > > patch.
> > > Maybe Paolo have time to cover this simple patch related to runstate?
> >
> > No news for a while, any comments for unmaintained files changes ?
> > Ping...
>
> Adding David and Juan.
This looks OK to me;
Acked-by: Dr. David Alan Gilbert
it should be fine to merge it along with the pull that takes the other
patches.
Dave
> Thanks
>
> >
> > Thanks
> > Chen
> >
> > >
> > > Thanks
> > > Chen
> > >
> > > > Thanks
> > > >
> > > > > ---
> > > > > softmmu/runstate.c | 1 +
> > > > > 1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/softmmu/runstate.c b/softmmu/runstate.c index
> > > > > e0d869b21a..c021c56338 100644
> > > > > --- a/softmmu/runstate.c
> > > > > +++ b/softmmu/runstate.c
> > > > > @@ -127,6 +127,7 @@ static const RunStateTransition
> > > > runstate_transitions_def[] = {
> > > > > { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
> > > > >
> > > > > { RUN_STATE_COLO, RUN_STATE_RUNNING },
> > > > > +{ RUN_STATE_COLO, RUN_STATE_PRELAUNCH },
> > > > > { RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
> > > > >
> > > > > { RUN_STATE_RUNNING, RUN_STATE_DEBUG },
> > > > > --
> > > > > 2.25.1
> > > > >
> >
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH
On Sat, May 7, 2022 at 10:03 AM Zhang, Chen wrote:
>
>
>
> > -Original Message-
> > From: Zhang, Chen
> > Sent: Wednesday, April 27, 2022 5:26 PM
> > To: Jason Wang ; Paolo Bonzini
> >
> > Cc: Li Zhijian ; qemu-dev > de...@nongnu.org>; Like Xu
> > Subject: RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> > support form COLO to PRELAUNCH
> >
> >
> >
> > > -Original Message-
> > > From: Jason Wang
> > > Sent: Wednesday, April 27, 2022 4:57 PM
> > > To: Zhang, Chen
> > > Cc: Li Zhijian ; qemu-dev > > de...@nongnu.org>; Like Xu
> > > Subject: Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> > > support form COLO to PRELAUNCH
> > >
> > > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen wrote:
> > > >
> > > > If the checkpoint occurs when the guest finishes restarting but has
> > > > not started running, the runstate_set() may reject the transition
> > > > from COLO to PRELAUNCH with the crash log:
> > > >
> > > > {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\
> > > > "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}}
> > > > qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch'
> > > >
> > > > Long-term testing says that it's pretty safe.
> > > >
> > > > Signed-off-by: Like Xu
> > > > Signed-off-by: Zhang Chen
> > >
> > > I'd expect this to get ack from the relevant maintainers.
> > >
> >
> > The scripts/get_maintainer.pl can't find relevant maintainers for this
> > patch.
> > Maybe Paolo have time to cover this simple patch related to runstate?
>
> No news for a while, any comments for unmaintained files changes ?
> Ping...
Adding David and Juan.
Thanks
>
> Thanks
> Chen
>
> >
> > Thanks
> > Chen
> >
> > > Thanks
> > >
> > > > ---
> > > > softmmu/runstate.c | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/softmmu/runstate.c b/softmmu/runstate.c index
> > > > e0d869b21a..c021c56338 100644
> > > > --- a/softmmu/runstate.c
> > > > +++ b/softmmu/runstate.c
> > > > @@ -127,6 +127,7 @@ static const RunStateTransition
> > > runstate_transitions_def[] = {
> > > > { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
> > > >
> > > > { RUN_STATE_COLO, RUN_STATE_RUNNING },
> > > > +{ RUN_STATE_COLO, RUN_STATE_PRELAUNCH },
> > > > { RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
> > > >
> > > > { RUN_STATE_RUNNING, RUN_STATE_DEBUG },
> > > > --
> > > > 2.25.1
> > > >
>
RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH
> -Original Message-
> From: Zhang, Chen
> Sent: Wednesday, April 27, 2022 5:26 PM
> To: Jason Wang ; Paolo Bonzini
>
> Cc: Li Zhijian ; qemu-dev de...@nongnu.org>; Like Xu
> Subject: RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> support form COLO to PRELAUNCH
>
>
>
> > -Original Message-
> > From: Jason Wang
> > Sent: Wednesday, April 27, 2022 4:57 PM
> > To: Zhang, Chen
> > Cc: Li Zhijian ; qemu-dev > de...@nongnu.org>; Like Xu
> > Subject: Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> > support form COLO to PRELAUNCH
> >
> > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen wrote:
> > >
> > > If the checkpoint occurs when the guest finishes restarting but has
> > > not started running, the runstate_set() may reject the transition
> > > from COLO to PRELAUNCH with the crash log:
> > >
> > > {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\
> > > "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}}
> > > qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch'
> > >
> > > Long-term testing says that it's pretty safe.
> > >
> > > Signed-off-by: Like Xu
> > > Signed-off-by: Zhang Chen
> >
> > I'd expect this to get ack from the relevant maintainers.
> >
>
> The scripts/get_maintainer.pl can't find relevant maintainers for this patch.
> Maybe Paolo have time to cover this simple patch related to runstate?
No news for a while, any comments for unmaintained files changes ?
Ping...
Thanks
Chen
>
> Thanks
> Chen
>
> > Thanks
> >
> > > ---
> > > softmmu/runstate.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/softmmu/runstate.c b/softmmu/runstate.c index
> > > e0d869b21a..c021c56338 100644
> > > --- a/softmmu/runstate.c
> > > +++ b/softmmu/runstate.c
> > > @@ -127,6 +127,7 @@ static const RunStateTransition
> > runstate_transitions_def[] = {
> > > { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
> > >
> > > { RUN_STATE_COLO, RUN_STATE_RUNNING },
> > > +{ RUN_STATE_COLO, RUN_STATE_PRELAUNCH },
> > > { RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
> > >
> > > { RUN_STATE_RUNNING, RUN_STATE_DEBUG },
> > > --
> > > 2.25.1
> > >
RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH
> -Original Message-
> From: Jason Wang
> Sent: Wednesday, April 27, 2022 4:57 PM
> To: Zhang, Chen
> Cc: Li Zhijian ; qemu-dev de...@nongnu.org>; Like Xu
> Subject: Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> support form COLO to PRELAUNCH
>
> On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen wrote:
> >
> > If the checkpoint occurs when the guest finishes restarting but has
> > not started running, the runstate_set() may reject the transition from
> > COLO to PRELAUNCH with the crash log:
> >
> > {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\
> > "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}}
> > qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch'
> >
> > Long-term testing says that it's pretty safe.
> >
> > Signed-off-by: Like Xu
> > Signed-off-by: Zhang Chen
>
> I'd expect this to get ack from the relevant maintainers.
>
The scripts/get_maintainer.pl can't find relevant maintainers for this patch.
Maybe Paolo have time to cover this simple patch related to runstate?
Thanks
Chen
> Thanks
>
> > ---
> > softmmu/runstate.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/softmmu/runstate.c b/softmmu/runstate.c index
> > e0d869b21a..c021c56338 100644
> > --- a/softmmu/runstate.c
> > +++ b/softmmu/runstate.c
> > @@ -127,6 +127,7 @@ static const RunStateTransition
> runstate_transitions_def[] = {
> > { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
> >
> > { RUN_STATE_COLO, RUN_STATE_RUNNING },
> > +{ RUN_STATE_COLO, RUN_STATE_PRELAUNCH },
> > { RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
> >
> > { RUN_STATE_RUNNING, RUN_STATE_DEBUG },
> > --
> > 2.25.1
> >
Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH
On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen wrote:
>
> If the checkpoint occurs when the guest finishes restarting
> but has not started running, the runstate_set() may reject
> the transition from COLO to PRELAUNCH with the crash log:
>
> {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\
> "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}}
> qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch'
>
> Long-term testing says that it's pretty safe.
>
> Signed-off-by: Like Xu
> Signed-off-by: Zhang Chen
I'd expect this to get ack from the relevant maintainers.
Thanks
> ---
> softmmu/runstate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/softmmu/runstate.c b/softmmu/runstate.c
> index e0d869b21a..c021c56338 100644
> --- a/softmmu/runstate.c
> +++ b/softmmu/runstate.c
> @@ -127,6 +127,7 @@ static const RunStateTransition
> runstate_transitions_def[] = {
> { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
>
> { RUN_STATE_COLO, RUN_STATE_RUNNING },
> +{ RUN_STATE_COLO, RUN_STATE_PRELAUNCH },
> { RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
>
> { RUN_STATE_RUNNING, RUN_STATE_DEBUG },
> --
> 2.25.1
>
[PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH
If the checkpoint occurs when the guest finishes restarting
but has not started running, the runstate_set() may reject
the transition from COLO to PRELAUNCH with the crash log:
{"timestamp": {"seconds": 1593484591, "microseconds": 26605},\
"event": "RESET", "data": {"guest": true, "reason": "guest-reset"}}
qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch'
Long-term testing says that it's pretty safe.
Signed-off-by: Like Xu
Signed-off-by: Zhang Chen
---
softmmu/runstate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/softmmu/runstate.c b/softmmu/runstate.c
index e0d869b21a..c021c56338 100644
--- a/softmmu/runstate.c
+++ b/softmmu/runstate.c
@@ -127,6 +127,7 @@ static const RunStateTransition runstate_transitions_def[]
= {
{ RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
{ RUN_STATE_COLO, RUN_STATE_RUNNING },
+{ RUN_STATE_COLO, RUN_STATE_PRELAUNCH },
{ RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
{ RUN_STATE_RUNNING, RUN_STATE_DEBUG },
--
2.25.1
