Re: [PATCH for-6.2 v2] s390-sclp-events-bus: Use OBJECT_DECLARE_SIMPLE_TYPE

2021-08-06 Thread Cornelia Huck 
On Thu, Aug 05 2021, Eduardo Habkost  wrote:

> We have a SCLPEventsBus struct type defined, but no QOM type
> checkers are declared for the type.
>
> Use OBJECT_DECLARE_SIMPLE_TYPE to declare the struct type and
> have a SCLP_EVENT_BUS typecast wrapper defined.
>
> Signed-off-by: Eduardo Habkost 
> ---
> Changes v1 -> v2:
> * v1 was previously submitted as part of series:
>   [PATCH for-6.2 0/6] qom: Fix broken OBJECT_CHECK usage
>   at 
> https://lore.kernel.org/qemu-devel/20210805193431.307761-5-ehabk...@redhat.com
> * Fix typo (s/SCLP_EVENT_BUS/SCLP_EVENTS_BUS/)
>
> Cc: Richard Henderson 
> Cc: David Hildenbrand 
> Cc: Cornelia Huck 
> Cc: Halil Pasic 
> Cc: Christian Borntraeger 
> Cc: Thomas Huth 
> Cc: qemu-s3...@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
>  hw/s390x/event-facility.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Cornelia Huck

Re: [PATCH for-6.2 v2] s390-sclp-events-bus: Use OBJECT_DECLARE_SIMPLE_TYPE

2021-08-06 Thread David Hildenbrand 

On 06.08.21 04:46, Eduardo Habkost wrote:

We have a SCLPEventsBus struct type defined, but no QOM type
checkers are declared for the type.

Use OBJECT_DECLARE_SIMPLE_TYPE to declare the struct type and
have a SCLP_EVENT_BUS typecast wrapper defined.

Signed-off-by: Eduardo Habkost 
---
Changes v1 -> v2:
* v1 was previously submitted as part of series:
   [PATCH for-6.2 0/6] qom: Fix broken OBJECT_CHECK usage
   at 
https://lore.kernel.org/qemu-devel/20210805193431.307761-5-ehabk...@redhat.com
* Fix typo (s/SCLP_EVENT_BUS/SCLP_EVENTS_BUS/)

Cc: Richard Henderson 
Cc: David Hildenbrand 
Cc: Cornelia Huck 
Cc: Halil Pasic 
Cc: Christian Borntraeger 
Cc: Thomas Huth 
Cc: qemu-s3...@nongnu.org
Cc: qemu-devel@nongnu.org
---
  hw/s390x/event-facility.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
index ed92ce510d9..4bfd0b194b4 100644
--- a/hw/s390x/event-facility.c
+++ b/hw/s390x/event-facility.c
@@ -328,6 +328,7 @@ static void write_event_mask(SCLPEventFacility *ef, SCCB 
*sccb)
  /* qemu object creation and initialization functions */
  
  #define TYPE_SCLP_EVENTS_BUS "s390-sclp-events-bus"

+OBJECT_DECLARE_SIMPLE_TYPE(SCLPEventsBus, SCLP_EVENTS_BUS)
  
  static const TypeInfo sclp_events_bus_info = {

  .name = TYPE_SCLP_EVENTS_BUS,



Reviewed-by: David Hildenbrand 

--
Thanks,

David / dhildenb

Re: [PATCH for-6.2 v2] s390-sclp-events-bus: Use OBJECT_DECLARE_SIMPLE_TYPE

2021-08-05 Thread Thomas Huth 

On 06/08/2021 04.46, Eduardo Habkost wrote:

We have a SCLPEventsBus struct type defined, but no QOM type
checkers are declared for the type.

Use OBJECT_DECLARE_SIMPLE_TYPE to declare the struct type and
have a SCLP_EVENT_BUS typecast wrapper defined.

Signed-off-by: Eduardo Habkost 
---
Changes v1 -> v2:
* v1 was previously submitted as part of series:
   [PATCH for-6.2 0/6] qom: Fix broken OBJECT_CHECK usage
   at 
https://lore.kernel.org/qemu-devel/20210805193431.307761-5-ehabk...@redhat.com
* Fix typo (s/SCLP_EVENT_BUS/SCLP_EVENTS_BUS/)

Cc: Richard Henderson 
Cc: David Hildenbrand 
Cc: Cornelia Huck 
Cc: Halil Pasic 
Cc: Christian Borntraeger 
Cc: Thomas Huth 
Cc: qemu-s3...@nongnu.org
Cc: qemu-devel@nongnu.org
---
  hw/s390x/event-facility.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
index ed92ce510d9..4bfd0b194b4 100644
--- a/hw/s390x/event-facility.c
+++ b/hw/s390x/event-facility.c
@@ -328,6 +328,7 @@ static void write_event_mask(SCLPEventFacility *ef, SCCB 
*sccb)
  /* qemu object creation and initialization functions */
  
  #define TYPE_SCLP_EVENTS_BUS "s390-sclp-events-bus"

+OBJECT_DECLARE_SIMPLE_TYPE(SCLPEventsBus, SCLP_EVENTS_BUS)
  
  static const TypeInfo sclp_events_bus_info = {

  .name = TYPE_SCLP_EVENTS_BUS,



Reviewed-by: Thomas Huth

[PATCH for-6.2 v2] s390-sclp-events-bus: Use OBJECT_DECLARE_SIMPLE_TYPE

2021-08-05 Thread Eduardo Habkost 
We have a SCLPEventsBus struct type defined, but no QOM type
checkers are declared for the type.

Use OBJECT_DECLARE_SIMPLE_TYPE to declare the struct type and
have a SCLP_EVENT_BUS typecast wrapper defined.

Signed-off-by: Eduardo Habkost 
---
Changes v1 -> v2:
* v1 was previously submitted as part of series:
  [PATCH for-6.2 0/6] qom: Fix broken OBJECT_CHECK usage
  at 
https://lore.kernel.org/qemu-devel/20210805193431.307761-5-ehabk...@redhat.com
* Fix typo (s/SCLP_EVENT_BUS/SCLP_EVENTS_BUS/)

Cc: Richard Henderson 
Cc: David Hildenbrand 
Cc: Cornelia Huck 
Cc: Halil Pasic 
Cc: Christian Borntraeger 
Cc: Thomas Huth 
Cc: qemu-s3...@nongnu.org
Cc: qemu-devel@nongnu.org
---
 hw/s390x/event-facility.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
index ed92ce510d9..4bfd0b194b4 100644
--- a/hw/s390x/event-facility.c
+++ b/hw/s390x/event-facility.c
@@ -328,6 +328,7 @@ static void write_event_mask(SCLPEventFacility *ef, SCCB 
*sccb)
 /* qemu object creation and initialization functions */
 
 #define TYPE_SCLP_EVENTS_BUS "s390-sclp-events-bus"
+OBJECT_DECLARE_SIMPLE_TYPE(SCLPEventsBus, SCLP_EVENTS_BUS)
 
 static const TypeInfo sclp_events_bus_info = {
 .name = TYPE_SCLP_EVENTS_BUS,
-- 
2.31.1