Re: [PATCH v1 0/3] unit tests for change 'do not add hotplug related amls for cold plugged bridges'
On Fri, Sep 11, 2020 at 9:51 PM Ani Sinha wrote: > > I can't repro the breakage. What test command line are you running > with? I am using " make check-qtest-x86_64 V=1" Ok I was working off v5.1.0 tag. Did not realize. I rebased all my patches to the latest master and reworked the unit tests. I have sent you the entire patch set as exists in my workspace. It passes unit tests. > > On Fri, Sep 11, 2020 at 9:41 PM Ani Sinha wrote: > > > > On Fri, Sep 11, 2020 at 9:38 PM Michael S. Tsirkin wrote: > > > > > > > > > I am not sure why, but the expected files did not match for me. > > > > > > I dropped these for now: > > > > > > tests/acpi: add a new ACPI table in order to test root pci hotplug on/off > > > tests/acpi: add a new unit test to test hotplug off/on feature on the > > > root pci bus > > > tests/acpi: document addition of table DSDT.roothp for unit testing root > > > pci hotplug on/off > > > > This was already reviewed by Igor. > > > > > tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug > > > flag > > > tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge > > > flag > > > tests/acpi: list added acpi table binary file for pci bridge hotplug test > > > > > > > I will double check this one. > > > > > I suspect you have another change in there. > > > > > > Pls check and post a single series with all these tests. > > > > > > -- > > > MST > > >
Re: [PATCH v1 0/3] unit tests for change 'do not add hotplug related amls for cold plugged bridges'
I can't repro the breakage. What test command line are you running with? I am using " make check-qtest-x86_64 V=1" On Fri, Sep 11, 2020 at 9:41 PM Ani Sinha wrote: > > On Fri, Sep 11, 2020 at 9:38 PM Michael S. Tsirkin wrote: > > > > > > I am not sure why, but the expected files did not match for me. > > > > I dropped these for now: > > > > tests/acpi: add a new ACPI table in order to test root pci hotplug on/off > > tests/acpi: add a new unit test to test hotplug off/on feature on the root > > pci bus > > tests/acpi: document addition of table DSDT.roothp for unit testing root > > pci hotplug on/off > > This was already reviewed by Igor. > > > tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag > > tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag > > tests/acpi: list added acpi table binary file for pci bridge hotplug test > > > > I will double check this one. > > > I suspect you have another change in there. > > > > Pls check and post a single series with all these tests. > > > > -- > > MST > >
Re: [PATCH v1 0/3] unit tests for change 'do not add hotplug related amls for cold plugged bridges'
On Fri, Sep 11, 2020 at 9:38 PM Michael S. Tsirkin wrote: > > > I am not sure why, but the expected files did not match for me. > > I dropped these for now: > > tests/acpi: add a new ACPI table in order to test root pci hotplug on/off > tests/acpi: add a new unit test to test hotplug off/on feature on the root > pci bus > tests/acpi: document addition of table DSDT.roothp for unit testing root pci > hotplug on/off This was already reviewed by Igor. > tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag > tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag > tests/acpi: list added acpi table binary file for pci bridge hotplug test > I will double check this one. > I suspect you have another change in there. > > Pls check and post a single series with all these tests. > > -- > MST >
Re: [PATCH v1 0/3] unit tests for change 'do not add hotplug related amls for cold plugged bridges'
I am not sure why, but the expected files did not match for me. I dropped these for now: tests/acpi: add a new ACPI table in order to test root pci hotplug on/off tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus tests/acpi: document addition of table DSDT.roothp for unit testing root pci hotplug on/off tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag tests/acpi: list added acpi table binary file for pci bridge hotplug test I suspect you have another change in there. Pls check and post a single series with all these tests. -- MST
Re: [PATCH v1 0/3] unit tests for change 'do not add hotplug related amls for cold plugged bridges'
On Sat, Sep 5, 2020 at 4:05 PM Ani Sinha wrote:
>
> The following patchset adds the unit test for the change:
> f80ba9e599 ("tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support'
> bridge flag")
Apologies. This change is incorrect. It should be :
e78c1c9a2e ("i440fx/acpi: do not add hotplug related amls for cold
plugged bridges")
>
> Please compare the diff of the DSDT table attached with the commit log with
> the following diff which
> was generated before appplying the above change. The major difference between
> the diffs are the absence
> of the following lines in the diff corresponding to this change:
>
> +Name (_SUN, 0x03) // _SUN: Slot User Number
> +Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
> {
> +PCEJ (BSEL, _SUN)
>
> +If ((Arg0 & 0x08))
> +{
> +Notify (S18, Arg1)
> +}
> +
>
> These are hotplug related amls which were present for slot 3 in the root pci
> bus before this change was applied.
> With the change, these amls have been removed. Hence, slot 3 where the bridge
> is attached is no longer hotplug
> capable.
>
> --Ani
>
> @@ -1,30 +1,30 @@
> /*
> * Intel ACPI Component Architecture
> * AML/ASL+ Disassembler version 20180105 (64-bit version)
> * Copyright (c) 2000 - 2018 Intel Corporation
> *
> * Disassembling to symbolic ASL+ operators
> *
> - * Disassembly of tests/data/acpi/pc/DSDT.bridge, Fri Sep 4 11:08:58 2020
> + * Disassembly of /tmp/aml-IEQEQ0, Fri Sep 4 11:08:58 2020
> *
> * Original Table Header:
> * Signature"DSDT"
> - * Length 0x1A89 (6793)
> + * Length 0x1346 (4934)
> * Revision 0x01 32-bit table (V1), no 64-bit math support
> - * Checksum 0x08
> + * Checksum 0xBF
> * OEM ID "BOCHS "
> * OEM Table ID "BXPCDSDT"
> * OEM Revision 0x0001 (1)
> * Compiler ID "BXPC"
> * Compiler Version 0x0001 (1)
> */
> DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x0001)
> {
> Scope (\)
> {
> OperationRegion (DBG, SystemIO, 0x0402, One)
> Field (DBG, ByteAcc, NoLock, Preserve)
> {
> DBGB, 8
> }
>
> @@ -859,521 +859,36 @@
> }
>
> Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State
> {
> Return (Zero)
> }
>
> Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State
> {
> Return (Zero)
> }
> }
>
> Device (S18)
> {
> Name (_ADR, 0x0003) // _ADR: Address
> -Name (BSEL, One)
> -Device (S00)
> -{
> -Name (_SUN, Zero) // _SUN: Slot User Number
> -Name (_ADR, Zero) // _ADR: Address
> -Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
> -{
> -PCEJ (BSEL, _SUN)
> -}
> -}
> -
> -Device (S08)
> -{
> -Name (_SUN, One) // _SUN: Slot User Number
> -Name (_ADR, 0x0001) // _ADR: Address
> -Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
> -{
> -PCEJ (BSEL, _SUN)
> -}
> -}
> -
> -Device (S10)
> -{
> -Name (_SUN, 0x02) // _SUN: Slot User Number
> -Name (_ADR, 0x0002) // _ADR: Address
> -Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
> -{
> -PCEJ (BSEL, _SUN)
> -}
> -}
> -
> -Device (S18)
> -{
> -Name (_SUN, 0x03) // _SUN: Slot User Number
> -Name (_ADR, 0x0003) // _ADR: Address
> -Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
> -{
> -PCEJ (BSEL, _SUN)
> -}
> -}
> -
> -Device (S20)
> -{
> -Name (_SUN, 0x04) // _SUN: Slot User Number
> -Name (_ADR, 0x0004) // _ADR: Address
> -Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
> -{
> -PCEJ (BSEL, _SUN)
> -}
> -}
> -
> -Device (S28)
> -{
> -Name (_SUN, 0x05) // _SUN: Slot User Number
> -Name (_ADR, 0x0005) // _ADR: Address
> -
[PATCH v1 0/3] unit tests for change 'do not add hotplug related amls for cold plugged bridges'
The following patchset adds the unit test for the change:
f80ba9e599 ("tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support'
bridge flag")
Please compare the diff of the DSDT table attached with the commit log with the
following diff which
was generated before appplying the above change. The major difference between
the diffs are the absence
of the following lines in the diff corresponding to this change:
+Name (_SUN, 0x03) // _SUN: Slot User Number
+Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
{
+PCEJ (BSEL, _SUN)
+If ((Arg0 & 0x08))
+{
+Notify (S18, Arg1)
+}
+
These are hotplug related amls which were present for slot 3 in the root pci
bus before this change was applied.
With the change, these amls have been removed. Hence, slot 3 where the bridge
is attached is no longer hotplug
capable.
--Ani
@@ -1,30 +1,30 @@
/*
* Intel ACPI Component Architecture
* AML/ASL+ Disassembler version 20180105 (64-bit version)
* Copyright (c) 2000 - 2018 Intel Corporation
*
* Disassembling to symbolic ASL+ operators
*
- * Disassembly of tests/data/acpi/pc/DSDT.bridge, Fri Sep 4 11:08:58 2020
+ * Disassembly of /tmp/aml-IEQEQ0, Fri Sep 4 11:08:58 2020
*
* Original Table Header:
* Signature"DSDT"
- * Length 0x1A89 (6793)
+ * Length 0x1346 (4934)
* Revision 0x01 32-bit table (V1), no 64-bit math support
- * Checksum 0x08
+ * Checksum 0xBF
* OEM ID "BOCHS "
* OEM Table ID "BXPCDSDT"
* OEM Revision 0x0001 (1)
* Compiler ID "BXPC"
* Compiler Version 0x0001 (1)
*/
DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x0001)
{
Scope (\)
{
OperationRegion (DBG, SystemIO, 0x0402, One)
Field (DBG, ByteAcc, NoLock, Preserve)
{
DBGB, 8
}
@@ -859,521 +859,36 @@
}
Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State
{
Return (Zero)
}
Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State
{
Return (Zero)
}
}
Device (S18)
{
Name (_ADR, 0x0003) // _ADR: Address
-Name (BSEL, One)
-Device (S00)
-{
-Name (_SUN, Zero) // _SUN: Slot User Number
-Name (_ADR, Zero) // _ADR: Address
-Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
-{
-PCEJ (BSEL, _SUN)
-}
-}
-
-Device (S08)
-{
-Name (_SUN, One) // _SUN: Slot User Number
-Name (_ADR, 0x0001) // _ADR: Address
-Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
-{
-PCEJ (BSEL, _SUN)
-}
-}
-
-Device (S10)
-{
-Name (_SUN, 0x02) // _SUN: Slot User Number
-Name (_ADR, 0x0002) // _ADR: Address
-Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
-{
-PCEJ (BSEL, _SUN)
-}
-}
-
-Device (S18)
-{
-Name (_SUN, 0x03) // _SUN: Slot User Number
-Name (_ADR, 0x0003) // _ADR: Address
-Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
-{
-PCEJ (BSEL, _SUN)
-}
-}
-
-Device (S20)
-{
-Name (_SUN, 0x04) // _SUN: Slot User Number
-Name (_ADR, 0x0004) // _ADR: Address
-Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
-{
-PCEJ (BSEL, _SUN)
-}
-}
-
-Device (S28)
-{
-Name (_SUN, 0x05) // _SUN: Slot User Number
-Name (_ADR, 0x0005) // _ADR: Address
-Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
-{
-PCEJ (BSEL, _SUN)
-}
-}
-
-Device (S30)
-{
-Name (_SUN, 0x06) // _SUN: Slot User Number
-Name (_ADR, 0x0006) // _ADR: Address
-Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
-{
