Re: [PATCH v2 0/1] Coverity fixes in hw/ppc/spapr_nvdimm.c
On 7/20/22 09:34, Peter Maydell wrote: On Sat, 9 Apr 2022 at 21:11, Daniel Henrique Barboza wrote: Changes from v1: - clarified in the commit message which kind of errors we aim to prevent - changed the H_HARDWARE return to g_assert() exit - v1 link: https://lists.gnu.org/archive/html/qemu-devel/2022-04/msg00569.html Daniel Henrique Barboza (1): hw/ppc: check if spapr_drc_index() returns NULL in spapr_nvdimm.c hw/ppc/spapr_nvdimm.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) Hi -- I was just going through old-but-unclosed Coverity issues, and it looks like this patch fixing one got lost somewhere along the line. Could somebody pick it up for the ppc tree, please? I can pick it for the next PR. Just need someone else to ack it. Thanks, Daniel thanks -- PMM
Re: [PATCH v2 0/1] Coverity fixes in hw/ppc/spapr_nvdimm.c
On Sat, 9 Apr 2022 at 21:11, Daniel Henrique Barboza wrote: > > Changes from v1: > - clarified in the commit message which kind of errors we aim to prevent > - changed the H_HARDWARE return to g_assert() exit > - v1 link: https://lists.gnu.org/archive/html/qemu-devel/2022-04/msg00569.html > > Daniel Henrique Barboza (1): > hw/ppc: check if spapr_drc_index() returns NULL in spapr_nvdimm.c > > hw/ppc/spapr_nvdimm.c | 18 ++ > 1 file changed, 14 insertions(+), 4 deletions(-) Hi -- I was just going through old-but-unclosed Coverity issues, and it looks like this patch fixing one got lost somewhere along the line. Could somebody pick it up for the ppc tree, please? thanks -- PMM
Re: [PATCH v2 0/1] Coverity fixes in hw/ppc/spapr_nvdimm.c
Ping On 4/9/22 17:08, Daniel Henrique Barboza wrote: Changes from v1: - clarified in the commit message which kind of errors we aim to prevent - changed the H_HARDWARE return to g_assert() exit - v1 link: https://lists.gnu.org/archive/html/qemu-devel/2022-04/msg00569.html Daniel Henrique Barboza (1): hw/ppc: check if spapr_drc_index() returns NULL in spapr_nvdimm.c hw/ppc/spapr_nvdimm.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-)
[PATCH v2 0/1] Coverity fixes in hw/ppc/spapr_nvdimm.c
Changes from v1: - clarified in the commit message which kind of errors we aim to prevent - changed the H_HARDWARE return to g_assert() exit - v1 link: https://lists.gnu.org/archive/html/qemu-devel/2022-04/msg00569.html Daniel Henrique Barboza (1): hw/ppc: check if spapr_drc_index() returns NULL in spapr_nvdimm.c hw/ppc/spapr_nvdimm.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) -- 2.35.1